You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Vinod Kone <vi...@gmail.com> on 2013/08/10 00:05:23 UTC
Review Request 13450: Fixed slave to not recover terminated executors.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13450/
-----------------------------------------------------------
Review request for mesos, Benjamin Hindman and Ben Mahler.
Repository: mesos-git
Description
-------
Sometimes slave gets informed about a terminated executor by the recovering isolator before it gets to '__recover()'. In that case, the slave can simply skip trying to reconnect/kill the executor.
Diffs
-----
src/slave/monitor.cpp 4f3c91fce94918de43d7ad0b598d4902a46be8b6
src/slave/slave.cpp 3b4911844e19c85a97c79b22ef90897b26f26aac
src/slave/status_update_manager.hpp da927606dea63b62d99baac529a3fe371f2767ba
src/slave/status_update_manager.cpp ffd47369e49f711f984787cd3710f7b4dd5b29ce
Diff: https://reviews.apache.org/r/13450/diff/
Testing
-------
make check
Thanks,
Vinod Kone
Re: Review Request 13450: Fixed slave to not recover terminated executors.
Posted by Vinod Kone <vi...@gmail.com>.
> On Aug. 9, 2013, 10:25 p.m., Ben Mahler wrote:
> > src/slave/slave.cpp, lines 2613-2615
> > <https://reviews.apache.org/r/13450/diff/1/?file=339437#file339437line2613>
> >
> > Is that an example or is that the _only_ way this can happen?
the only way afaict.
> On Aug. 9, 2013, 10:25 p.m., Ben Mahler wrote:
> > src/slave/slave.cpp, line 2611
> > <https://reviews.apache.org/r/13450/diff/1/?file=339437#file339437line2611>
> >
> > kill newline?
done
- Vinod
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13450/#review24949
-----------------------------------------------------------
On Aug. 9, 2013, 10:05 p.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13450/
> -----------------------------------------------------------
>
> (Updated Aug. 9, 2013, 10:05 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Ben Mahler.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Sometimes slave gets informed about a terminated executor by the recovering isolator before it gets to '__recover()'. In that case, the slave can simply skip trying to reconnect/kill the executor.
>
>
> Diffs
> -----
>
> src/slave/monitor.cpp 4f3c91fce94918de43d7ad0b598d4902a46be8b6
> src/slave/slave.cpp 3b4911844e19c85a97c79b22ef90897b26f26aac
> src/slave/status_update_manager.hpp da927606dea63b62d99baac529a3fe371f2767ba
> src/slave/status_update_manager.cpp ffd47369e49f711f984787cd3710f7b4dd5b29ce
>
> Diff: https://reviews.apache.org/r/13450/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Vinod Kone
>
>
Re: Review Request 13450: Fixed slave to not recover terminated executors.
Posted by Ben Mahler <be...@gmail.com>.
> On Aug. 9, 2013, 10:25 p.m., Ben Mahler wrote:
> > src/slave/slave.cpp, lines 2613-2615
> > <https://reviews.apache.org/r/13450/diff/1/?file=339437#file339437line2613>
> >
> > Is that an example or is that the _only_ way this can happen?
>
> Vinod Kone wrote:
> the only way afaict.
Ok, if it's the only way can you state is as such? Rather than listing it as a possible example?
- Ben
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13450/#review24949
-----------------------------------------------------------
On Aug. 12, 2013, 1:10 a.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13450/
> -----------------------------------------------------------
>
> (Updated Aug. 12, 2013, 1:10 a.m.)
>
>
> Review request for mesos, Benjamin Hindman and Ben Mahler.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Sometimes slave gets informed about a terminated executor by the recovering isolator before it gets to '__recover()'. In that case, the slave can simply skip trying to reconnect/kill the executor.
>
>
> Diffs
> -----
>
> src/slave/monitor.cpp 4f3c91fce94918de43d7ad0b598d4902a46be8b6
> src/slave/slave.cpp 3b4911844e19c85a97c79b22ef90897b26f26aac
> src/slave/status_update_manager.hpp da927606dea63b62d99baac529a3fe371f2767ba
> src/slave/status_update_manager.cpp ffd47369e49f711f984787cd3710f7b4dd5b29ce
>
> Diff: https://reviews.apache.org/r/13450/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Vinod Kone
>
>
Re: Review Request 13450: Fixed slave to not recover terminated executors.
Posted by Ben Mahler <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13450/#review24949
-----------------------------------------------------------
Ship it!
src/slave/slave.cpp
<https://reviews.apache.org/r/13450/#comment49121>
kill newline?
src/slave/slave.cpp
<https://reviews.apache.org/r/13450/#comment49122>
Is that an example or is that the _only_ way this can happen?
- Ben Mahler
On Aug. 9, 2013, 10:05 p.m., Vinod Kone wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/13450/
> -----------------------------------------------------------
>
> (Updated Aug. 9, 2013, 10:05 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Ben Mahler.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Sometimes slave gets informed about a terminated executor by the recovering isolator before it gets to '__recover()'. In that case, the slave can simply skip trying to reconnect/kill the executor.
>
>
> Diffs
> -----
>
> src/slave/monitor.cpp 4f3c91fce94918de43d7ad0b598d4902a46be8b6
> src/slave/slave.cpp 3b4911844e19c85a97c79b22ef90897b26f26aac
> src/slave/status_update_manager.hpp da927606dea63b62d99baac529a3fe371f2767ba
> src/slave/status_update_manager.cpp ffd47369e49f711f984787cd3710f7b4dd5b29ce
>
> Diff: https://reviews.apache.org/r/13450/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Vinod Kone
>
>
Re: Review Request 13450: Fixed slave to not recover terminated executors.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/13450/
-----------------------------------------------------------
(Updated Aug. 12, 2013, 1:10 a.m.)
Review request for mesos, Benjamin Hindman and Ben Mahler.
Changes
-------
benm's. NNFR.
Repository: mesos-git
Description
-------
Sometimes slave gets informed about a terminated executor by the recovering isolator before it gets to '__recover()'. In that case, the slave can simply skip trying to reconnect/kill the executor.
Diffs (updated)
-----
src/slave/monitor.cpp 4f3c91fce94918de43d7ad0b598d4902a46be8b6
src/slave/slave.cpp 3b4911844e19c85a97c79b22ef90897b26f26aac
src/slave/status_update_manager.hpp da927606dea63b62d99baac529a3fe371f2767ba
src/slave/status_update_manager.cpp ffd47369e49f711f984787cd3710f7b4dd5b29ce
Diff: https://reviews.apache.org/r/13450/diff/
Testing
-------
make check
Thanks,
Vinod Kone