You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jdo-dev@db.apache.org by Michael Bouschen <mb...@apache.org> on 2023/10/30 20:50:15 UTC

JDO TCK meeting Tuesday October 31 1200 PDT 2000 CET

Hi,

We will have our regular meeting Tuesday October 31 1200 PDT 2000 CET to 
discuss JDO TCK issues and status.

We use the following dial-in for audio and video:
https://us02web.zoom.us/j/87074698575?pwd=bmZXeVV3dVowRHFDWk9KWFdVWjc3dz09

Agenda:

1. JDO-830: "tck: Migrate JUnit tests to version 5" 
https://issues.apache.org/jira/browse/JDO-830

2. JIRA JDO-831: "tck: improve tck tests for performance" 
https://issues.apache.org/jira/browse/JDO-831

3. sonarcloud issues

JIRA JDO-819 "Code quality analysis" 
https://issues.apache.org/jira/browse/JDO-819
JIRA JDO-823 "Fix sonarcloud issues of type Code Smells" 
https://issues.apache.org/jira/browse/JDO-823

Sonarcloud link:https://sonarcloud.io/summary/overall?id=db-jdo

* Cognitive Complexity of methods should not be too high:
https://sonarcloud.io/project/issues?resolved=false&rules=java%3AS3776&severities=CRITICAL&types=CODE_SMELL&id=db-jdo 


* Raw types should not be used:
https://sonarcloud.io/project/issues?resolved=false&rules=java%3AS3740&severities=MAJOR&id=db-jdo 



4. JIRA JDO-822: "Verify compatibility with JDK 21" 
https://issues.apache.org/jira/browse/JDO-822
New comments

5. JIRA JDO-812 "Move to JDK 11 as the lowest supported version" 
https://issues.apache.org/jira/browse/JDO-812

6. Other issues

Action Items from weeks past:
[Jul 13 2023] AI All Open a new JIRA for Android since having JNDI in 
the API disallows use with Android
[Jun 08 2023] AI All make a JIRA: JDO support for Java 
Recordshttps://openjdk.org/jeps/395
[May 24 2023] AI Tobias add JDK 20 to the build request for GitHub for 
testing.
[Dec 09 2021] AI Craig: Try to contact all current/former participants 
in JDO development and see if and how they want to be recognized on the 
JDO and DB web sites.https://db.apache.org/whoweare.html
[Oct 07 2021] AI Craig send a private message to all JSR-243 Expert 
Group members asking if they wish to continue.
[Mar 25 2021] AI Craig: investigate "merging" papajdo and apache.clr 
accounts
[Oct 17 2014] AI Matthew any updates for "Modify specification to 
address NoSQL datastores "https://issues.apache.org/jira/browse/JDO-651


Re: Minutes: JDO TCK meeting Tuesday October 31 1200 PDT 2000 CET

Posted by Michael Bouschen <mb...@apache.org>.
Hi Tilmann,

good idea!

I created PR #85 https://github.com/apache/db-jdo/pull/85

Regards
Michael

> Hi Michael,
>
> could you create PR?
>
> That would simplify reviewing the code.
>
> I think I can create a PR if you agree?
>
> Best,
> Til
>
>
> On 02/11/2023 20:28, Michael Bouschen wrote:
>> Hi,
>>> 1. JDO-830: "tck: Migrate JUnit tests to version 
>>> 5"https://issues.apache.org/jira/browse/JDO-830
>>>
>>> Currently using JUnit 5.9.3. But it no longer works subclassing the 
>>> ConsoleLauncher because now with JUnit 5.10.0. the execute method no 
>>> longer returns the number of tests, errors, failures, etc. So we 
>>> will need to look into where the information is stored so we can 
>>> maintain compatibility with how it works today.
>>>
>>> See the branch at:https://github.com/apache/db-jdo/tree/JDO-830
>>>
>>> ...
>>
>> Update: JUnit provides an Interface TestExecutionListener and an
>> implementing class SummaryGeneratingListener that calculates the
>> number of tests, succeeds, failures etc.
>> I could add a subclass of SummaryGeneratingListener that prints the
>> test result in the file TCK-results.txt. This class is activated
>> through a service provider interface, so I added a file
>> org.junit.platform.launcher.TestExecutionListener under
>> META-INF/services including the name of the subclass
>> TCKSummaryGeneratingListener. I think this is the intended way to
>> handle the test execution result.
>>
>> You find the update in the branch
>> https://github.com/apache/db-jdo/tree/JDO-830.
>>
>> Regards
>> Michael
>>
>> -- 
>> Michael Bouschen
>> akquinet tech@spree GmbH
>> Bülowstraße 66 • D-10783 Berlin
>> Tel:   +49 30 235520-0
>> Fax:  +49 30 217520-12
>>
>> E-Mail: michael.bouschen@akquinet.de
>> Web: www.akquinet.de <http://www.akquinet.de/>
>>
>> Geschäftsführung: Dr. Torsten Fink, Heinz Wilming
>> Amtsgericht Berlin HRB 86780 • USt.-Id. Nr.: DE 225 964 680
>>
>> [LinkedIn] <https://www.linkedin.com/company/akquinet/> [xing]
>> <https://www.xing.com/companies/akquinetag> [kununu]
>> <https://www.kununu.com/de/akquinet> [Instagram]
>> <https://www.instagram.com/akquinet_/>
>


Re: Minutes: JDO TCK meeting Tuesday October 31 1200 PDT 2000 CET

Posted by Tilmann <ti...@gmx.de>.
Hi Michael,

could you create PR?

That would simplify reviewing the code.

I think I can create a PR if you agree?

Best,
Til


On 02/11/2023 20:28, Michael Bouschen wrote:
> Hi,
>> 1. JDO-830: "tck: Migrate JUnit tests to version 5"https://issues.apache.org/jira/browse/JDO-830
>>
>> Currently using JUnit 5.9.3. But it no longer works subclassing the ConsoleLauncher because now with JUnit 5.10.0. the execute method no longer returns the number of tests, errors, failures, etc. So we will need to look into where the information is stored so we can maintain compatibility with how it works today.
>>
>> See the branch at:https://github.com/apache/db-jdo/tree/JDO-830
>>
>> ...
>
> Update: JUnit provides an Interface TestExecutionListener and an
> implementing class SummaryGeneratingListener that calculates the
> number of tests, succeeds, failures etc.
> I could add a subclass of SummaryGeneratingListener that prints the
> test result in the file TCK-results.txt. This class is activated
> through a service provider interface, so I added a file
> org.junit.platform.launcher.TestExecutionListener under
> META-INF/services including the name of the subclass
> TCKSummaryGeneratingListener. I think this is the intended way to
> handle the test execution result.
>
> You find the update in the branch
> https://github.com/apache/db-jdo/tree/JDO-830.
>
> Regards
> Michael
>
> --
> Michael Bouschen
> akquinet tech@spree GmbH
> Bülowstraße 66 • D-10783 Berlin
> Tel:   +49 30 235520-0
> Fax:  +49 30 217520-12
>
> E-Mail: michael.bouschen@akquinet.de
> Web: www.akquinet.de <http://www.akquinet.de/>
>
> Geschäftsführung: Dr. Torsten Fink, Heinz Wilming
> Amtsgericht Berlin HRB 86780 • USt.-Id. Nr.: DE 225 964 680
>
> [LinkedIn] <https://www.linkedin.com/company/akquinet/> [xing]
> <https://www.xing.com/companies/akquinetag> [kununu]
> <https://www.kununu.com/de/akquinet> [Instagram]
> <https://www.instagram.com/akquinet_/>

Re: Minutes: JDO TCK meeting Tuesday October 31 1200 PDT 2000 CET

Posted by Michael Bouschen <mi...@akquinet.de.INVALID>.
Hi,
> 1. JDO-830: "tck: Migrate JUnit tests to version 5"https://issues.apache.org/jira/browse/JDO-830
>
> Currently using JUnit 5.9.3. But it no longer works subclassing the ConsoleLauncher because now with JUnit 5.10.0. the execute method no longer returns the number of tests, errors, failures, etc. So we will need to look into where the information is stored so we can maintain compatibility with how it works today.
>
> See the branch at:https://github.com/apache/db-jdo/tree/JDO-830
>
> ...

Update: JUnit provides an Interface TestExecutionListener and an 
implementing class SummaryGeneratingListener that calculates the number 
of tests, succeeds, failures etc.
I could add a subclass of SummaryGeneratingListener that prints the test 
result in the file TCK-results.txt. This class is activated through a 
service provider interface, so I added a file 
org.junit.platform.launcher.TestExecutionListener under 
META-INF/services including the name of the subclass 
TCKSummaryGeneratingListener. I think this is the intended way to handle 
the test execution result.

You find the update in the branch 
https://github.com/apache/db-jdo/tree/JDO-830.

Regards
Michael

-- 
Michael Bouschen
akquinet tech@spree GmbH
Bülowstraße 66 • D-10783 Berlin
Tel:   +49 30 235520-0
Fax:  +49 30 217520-12

E-Mail: michael.bouschen@akquinet.de
Web: www.akquinet.de <http://www.akquinet.de/>

Geschäftsführung: Dr. Torsten Fink, Heinz Wilming
Amtsgericht Berlin HRB 86780 • USt.-Id. Nr.: DE 225 964 680

[LinkedIn] <https://www.linkedin.com/company/akquinet/> [xing] 
<https://www.xing.com/companies/akquinetag> [kununu] 
<https://www.kununu.com/de/akquinet> [Instagram] 
<https://www.instagram.com/akquinet_/>

Minutes: JDO TCK meeting Tuesday October 31 1200 PDT 2000 CET

Posted by Craig Russell <ap...@gmail.com>.
Attendees: Michael Bouschen, Tilmann Zäschke, Craig Russell

Next meeting: Tuesday November 7 1100 PST 2000 CET

Agenda:

1. JDO-830: "tck: Migrate JUnit tests to version 5" https://issues.apache.org/jira/browse/JDO-830

Currently using JUnit 5.9.3. But it no longer works subclassing the ConsoleLauncher because now with JUnit 5.10.0. the execute method no longer returns the number of tests, errors, failures, etc. So we will need to look into where the information is stored so we can maintain compatibility with how it works today.

See the branch at: https://github.com/apache/db-jdo/tree/JDO-830

2. JIRA JDO-831: "tck: improve tck tests for performance" https://issues.apache.org/jira/browse/JDO-831

Waiting for JDO-830

3. sonarcloud issues

JIRA JDO-819 "Code quality analysis" https://issues.apache.org/jira/browse/JDO-819
JIRA JDO-823 "Fix sonarcloud issues of type Code Smells" https://issues.apache.org/jira/browse/JDO-823

Sonarcloud link:https://sonarcloud.io/summary/overall?id=db-jdo

* Cognitive Complexity of methods should not be too high:
https://sonarcloud.io/project/issues?resolved=false&rules=java%3AS3776&severities=CRITICAL&types=CODE_SMELL&id=db-jdo 

* Raw types should not be used:
https://sonarcloud.io/project/issues?resolved=false&rules=java%3AS3740&severities=MAJOR&id=db-jdo 


4. JIRA JDO-822: "Verify compatibility with JDK 21" https://issues.apache.org/jira/browse/JDO-822
We compile with target JDK8. This now works with JDK21 as the compiler.
This JIRA can be resolved. Will close when we release 3.2.2. 
Done.

5. JIRA JDO-812 "Move to JDK 11 as the lowest supported version" https://issues.apache.org/jira/browse/JDO-812

6. Other issues

Action Items from weeks past:
[Jul 13 2023] AI All Open a new JIRA for Android since having JNDI in the API disallows use with Android
[Jun 08 2023] AI All make a JIRA: JDO support for Java Recordshttps://openjdk.org/jeps/395
[May 24 2023] AI Tobias add JDK 20 to the build request for GitHub for testing.
[Dec 09 2021] AI Craig: Try to contact all current/former participants in JDO development and see if and how they want to be recognized on the JDO and DB web sites.https://db.apache.org/whoweare.html
[Oct 07 2021] AI Craig send a private message to all JSR-243 Expert Group members asking if they wish to continue.
[Mar 25 2021] AI Craig: investigate "merging" papajdo and apache.clr accounts
[Oct 17 2014] AI Matthew any updates for "Modify specification to address NoSQL datastores "https://issues.apache.org/jira/browse/JDO-651


Craig L Russell
clr@apache.org