[GitHub] [hive] zabetak commented on pull request #3894: HIVE-26887 Make sure dirPath has the correct permissions

["zabetak (via GitHub)" <gi...@apache.org>]

zabetak commented on PR #3894:
URL: https://github.com/apache/hive/pull/3894#issuecomment-1420640941

   @skysiders  Apologies for not following up on this but I am still pretty busy with various things.
   
   > Regarding the second point "programming pattern" you mentioned, in fact, it is also possible to use Hadoop's underlying FileSystem.create(fs, path, perm) here.
   
   If this pattern is preferred then why not adopting it here? I saw your comments above about a potential perf benefit. If that is true then it would be better to propose this perf improvement in the "Hadoop HDFS" project. It would be better to have this `if` block (or whatever) in one place rather in many different places (5 times X 5 projects).
   
   Other than that I don't really like the fact that `FileSystem.create` and `fs.create` have different behavior; this will always be a problem for developers when trying to pick which API to use. Again this is not something to handle here but maybe discuss with the HDFS folks.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org