You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by se...@apache.org on 2015/08/21 17:18:47 UTC

svn commit: r1697008 - /commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/util/CodeHTML.java

Author: sebb
Date: Fri Aug 21 15:18:46 2015
New Revision: 1697008

URL: http://svn.apache.org/r1697008
Log:
FindBugs: don't use System.exit

Modified:
    commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/util/CodeHTML.java

Modified: commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/util/CodeHTML.java
URL: http://svn.apache.org/viewvc/commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/util/CodeHTML.java?rev=1697008&r1=1697007&r2=1697008&view=diff
==============================================================================
--- commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/util/CodeHTML.java (original)
+++ commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6/util/CodeHTML.java Fri Aug 21 15:18:46 2015
@@ -367,8 +367,8 @@ final class CodeHTML {
                                 buf.append(bytes.readInt());
                                 break;
                             default: // Never reached
-                                System.err.println("Unreachable default case reached!");
-                                System.exit(-1);
+                                throw new IllegalStateException(
+                                    "Unreachable default case reached! "+Constants.TYPE_OF_OPERANDS[opcode][i]);
                         }
                         buf.append(" ");
                     }