You are viewing a plain text version of this content. The canonical link for it is here.
Posted to log4net-dev@logging.apache.org by ni...@apache.org on 2004/06/07 03:03:50 UTC

cvs commit: logging-log4net/src/ObjectRenderer RendererMap.cs

nicko       2004/06/06 18:03:50

  Modified:    src/ObjectRenderer RendererMap.cs
  Log:
  Cleaned up catch blocks
  
  Revision  Changes    Path
  1.3       +14 -3     logging-log4net/src/ObjectRenderer/RendererMap.cs
  
  Index: RendererMap.cs
  ===================================================================
  RCS file: /home/cvs/logging-log4net/src/ObjectRenderer/RendererMap.cs,v
  retrieving revision 1.2
  retrieving revision 1.3
  diff -u -r1.2 -r1.3
  --- RendererMap.cs	16 Feb 2004 02:10:54 -0000	1.2
  +++ RendererMap.cs	7 Jun 2004 01:03:50 -0000	1.3
  @@ -77,16 +77,27 @@
   					log4net.Util.LogLog.Error("RendererMap: Exception while rendering object of type ["+obj.GetType().FullName+"]", ex);
   
   					// return default message
  -					writer.Write("<log4net.Error>Exception rendering object type ["+obj.GetType().FullName+"]");
  +					string objectTypeName = "";
  +					if (obj != null && obj.GetType() != null)
  +					{
  +						objectTypeName = obj.GetType().FullName;
  +					}
  +
  +					writer.Write("<log4net.Error>Exception rendering object type ["+objectTypeName+"]");
   					if (ex != null)
   					{
  +						string exceptionText = null;
  +
   						try
   						{
  -							writer.Write("<stackTrace>" + ex.ToString() + "</stackTrace>");
  +							exceptionText = ex.ToString();
   						}
  -						catch(Exception)
  +						catch
   						{
  +							// Ignore exception
   						}
  +
  +						writer.Write("<stackTrace>" + exceptionText + "</stackTrace>");
   					}
   					writer.Write("</log4net.Error>");
   				}