[GitHub] [mynewt-newt] ccollins476ad commented on a change in pull request #418: Add Section TLV support to images

[GitBox <gi...@apache.org>]

ccollins476ad commented on a change in pull request #418:
URL: https://github.com/apache/mynewt-newt/pull/418#discussion_r511481331



##########
File path: newt/imgprod/imgprod.go
##########
@@ -312,10 +318,55 @@ func OptsFromTgtBldr(b *builder.TargetBuilder, ver image.ImageVersion,
 
 func ProduceAll(t *builder.TargetBuilder, ver image.ImageVersion,
 	sigKeys []sec.PrivSignKey, encKeyFilename string, encKeyIndex int,
-	hdrPad int, imagePad int) error {
+	hdrPad int, imagePad int, sectionString string) error {
+
+        elfPath := t.AppBuilder.AppElfPath()
+
+        cmdName := "arm-none-eabi-objdump"

Review comment:
       This seems like something that should be specified in the compiler package.
   
   I see newt does this same thing in the `size` command, so I can't fault you for doing it here.  Maybe a future improvement to consider later.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org