You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Scott Chen (Created) (JIRA)" <ji...@apache.org> on 2012/03/02 04:49:02 UTC
[jira] [Created] (HBASE-5506) Add unit test for
ThriftServerRunner.HbaseHandler.getRegionInfo()
Add unit test for ThriftServerRunner.HbaseHandler.getRegionInfo()
-----------------------------------------------------------------
Key: HBASE-5506
URL: https://issues.apache.org/jira/browse/HBASE-5506
Project: HBase
Issue Type: Test
Reporter: Scott Chen
Assignee: Scott Chen
Priority: Minor
Attachments: HBASE-5506.D2031.1.patch
We observed that when with "framed transport" option.
The thrift call ThriftServerRunner.HbaseHandler.getRegionInfo() receives corrupted parameter (some garbage string attached to the beginning).
This may be a thrift bug requires further investigation.
Adding a unit test to reproduce the problem.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5506) Add unit test for
ThriftServerRunner.HbaseHandler.getRegionInfo()
Posted by "Phabricator (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13220700#comment-13220700 ]
Phabricator commented on HBASE-5506:
------------------------------------
stack has commented on the revision "HBASE-5506 [jira] Add unit test for ThriftServerRunner.HbaseHandler.getRegionInfo()".
Scott does your new test fail? (If it doesn't its probably not of much use?)
REVISION DETAIL
https://reviews.facebook.net/D2031
BRANCH
test-getregioninfo
> Add unit test for ThriftServerRunner.HbaseHandler.getRegionInfo()
> -----------------------------------------------------------------
>
> Key: HBASE-5506
> URL: https://issues.apache.org/jira/browse/HBASE-5506
> Project: HBase
> Issue Type: Test
> Reporter: Scott Chen
> Assignee: Scott Chen
> Priority: Minor
> Attachments: HBASE-5506.D2031.1.patch, HBASE-5506.D2031.2.patch, HBASE-5506.D2031.3.patch
>
>
> We observed that when with "framed transport" option.
> The thrift call ThriftServerRunner.HbaseHandler.getRegionInfo() receives corrupted parameter (some garbage string attached to the beginning).
> This may be a thrift bug requires further investigation.
> Add a unit test to reproduce the problem.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5506) Add unit test for
ThriftServerRunner.HbaseHandler.getRegionInfo()
Posted by "Scott Chen (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13221150#comment-13221150 ]
Scott Chen commented on HBASE-5506:
-----------------------------------
Ted:
Yes, that's the bug.
The parameter should be
{code}
tableA,rowA,99999999999999\x0
{code}
But we are seeing some string attach to it and this is causing the failure
{code}
\x80\x01\x00\x01\x00\x00\x00\x0DgetRegionInfo\x00\x00\x00\x12\x0B\x00\x01\x00\x00\x00\x1AtableA,rowA,99999999999999\x0
{code}
Thanks for the review Ted, Stack and Dhruba!
> Add unit test for ThriftServerRunner.HbaseHandler.getRegionInfo()
> -----------------------------------------------------------------
>
> Key: HBASE-5506
> URL: https://issues.apache.org/jira/browse/HBASE-5506
> Project: HBase
> Issue Type: Test
> Reporter: Scott Chen
> Assignee: Scott Chen
> Priority: Minor
> Fix For: 0.96.0
>
> Attachments: HBASE-5506.D2031.1.patch, HBASE-5506.D2031.2.patch, HBASE-5506.D2031.3.patch
>
>
> We observed that when with "framed transport" option.
> The thrift call ThriftServerRunner.HbaseHandler.getRegionInfo() receives corrupted parameter (some garbage string attached to the beginning).
> This may be a thrift bug requires further investigation.
> Add a unit test to reproduce the problem.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5506) Add unit test for
ThriftServerRunner.HbaseHandler.getRegionInfo()
Posted by "Zhihong Yu (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5506?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Zhihong Yu updated HBASE-5506:
------------------------------
Fix Version/s: 0.96.0
Integrated to TRUNK.
Thanks for the patch, Scott.
Thanks for the review Stack and Dhruba.
> Add unit test for ThriftServerRunner.HbaseHandler.getRegionInfo()
> -----------------------------------------------------------------
>
> Key: HBASE-5506
> URL: https://issues.apache.org/jira/browse/HBASE-5506
> Project: HBase
> Issue Type: Test
> Reporter: Scott Chen
> Assignee: Scott Chen
> Priority: Minor
> Fix For: 0.96.0
>
> Attachments: HBASE-5506.D2031.1.patch, HBASE-5506.D2031.2.patch, HBASE-5506.D2031.3.patch
>
>
> We observed that when with "framed transport" option.
> The thrift call ThriftServerRunner.HbaseHandler.getRegionInfo() receives corrupted parameter (some garbage string attached to the beginning).
> This may be a thrift bug requires further investigation.
> Add a unit test to reproduce the problem.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5506) Add unit test for
ThriftServerRunner.HbaseHandler.getRegionInfo()
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13222866#comment-13222866 ]
Hudson commented on HBASE-5506:
-------------------------------
Integrated in HBase-TRUNK #2672 (See [https://builds.apache.org/job/HBase-TRUNK/2672/])
HBASE-5506 Add unit test for ThriftServerRunner.HbaseHandler.getRegionInfo() (Scott Chen) (Revision 1296365)
Result = SUCCESS
tedyu :
Files :
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/thrift/ThriftServerRunner.java
* /hbase/trunk/src/test/java/org/apache/hadoop/hbase/thrift/TestThriftServer.java
* /hbase/trunk/src/test/java/org/apache/hadoop/hbase/thrift/TestThriftServerCmdLine.java
> Add unit test for ThriftServerRunner.HbaseHandler.getRegionInfo()
> -----------------------------------------------------------------
>
> Key: HBASE-5506
> URL: https://issues.apache.org/jira/browse/HBASE-5506
> Project: HBase
> Issue Type: Test
> Reporter: Scott Chen
> Assignee: Scott Chen
> Priority: Minor
> Fix For: 0.96.0
>
> Attachments: HBASE-5506.D2031.1.patch, HBASE-5506.D2031.2.patch, HBASE-5506.D2031.3.patch
>
>
> We observed that when with "framed transport" option.
> The thrift call ThriftServerRunner.HbaseHandler.getRegionInfo() receives corrupted parameter (some garbage string attached to the beginning).
> This may be a thrift bug requires further investigation.
> Add a unit test to reproduce the problem.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5506) Add unit test for
ThriftServerRunner.HbaseHandler.getRegionInfo()
Posted by "Phabricator (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13220668#comment-13220668 ]
Phabricator commented on HBASE-5506:
------------------------------------
tedyu has commented on the revision "HBASE-5506 [jira] Add unit test for ThriftServerRunner.HbaseHandler.getRegionInfo()".
+1 if tests pass on Hadoop QA
REVISION DETAIL
https://reviews.facebook.net/D2031
> Add unit test for ThriftServerRunner.HbaseHandler.getRegionInfo()
> -----------------------------------------------------------------
>
> Key: HBASE-5506
> URL: https://issues.apache.org/jira/browse/HBASE-5506
> Project: HBase
> Issue Type: Test
> Reporter: Scott Chen
> Assignee: Scott Chen
> Priority: Minor
> Attachments: HBASE-5506.D2031.1.patch, HBASE-5506.D2031.2.patch
>
>
> We observed that when with "framed transport" option.
> The thrift call ThriftServerRunner.HbaseHandler.getRegionInfo() receives corrupted parameter (some garbage string attached to the beginning).
> This may be a thrift bug requires further investigation.
> Add a unit test to reproduce the problem.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5506) Add unit test for
ThriftServerRunner.HbaseHandler.getRegionInfo()
Posted by "Hadoop QA (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13220761#comment-13220761 ]
Hadoop QA commented on HBASE-5506:
----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12516791/HBASE-5506.D2031.3.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 6 new or modified tests.
-1 javadoc. The javadoc tool appears to have generated -129 warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
-1 findbugs. The patch appears to introduce 155 new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
-1 core tests. The patch failed these unit tests:
org.apache.hadoop.hbase.mapreduce.TestImportTsv
org.apache.hadoop.hbase.mapred.TestTableMapReduce
org.apache.hadoop.hbase.mapreduce.TestHFileOutputFormat
Test results: https://builds.apache.org/job/PreCommit-HBASE-Build/1078//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HBASE-Build/1078//artifact/trunk/patchprocess/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-HBASE-Build/1078//console
This message is automatically generated.
> Add unit test for ThriftServerRunner.HbaseHandler.getRegionInfo()
> -----------------------------------------------------------------
>
> Key: HBASE-5506
> URL: https://issues.apache.org/jira/browse/HBASE-5506
> Project: HBase
> Issue Type: Test
> Reporter: Scott Chen
> Assignee: Scott Chen
> Priority: Minor
> Attachments: HBASE-5506.D2031.1.patch, HBASE-5506.D2031.2.patch, HBASE-5506.D2031.3.patch
>
>
> We observed that when with "framed transport" option.
> The thrift call ThriftServerRunner.HbaseHandler.getRegionInfo() receives corrupted parameter (some garbage string attached to the beginning).
> This may be a thrift bug requires further investigation.
> Add a unit test to reproduce the problem.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5506) Add unit test for
ThriftServerRunner.HbaseHandler.getRegionInfo()
Posted by "Phabricator (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5506?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Phabricator updated HBASE-5506:
-------------------------------
Attachment: HBASE-5506.D2031.2.patch
sc updated the revision "HBASE-5506 [jira] Add unit test for ThriftServerRunner.HbaseHandler.getRegionInfo()".
Reviewers: tedyu, dhruba, JIRA
Addressed Ted's review comments, thanks.
REVISION DETAIL
https://reviews.facebook.net/D2031
AFFECTED FILES
src/main/java/org/apache/hadoop/hbase/thrift/ThriftServerRunner.java
src/test/java/org/apache/hadoop/hbase/thrift/TestThriftServer.java
src/test/java/org/apache/hadoop/hbase/thrift/TestThriftServerCmdLine.java
> Add unit test for ThriftServerRunner.HbaseHandler.getRegionInfo()
> -----------------------------------------------------------------
>
> Key: HBASE-5506
> URL: https://issues.apache.org/jira/browse/HBASE-5506
> Project: HBase
> Issue Type: Test
> Reporter: Scott Chen
> Assignee: Scott Chen
> Priority: Minor
> Attachments: HBASE-5506.D2031.1.patch, HBASE-5506.D2031.2.patch
>
>
> We observed that when with "framed transport" option.
> The thrift call ThriftServerRunner.HbaseHandler.getRegionInfo() receives corrupted parameter (some garbage string attached to the beginning).
> This may be a thrift bug requires further investigation.
> Add a unit test to reproduce the problem.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5506) Add unit test for
ThriftServerRunner.HbaseHandler.getRegionInfo()
Posted by "Phabricator (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13220660#comment-13220660 ]
Phabricator commented on HBASE-5506:
------------------------------------
tedyu has commented on the revision "HBASE-5506 [jira] Add unit test for ThriftServerRunner.HbaseHandler.getRegionInfo()".
INLINE COMMENTS
src/test/java/org/apache/hadoop/hbase/thrift/TestThriftServerCmdLine.java:93 The second specifyFramed should be specifyCompact
REVISION DETAIL
https://reviews.facebook.net/D2031
> Add unit test for ThriftServerRunner.HbaseHandler.getRegionInfo()
> -----------------------------------------------------------------
>
> Key: HBASE-5506
> URL: https://issues.apache.org/jira/browse/HBASE-5506
> Project: HBase
> Issue Type: Test
> Reporter: Scott Chen
> Assignee: Scott Chen
> Priority: Minor
> Attachments: HBASE-5506.D2031.1.patch
>
>
> We observed that when with "framed transport" option.
> The thrift call ThriftServerRunner.HbaseHandler.getRegionInfo() receives corrupted parameter (some garbage string attached to the beginning).
> This may be a thrift bug requires further investigation.
> Add a unit test to reproduce the problem.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5506) Add unit test for
ThriftServerRunner.HbaseHandler.getRegionInfo()
Posted by "Phabricator (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5506?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Phabricator updated HBASE-5506:
-------------------------------
Attachment: HBASE-5506.D2031.1.patch
sc requested code review of "HBASE-5506 [jira] Add unit test for ThriftServerRunner.HbaseHandler.getRegionInfo()".
Reviewers: tedyu, dhruba, JIRA
Add getRegionInfo test to TestThriftServer
Task ID: #
Blame Rev:
We observed that when with "framed transport" option.
The thrift call ThriftServerRunner.HbaseHandler.getRegionInfo() receives corrupted parameter (some garbage string attached to the beginning).
This may be a thrift bug requires further investigation.
Add a unit test to reproduce the problem.
TEST PLAN
Run the test
Revert Plan:
Tags:
REVISION DETAIL
https://reviews.facebook.net/D2031
AFFECTED FILES
src/main/java/org/apache/hadoop/hbase/thrift/ThriftServerRunner.java
src/test/java/org/apache/hadoop/hbase/thrift/TestThriftServer.java
src/test/java/org/apache/hadoop/hbase/thrift/TestThriftServerCmdLine.java
MANAGE HERALD DIFFERENTIAL RULES
https://reviews.facebook.net/herald/view/differential/
WHY DID I GET THIS EMAIL?
https://reviews.facebook.net/herald/transcript/4359/
Tip: use the X-Herald-Rules header to filter Herald messages in your client.
> Add unit test for ThriftServerRunner.HbaseHandler.getRegionInfo()
> -----------------------------------------------------------------
>
> Key: HBASE-5506
> URL: https://issues.apache.org/jira/browse/HBASE-5506
> Project: HBase
> Issue Type: Test
> Reporter: Scott Chen
> Assignee: Scott Chen
> Priority: Minor
> Attachments: HBASE-5506.D2031.1.patch
>
>
> We observed that when with "framed transport" option.
> The thrift call ThriftServerRunner.HbaseHandler.getRegionInfo() receives corrupted parameter (some garbage string attached to the beginning).
> This may be a thrift bug requires further investigation.
> Add a unit test to reproduce the problem.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5506) Add unit test for
ThriftServerRunner.HbaseHandler.getRegionInfo()
Posted by "Phabricator (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13220687#comment-13220687 ]
Phabricator commented on HBASE-5506:
------------------------------------
dhruba has accepted the revision "HBASE-5506 [jira] Add unit test for ThriftServerRunner.HbaseHandler.getRegionInfo()".
REVISION DETAIL
https://reviews.facebook.net/D2031
BRANCH
test-getregioninfo
> Add unit test for ThriftServerRunner.HbaseHandler.getRegionInfo()
> -----------------------------------------------------------------
>
> Key: HBASE-5506
> URL: https://issues.apache.org/jira/browse/HBASE-5506
> Project: HBase
> Issue Type: Test
> Reporter: Scott Chen
> Assignee: Scott Chen
> Priority: Minor
> Attachments: HBASE-5506.D2031.1.patch, HBASE-5506.D2031.2.patch
>
>
> We observed that when with "framed transport" option.
> The thrift call ThriftServerRunner.HbaseHandler.getRegionInfo() receives corrupted parameter (some garbage string attached to the beginning).
> This may be a thrift bug requires further investigation.
> Add a unit test to reproduce the problem.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5506) Add unit test for
ThriftServerRunner.HbaseHandler.getRegionInfo()
Posted by "Zhihong Yu (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5506?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Zhihong Yu updated HBASE-5506:
------------------------------
Hadoop Flags: Reviewed
Status: Patch Available (was: Open)
> Add unit test for ThriftServerRunner.HbaseHandler.getRegionInfo()
> -----------------------------------------------------------------
>
> Key: HBASE-5506
> URL: https://issues.apache.org/jira/browse/HBASE-5506
> Project: HBase
> Issue Type: Test
> Reporter: Scott Chen
> Assignee: Scott Chen
> Priority: Minor
> Attachments: HBASE-5506.D2031.1.patch, HBASE-5506.D2031.2.patch, HBASE-5506.D2031.3.patch
>
>
> We observed that when with "framed transport" option.
> The thrift call ThriftServerRunner.HbaseHandler.getRegionInfo() receives corrupted parameter (some garbage string attached to the beginning).
> This may be a thrift bug requires further investigation.
> Add a unit test to reproduce the problem.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5506) Add unit test for
ThriftServerRunner.HbaseHandler.getRegionInfo()
Posted by "Zhihong Yu (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13221077#comment-13221077 ]
Zhihong Yu commented on HBASE-5506:
-----------------------------------
If I comment out the exclusion Scott added, I see the following test failure:
{code}
Tests in error:
testRunThriftServer[0](org.apache.hadoop.hbase.thrift.TestThriftServerCmdLine): IOError(message:Cannot find row in .META., row=\x80\x01\x00\x01\x00\x00\x00\x0DgetRegionInfo\x00\x00\x00\x12\x0B\x00\x01\x00\x00\x00\x1AtableA,rowA,99999999999999\x00)
testRunThriftServer[2](org.apache.hadoop.hbase.thrift.TestThriftServerCmdLine): IOError(message:Cannot find row in .META., row=\x80\x01\x00\x01\x00\x00\x00\x0DgetRegionInfo\x00\x00\x00\x12\x0B\x00\x01\x00\x00\x00\x1AtableA,rowA,99999999999999\x00)
testRunThriftServer[4](org.apache.hadoop.hbase.thrift.TestThriftServerCmdLine): IOError(message:Cannot find row in .META., row=\x80\x01\x00\x01\x00\x00\x00\x0DgetRegionInfo\x00\x00\x00\x12\x0B\x00\x01\x00\x00\x00\x1AtableA,rowA,99999999999999\x00)
testRunThriftServer[6](org.apache.hadoop.hbase.thrift.TestThriftServerCmdLine): IOError(message:Cannot find row in .META., row=\x80\x01\x00\x01\x00\x00\x00\x0DgetRegionInfo\x00\x00\x00\x12\x0B\x00\x01\x00\x00\x00\x1AtableA,rowA,99999999999999\x00)
testRunThriftServer[12](org.apache.hadoop.hbase.thrift.TestThriftServerCmdLine): IOError(message:Cannot find row in .META., row=\x80\x01\x00\x01\x00\x00\x00\x0DgetRegionInfo\x00\x00\x00\x12\x0B\x00\x01\x00\x00\x00\x1AtableA,rowA,99999999999999\x00)
testRunThriftServer[14](org.apache.hadoop.hbase.thrift.TestThriftServerCmdLine): IOError(message:Cannot find row in .META., row=\x80\x01\x00\x01\x00\x00\x00\x0DgetRegionInfo\x00\x00\x00\x12\x0B\x00\x01\x00\x00\x00\x1AtableA,rowA,99999999999999\x00)
testRunThriftServer[16](org.apache.hadoop.hbase.thrift.TestThriftServerCmdLine): IOError(message:Cannot find row in .META., row=\x80\x01\x00\x01\x00\x00\x00\x0DgetRegionInfo\x00\x00\x00\x12\x0B\x00\x01\x00\x00\x00\x1AtableA,rowA,99999999999999\x00)
testRunThriftServer[18](org.apache.hadoop.hbase.thrift.TestThriftServerCmdLine): IOError(message:Cannot find row in .META., row=\x80\x01\x00\x01\x00\x00\x00\x0DgetRegionInfo\x00\x00\x00\x12\x0B\x00\x01\x00\x00\x00\x1AtableA,rowA,99999999999999\x00)
{code}
With the exclusion condition, the test passed:
{code}
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 4:21.622s
{code}
I will integrate patch v3 later today if there is no objection.
> Add unit test for ThriftServerRunner.HbaseHandler.getRegionInfo()
> -----------------------------------------------------------------
>
> Key: HBASE-5506
> URL: https://issues.apache.org/jira/browse/HBASE-5506
> Project: HBase
> Issue Type: Test
> Reporter: Scott Chen
> Assignee: Scott Chen
> Priority: Minor
> Attachments: HBASE-5506.D2031.1.patch, HBASE-5506.D2031.2.patch, HBASE-5506.D2031.3.patch
>
>
> We observed that when with "framed transport" option.
> The thrift call ThriftServerRunner.HbaseHandler.getRegionInfo() receives corrupted parameter (some garbage string attached to the beginning).
> This may be a thrift bug requires further investigation.
> Add a unit test to reproduce the problem.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5506) Add unit test for
ThriftServerRunner.HbaseHandler.getRegionInfo()
Posted by "Phabricator (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5506?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Phabricator updated HBASE-5506:
-------------------------------
Attachment: HBASE-5506.D2031.3.patch
sc updated the revision "HBASE-5506 [jira] Add unit test for ThriftServerRunner.HbaseHandler.getRegionInfo()".
Reviewers: tedyu, dhruba, JIRA
Uncomment a line of code that I commented during test. Sorry for the mistake.
REVISION DETAIL
https://reviews.facebook.net/D2031
AFFECTED FILES
src/main/java/org/apache/hadoop/hbase/thrift/ThriftServerRunner.java
src/test/java/org/apache/hadoop/hbase/thrift/TestThriftServer.java
src/test/java/org/apache/hadoop/hbase/thrift/TestThriftServerCmdLine.java
> Add unit test for ThriftServerRunner.HbaseHandler.getRegionInfo()
> -----------------------------------------------------------------
>
> Key: HBASE-5506
> URL: https://issues.apache.org/jira/browse/HBASE-5506
> Project: HBase
> Issue Type: Test
> Reporter: Scott Chen
> Assignee: Scott Chen
> Priority: Minor
> Attachments: HBASE-5506.D2031.1.patch, HBASE-5506.D2031.2.patch, HBASE-5506.D2031.3.patch
>
>
> We observed that when with "framed transport" option.
> The thrift call ThriftServerRunner.HbaseHandler.getRegionInfo() receives corrupted parameter (some garbage string attached to the beginning).
> This may be a thrift bug requires further investigation.
> Add a unit test to reproduce the problem.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5506) Add unit test for
ThriftServerRunner.HbaseHandler.getRegionInfo()
Posted by "Phabricator (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13220729#comment-13220729 ]
Phabricator commented on HBASE-5506:
------------------------------------
sc has commented on the revision "HBASE-5506 [jira] Add unit test for ThriftServerRunner.HbaseHandler.getRegionInfo()".
@stack: I add some exclude conditions to make the test pass (see the inline comments). If we remove those the test will fail. Is this the right way to do? What do you think?
INLINE COMMENTS
src/test/java/org/apache/hadoop/hbase/thrift/TestThriftServerCmdLine.java:95 if we comment this, the test will fail.
REVISION DETAIL
https://reviews.facebook.net/D2031
BRANCH
test-getregioninfo
> Add unit test for ThriftServerRunner.HbaseHandler.getRegionInfo()
> -----------------------------------------------------------------
>
> Key: HBASE-5506
> URL: https://issues.apache.org/jira/browse/HBASE-5506
> Project: HBase
> Issue Type: Test
> Reporter: Scott Chen
> Assignee: Scott Chen
> Priority: Minor
> Attachments: HBASE-5506.D2031.1.patch, HBASE-5506.D2031.2.patch, HBASE-5506.D2031.3.patch
>
>
> We observed that when with "framed transport" option.
> The thrift call ThriftServerRunner.HbaseHandler.getRegionInfo() receives corrupted parameter (some garbage string attached to the beginning).
> This may be a thrift bug requires further investigation.
> Add a unit test to reproduce the problem.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5506) Add unit test for
ThriftServerRunner.HbaseHandler.getRegionInfo()
Posted by "Scott Chen (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5506?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Scott Chen updated HBASE-5506:
------------------------------
Description:
We observed that when with "framed transport" option.
The thrift call ThriftServerRunner.HbaseHandler.getRegionInfo() receives corrupted parameter (some garbage string attached to the beginning).
This may be a thrift bug requires further investigation.
Add a unit test to reproduce the problem.
was:
We observed that when with "framed transport" option.
The thrift call ThriftServerRunner.HbaseHandler.getRegionInfo() receives corrupted parameter (some garbage string attached to the beginning).
This may be a thrift bug requires further investigation.
Adding a unit test to reproduce the problem.
> Add unit test for ThriftServerRunner.HbaseHandler.getRegionInfo()
> -----------------------------------------------------------------
>
> Key: HBASE-5506
> URL: https://issues.apache.org/jira/browse/HBASE-5506
> Project: HBase
> Issue Type: Test
> Reporter: Scott Chen
> Assignee: Scott Chen
> Priority: Minor
> Attachments: HBASE-5506.D2031.1.patch
>
>
> We observed that when with "framed transport" option.
> The thrift call ThriftServerRunner.HbaseHandler.getRegionInfo() receives corrupted parameter (some garbage string attached to the beginning).
> This may be a thrift bug requires further investigation.
> Add a unit test to reproduce the problem.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5506) Add unit test for
ThriftServerRunner.HbaseHandler.getRegionInfo()
Posted by "Phabricator (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13220664#comment-13220664 ]
Phabricator commented on HBASE-5506:
------------------------------------
sc has commented on the revision "HBASE-5506 [jira] Add unit test for ThriftServerRunner.HbaseHandler.getRegionInfo()".
@dhruba: I created https://issues.apache.org/jira/browse/HBASE-5507 for this.
REVISION DETAIL
https://reviews.facebook.net/D2031
> Add unit test for ThriftServerRunner.HbaseHandler.getRegionInfo()
> -----------------------------------------------------------------
>
> Key: HBASE-5506
> URL: https://issues.apache.org/jira/browse/HBASE-5506
> Project: HBase
> Issue Type: Test
> Reporter: Scott Chen
> Assignee: Scott Chen
> Priority: Minor
> Attachments: HBASE-5506.D2031.1.patch, HBASE-5506.D2031.2.patch
>
>
> We observed that when with "framed transport" option.
> The thrift call ThriftServerRunner.HbaseHandler.getRegionInfo() receives corrupted parameter (some garbage string attached to the beginning).
> This may be a thrift bug requires further investigation.
> Add a unit test to reproduce the problem.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5506) Add unit test for
ThriftServerRunner.HbaseHandler.getRegionInfo()
Posted by "Phabricator (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13272656#comment-13272656 ]
Phabricator commented on HBASE-5506:
------------------------------------
sc has closed the revision "HBASE-5506 [jira] Add unit test for ThriftServerRunner.HbaseHandler.getRegionInfo()".
REVISION DETAIL
https://reviews.facebook.net/D2031
To: tedyu, dhruba, JIRA, sc
Cc: stack
> Add unit test for ThriftServerRunner.HbaseHandler.getRegionInfo()
> -----------------------------------------------------------------
>
> Key: HBASE-5506
> URL: https://issues.apache.org/jira/browse/HBASE-5506
> Project: HBase
> Issue Type: Test
> Reporter: Scott Chen
> Assignee: Scott Chen
> Priority: Minor
> Fix For: 0.96.0
>
> Attachments: HBASE-5506.D2031.1.patch, HBASE-5506.D2031.2.patch, HBASE-5506.D2031.3.patch
>
>
> We observed that when with "framed transport" option.
> The thrift call ThriftServerRunner.HbaseHandler.getRegionInfo() receives corrupted parameter (some garbage string attached to the beginning).
> This may be a thrift bug requires further investigation.
> Add a unit test to reproduce the problem.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (HBASE-5506) Add unit test for
ThriftServerRunner.HbaseHandler.getRegionInfo()
Posted by "Phabricator (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5506?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13220655#comment-13220655 ]
Phabricator commented on HBASE-5506:
------------------------------------
dhruba has commented on the revision "HBASE-5506 [jira] Add unit test for ThriftServerRunner.HbaseHandler.getRegionInfo()".
INLINE COMMENTS
src/test/java/org/apache/hadoop/hbase/thrift/TestThriftServerCmdLine.java:92 maybe create a separate jira to address this TODO item?
REVISION DETAIL
https://reviews.facebook.net/D2031
> Add unit test for ThriftServerRunner.HbaseHandler.getRegionInfo()
> -----------------------------------------------------------------
>
> Key: HBASE-5506
> URL: https://issues.apache.org/jira/browse/HBASE-5506
> Project: HBase
> Issue Type: Test
> Reporter: Scott Chen
> Assignee: Scott Chen
> Priority: Minor
> Attachments: HBASE-5506.D2031.1.patch
>
>
> We observed that when with "framed transport" option.
> The thrift call ThriftServerRunner.HbaseHandler.getRegionInfo() receives corrupted parameter (some garbage string attached to the beginning).
> This may be a thrift bug requires further investigation.
> Add a unit test to reproduce the problem.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (HBASE-5506) Add unit test for
ThriftServerRunner.HbaseHandler.getRegionInfo()
Posted by "stack (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HBASE-5506?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
stack updated HBASE-5506:
-------------------------
Resolution: Fixed
Status: Resolved (was: Patch Available)
This was committed a while back.
> Add unit test for ThriftServerRunner.HbaseHandler.getRegionInfo()
> -----------------------------------------------------------------
>
> Key: HBASE-5506
> URL: https://issues.apache.org/jira/browse/HBASE-5506
> Project: HBase
> Issue Type: Test
> Reporter: Scott Chen
> Assignee: Scott Chen
> Priority: Minor
> Fix For: 0.96.0
>
> Attachments: HBASE-5506.D2031.1.patch, HBASE-5506.D2031.2.patch, HBASE-5506.D2031.3.patch
>
>
> We observed that when with "framed transport" option.
> The thrift call ThriftServerRunner.HbaseHandler.getRegionInfo() receives corrupted parameter (some garbage string attached to the beginning).
> This may be a thrift bug requires further investigation.
> Add a unit test to reproduce the problem.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira