[jira] [Commented] (WICKET-5827) Allow to apply multiple Javascript / CSS compressors

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/WICKET-5827?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14357679#comment-14357679 ] 

ASF GitHub Bot commented on WICKET-5827:
----------------------------------------

Github user klopfdreh commented on the pull request:

    https://github.com/apache/wicket/pull/97#issuecomment-78379794
  
    Forgot to close the resource stream. In the  method private CharSequence createBase64EncodedImage(PackageResourceReference imageReference).
    
    May wrap all but the first line into try / finally and close the stream. Sorry for that.



> Allow to apply multiple Javascript / CSS compressors
> ----------------------------------------------------
>
>                 Key: WICKET-5827
>                 URL: https://issues.apache.org/jira/browse/WICKET-5827
>             Project: Wicket
>          Issue Type: New Feature
>          Components: wicket
>    Affects Versions: 6.20.0, 7.0.0-M6
>            Reporter: Tobias Soloschenko
>            Assignee: Martin Grigorov
>            Priority: Minor
>              Labels: features
>             Fix For: 6.20.0, 7.0.0-M6
>
>
> It would be nice to be able to add several css and javascript compressions in a chain. Example for CSS:
> CssRemoveCommentsCompressor > CssUrlReplacementCompressor > CssMinifyCompressor
> The same would be nice for JavaScript files.
> https://github.com/apache/wicket/pull/88
> https://github.com/apache/wicket/pull/87



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)