You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sling.apache.org by Oliver Lietz <ap...@oliverlietz.de> on 2022/07/18 22:03:02 UTC

[VOTE] Release Apache Sling Installer Health Checks 2.1.0

Hi,

We solved 4 issues in this release:
https://issues.apache.org/jira/browse/SLING/fixforversion/12345553

Staging repository:
https://repository.apache.org/content/repositories/orgapachesling-2656

You can use this UNIX script to download the release and verify the 
signatures:
https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD

Usage:
sh check_staged_release.sh 2656 /tmp/sling-staging

Please vote to approve this release:

  [ ] +1 Approve the release
  [ ]  0 Don't care
  [ ] -1 Don't release, because ...

This majority vote is open for at least 72 hours.

Regards,
O.





Re: [VOTE] Release Apache Sling Installer Health Checks 2.1.0

Posted by Eric Norman <en...@apache.org>.
+1

On Mon, Jul 18, 2022 at 3:03 PM Oliver Lietz <ap...@oliverlietz.de> wrote:

> Hi,
>
> We solved 4 issues in this release:
> https://issues.apache.org/jira/browse/SLING/fixforversion/12345553
>
> Staging repository:
> https://repository.apache.org/content/repositories/orgapachesling-2656
>
> You can use this UNIX script to download the release and verify the
> signatures:
>
> https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD
>
> Usage:
> sh check_staged_release.sh 2656 /tmp/sling-staging
>
> Please vote to approve this release:
>
>   [ ] +1 Approve the release
>   [ ]  0 Don't care
>   [ ] -1 Don't release, because ...
>
> This majority vote is open for at least 72 hours.
>
> Regards,
> O.
>
>
>
>
>

Re: [VOTE] Release Apache Sling Installer Health Checks 2.1.0

Posted by Konrad Windszus <kw...@apache.org>.
Hi Oli,
I trust you with this and definitely I checked out that the order in which the methods are called differ here with a modified method. I haven’t checked whether the same object instance is reused or not.

You just need be aware of potential multithreading issues as the component is not stopped while being reconfigured.
I think both variables “configuration” and “skipEntityIdsWithVersions” need to be made volatile which might neglect the performance advantage, as otherwise other threads might not see the updates (similar to what bnd actually checks for dynamic field references).
Compare also with http://docs.osgi.org/specification/osgi.cmpn/8.0.0/service.component.html#service.component-reference.field.option

"For a dynamic reference, the field must be declared with the volatile modifier so that field value changes made by SCR are visible to other threads. If the field is not declared with the volatile modifier, SCR must log an error message with the Log Service, if present, and the field must not be modified.”

Although this is not stated for a modified method I think the same circumstances apply here!

Konrad


> On 28. Jul 2022, at 15:04, Oliver Lietz <ap...@oliverlietz.de> wrote:
> 
> On Wednesday, 20 July 2022 10:41:04 CEST Oliver Lietz wrote:
>> On Tuesday, 19 July 2022 08:27:23 CEST Konrad Windszus wrote:
>>> +1,
>>> 
>>> I don’t think that the changes for
>>> https://issues.apache.org/jira/browse/SLING-11463
>>> <https://issues.apache.org/jira/browse/SLING-11463> were actually
>>> necessary
>>> as a DS component is reactivated if a configuration is changed and doesn’t
>>> have a modified method. Compare with
>>> https://github.com/apache/sling-org-apache-sling-installer-hc/commit/82096
>>> 7
>>> 59de3e5d0b791a1f45c8fe2e759b5ae391#r78840724
>>> <https://github.com/apache/sling-org-apache-sling-installer-hc/commit/8209
>>> 6
>>> 759de3e5d0b791a1f45c8fe2e759b5ae391#r78840724>.
>>> 
>>> IMHO adding a modified just allows to reconfigure while the component is
>>> running which is not necessary here. Konrad
>> 
>> That is not true for Felix at least. The component will not be reactivated
>> but recreated. Felix will create a complete new instance if modified is
>> missing which causes unnecessary fluctuation.
> 
> I've added some more unit tests and an integration test (which increased 
> coverage from ~20% to ~90%). If you have doubt I can quickly add an IT to 
> proof my statement from above.
> 
> O.
> 
> [...]


Re: [VOTE] Release Apache Sling Installer Health Checks 2.1.0

Posted by Oliver Lietz <ap...@oliverlietz.de>.
On Wednesday, 20 July 2022 10:41:04 CEST Oliver Lietz wrote:
> On Tuesday, 19 July 2022 08:27:23 CEST Konrad Windszus wrote:
> > +1,
> > 
> > I don’t think that the changes for
> > https://issues.apache.org/jira/browse/SLING-11463
> > <https://issues.apache.org/jira/browse/SLING-11463> were actually
> > necessary
> > as a DS component is reactivated if a configuration is changed and doesn’t
> > have a modified method. Compare with
> > https://github.com/apache/sling-org-apache-sling-installer-hc/commit/82096
> > 7
> > 59de3e5d0b791a1f45c8fe2e759b5ae391#r78840724
> > <https://github.com/apache/sling-org-apache-sling-installer-hc/commit/8209
> > 6
> > 759de3e5d0b791a1f45c8fe2e759b5ae391#r78840724>.
> > 
> > IMHO adding a modified just allows to reconfigure while the component is
> > running which is not necessary here. Konrad
> 
> That is not true for Felix at least. The component will not be reactivated
> but recreated. Felix will create a complete new instance if modified is
> missing which causes unnecessary fluctuation.

I've added some more unit tests and an integration test (which increased 
coverage from ~20% to ~90%). If you have doubt I can quickly add an IT to 
proof my statement from above.

O.

[...]




Re: [VOTE] Release Apache Sling Installer Health Checks 2.1.0

Posted by Oliver Lietz <ap...@oliverlietz.de>.
On Tuesday, 19 July 2022 08:27:23 CEST Konrad Windszus wrote:
> +1,
> 
> I don’t think that the changes for
> https://issues.apache.org/jira/browse/SLING-11463
> <https://issues.apache.org/jira/browse/SLING-11463> were actually necessary
> as a DS component is reactivated if a configuration is changed and doesn’t
> have a modified method. Compare with
> https://github.com/apache/sling-org-apache-sling-installer-hc/commit/820967
> 59de3e5d0b791a1f45c8fe2e759b5ae391#r78840724
> <https://github.com/apache/sling-org-apache-sling-installer-hc/commit/82096
> 759de3e5d0b791a1f45c8fe2e759b5ae391#r78840724>.
> 
> IMHO adding a modified just allows to reconfigure while the component is
> running which is not necessary here. Konrad

That is not true for Felix at least. The component will not be reactivated but 
recreated. Felix will create a complete new instance if modified is missing 
which causes unnecessary fluctuation.

O.

> > On 19. Jul 2022, at 00:03, Oliver Lietz <ap...@oliverlietz.de> wrote:
> > 
> > Hi,
> > 
> > We solved 4 issues in this release:
> > https://issues.apache.org/jira/browse/SLING/fixforversion/12345553
> > 
> > Staging repository:
> > https://repository.apache.org/content/repositories/orgapachesling-2656
> > 
> > You can use this UNIX script to download the release and verify the
> > signatures:
> > https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=c
> > heck_staged_release.sh;hb=HEAD
> > 
> > Usage:
> > sh check_staged_release.sh 2656 /tmp/sling-staging
> > 
> > Please vote to approve this release:
> >  [ ] +1 Approve the release
> >  [ ]  0 Don't care
> >  [ ] -1 Don't release, because ...
> > 
> > This majority vote is open for at least 72 hours.
> > 
> > Regards,
> > O.





Re: [VOTE] Release Apache Sling Installer Health Checks 2.1.0

Posted by Konrad Windszus <kw...@apache.org>.
+1, 

I don’t think that the changes for https://issues.apache.org/jira/browse/SLING-11463 <https://issues.apache.org/jira/browse/SLING-11463> were actually necessary as a DS component is reactivated if a configuration is changed and doesn’t have a modified method. Compare with https://github.com/apache/sling-org-apache-sling-installer-hc/commit/82096759de3e5d0b791a1f45c8fe2e759b5ae391#r78840724 <https://github.com/apache/sling-org-apache-sling-installer-hc/commit/82096759de3e5d0b791a1f45c8fe2e759b5ae391#r78840724>.

IMHO adding a modified just allows to reconfigure while the component is running which is not necessary here.
Konrad

> On 19. Jul 2022, at 00:03, Oliver Lietz <ap...@oliverlietz.de> wrote:
> 
> Hi,
> 
> We solved 4 issues in this release:
> https://issues.apache.org/jira/browse/SLING/fixforversion/12345553
> 
> Staging repository:
> https://repository.apache.org/content/repositories/orgapachesling-2656
> 
> You can use this UNIX script to download the release and verify the 
> signatures:
> https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD
> 
> Usage:
> sh check_staged_release.sh 2656 /tmp/sling-staging
> 
> Please vote to approve this release:
> 
>  [ ] +1 Approve the release
>  [ ]  0 Don't care
>  [ ] -1 Don't release, because ...
> 
> This majority vote is open for at least 72 hours.
> 
> Regards,
> O.
> 
> 
> 
> 


Re: [VOTE] Release Apache Sling Installer Health Checks 2.1.0

Posted by Oliver Lietz <ap...@oliverlietz.de>.
On Tuesday, 19 July 2022 00:03:02 CEST Oliver Lietz wrote:
> Hi,
> 
> We solved 4 issues in this release:
> https://issues.apache.org/jira/browse/SLING/fixforversion/12345553
> 
> Staging repository:
> https://repository.apache.org/content/repositories/orgapachesling-2656
> 
> You can use this UNIX script to download the release and verify the
> signatures:
> https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=che
> ck_staged_release.sh;hb=HEAD
> 
> Usage:
> sh check_staged_release.sh 2656 /tmp/sling-staging

+1

O.







Re: [VOTE] Release Apache Sling Installer Health Checks 2.1.0

Posted by Carsten Ziegeler <cz...@apache.org>.
+1

Carsten

Am 19.07.2022 um 00:03 schrieb Oliver Lietz:
> Hi,
> 
> We solved 4 issues in this release:
> https://issues.apache.org/jira/browse/SLING/fixforversion/12345553
> 
> Staging repository:
> https://repository.apache.org/content/repositories/orgapachesling-2656
> 
> You can use this UNIX script to download the release and verify the
> signatures:
> https://gitbox.apache.org/repos/asf?p=sling-tooling-release.git;a=blob;f=check_staged_release.sh;hb=HEAD
> 
> Usage:
> sh check_staged_release.sh 2656 /tmp/sling-staging
> 
> Please vote to approve this release:
> 
>    [ ] +1 Approve the release
>    [ ]  0 Don't care
>    [ ] -1 Don't release, because ...
> 
> This majority vote is open for at least 72 hours.
> 
> Regards,
> O.
> 
> 
> 
> 

-- 
Carsten Ziegeler
Adobe
cziegeler@apache.org