You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@metamodel.apache.org by kaspersorensen <gi...@git.apache.org> on 2016/05/16 04:24:12 UTC
[GitHub] metamodel pull request: Removed all deprecated API from MetaModel ...
GitHub user kaspersorensen opened a pull request:
https://github.com/apache/metamodel/pull/101
Removed all deprecated API from MetaModel (aaaaah)
This is a PR for the 5.x branch. I suggest getting rid of all the deprecated methods of metamodel for that release.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kaspersorensen/metamodel feature/5.x/remove-deprecated-stuff
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/metamodel/pull/101.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #101
----
commit 28ba2df15630d2909ea627602065715ea95a919f
Author: kaspersorensen <i....@gmail.com>
Date: 2016-05-16T04:19:11Z
Removed all deprecated API from MetaModel (aaaaah)
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] metamodel pull request: Removed all deprecated API from MetaModel ...
Posted by hsaputra <gi...@git.apache.org>.
Github user hsaputra commented on the pull request:
https://github.com/apache/metamodel/pull/101#issuecomment-220154242
@kaspersorensen just wondering we want to remove the deprecated methods in 5.x branch?
Shouldn't we just do it in master?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] metamodel pull request: Removed all deprecated API from MetaModel ...
Posted by hsaputra <gi...@git.apache.org>.
Github user hsaputra commented on the pull request:
https://github.com/apache/metamodel/pull/101#issuecomment-220419180
Maybe we should do shout out to dev@ list to check if anyone still in 5.0 and ok to add this breaking API changes?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] metamodel pull request: Removed all deprecated API from MetaModel ...
Posted by kaspersorensen <gi...@git.apache.org>.
Github user kaspersorensen commented on the pull request:
https://github.com/apache/metamodel/pull/101#issuecomment-220440238
I'm not sure I understand what you mean Henry? 5.0 isn't out yet so I guess no one will be depending on it yet?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] metamodel pull request: Removed all deprecated API from MetaModel ...
Posted by LosD <gi...@git.apache.org>.
Github user LosD commented on the pull request:
https://github.com/apache/metamodel/pull/101#issuecomment-220357842
Half a year is probably reasonable when we don't have an official policy about keeping depreciations for a certain amount of time.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] metamodel pull request: Removed all deprecated API from MetaModel ...
Posted by kaspersorensen <gi...@git.apache.org>.
Github user kaspersorensen commented on the pull request:
https://github.com/apache/metamodel/pull/101#issuecomment-220359817
I agree Henry, that's why I wanted to put it on the 5.0 branch so that the expectation is also managed a bit :-)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] metamodel pull request: Removed all deprecated API from MetaModel ...
Posted by kaspersorensen <gi...@git.apache.org>.
Github user kaspersorensen commented on the pull request:
https://github.com/apache/metamodel/pull/101#issuecomment-220355905
The most recent deprecations where introduced in MM 4.4 AFAIK. Those where related to the split of FunctionType into AggregateFunction and ScalarFunction interfaces. So the deprecations have been there since the release date of 4.4.0: 2015-10-12.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] metamodel pull request: Removed all deprecated API from MetaModel ...
Posted by LosD <gi...@git.apache.org>.
Github user LosD commented on the pull request:
https://github.com/apache/metamodel/pull/101#issuecomment-220263114
Are all the deprecations old-ish? It might be a major release, but if we can avoid throwing out stuff that has been deprecated only a few months ago, it would be best.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] metamodel pull request: Removed all deprecated API from MetaModel ...
Posted by hsaputra <gi...@git.apache.org>.
Github user hsaputra commented on the pull request:
https://github.com/apache/metamodel/pull/101#issuecomment-220359472
The only worry I have is that this change introduce API changes that could break compilation for minor release
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] metamodel pull request: Removed all deprecated API from MetaModel ...
Posted by kaspersorensen <gi...@git.apache.org>.
Github user kaspersorensen commented on the pull request:
https://github.com/apache/metamodel/pull/101#issuecomment-220467674
Aha yes... Let's ask that.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] metamodel pull request: Removed all deprecated API from MetaModel ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/metamodel/pull/101
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] metamodel pull request: Removed all deprecated API from MetaModel ...
Posted by hsaputra <gi...@git.apache.org>.
Github user hsaputra commented on the pull request:
https://github.com/apache/metamodel/pull/101#issuecomment-220444511
Ah I am so sorry, I need more dose on caffeine =(
I apologize for the confusion.
What I meant was, would anyone in 4.0 still need it to be around for 5.0.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] metamodel pull request: Removed all deprecated API from MetaModel ...
Posted by kaspersorensen <gi...@git.apache.org>.
Github user kaspersorensen commented on the pull request:
https://github.com/apache/metamodel/pull/101#issuecomment-220177537
We could do it in master, but I guess it seems nicer to only do that sort of thing when it aligns on a bigger release.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---