You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Gautam Borad <gb...@gmail.com> on 2016/04/05 19:42:44 UTC
Review Request 45756: RANGER-912 : Ranger Admin UI to support
datamask & row-filter policies
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45756/
-----------------------------------------------------------
Review request for ranger, Alok Lal, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Ramesh Mani, and Selvamohan Neethiraj.
Bugs: RANGER-912
https://issues.apache.org/jira/browse/RANGER-912
Repository: ranger
Description
-------
**Problem Statement**
Ranger policy model has been updated to support data-masking and row-filtering policy types for components like Hive. Policy UI should be updated to support these new types of policies.
**Proposed Solution**
Changes in generic UI implementation to allow masking and row-level filtering.
Diffs
-----
security-admin/src/main/webapp/scripts/controllers/Controller.js 54ebcd7
security-admin/src/main/webapp/scripts/models/BackboneFormDataType.js a776f69
security-admin/src/main/webapp/scripts/modules/XALinks.js 5fec205
security-admin/src/main/webapp/scripts/modules/XAOverrides.js 6f0a48d
security-admin/src/main/webapp/scripts/modules/globalize/message/en.js 604c6be
security-admin/src/main/webapp/scripts/routers/Router.js d8aea1b
security-admin/src/main/webapp/scripts/utils/XAEnums.js cb10f08
security-admin/src/main/webapp/scripts/utils/XAUtils.js 7bf7bdb
security-admin/src/main/webapp/scripts/views/policies/PermissionList.js fb4808e
security-admin/src/main/webapp/scripts/views/policies/RangerPolicyCreate.js ceeac67
security-admin/src/main/webapp/scripts/views/policies/RangerPolicyForm.js 8518765
security-admin/src/main/webapp/scripts/views/policies/RangerPolicyTableLayout.js baad130
security-admin/src/main/webapp/scripts/views/service/ServiceForm.js dcec203
security-admin/src/main/webapp/templates/helpers/XAHelpers.js ff27f97
security-admin/src/main/webapp/templates/policies/PermissionItem.html 99c20fa
security-admin/src/main/webapp/templates/policies/RangerPolicyForm_tmpl.html 9e31b0d
security-admin/src/main/webapp/templates/policies/RangerPolicyTableLayout_tmpl.html 6776d5d
Diff: https://reviews.apache.org/r/45756/diff/
Testing
-------
Verified CRUD of Policies of type Access, Masking and also Row-level filter.
Thanks,
Gautam Borad
Re: Review Request 45756: RANGER-912 : Ranger Admin UI to support
datamask & row-filter policies
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45756/#review128670
-----------------------------------------------------------
Ship it!
Ship It!
- Madhan Neethiraj
On April 13, 2016, 9:39 a.m., Gautam Borad wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45756/
> -----------------------------------------------------------
>
> (Updated April 13, 2016, 9:39 a.m.)
>
>
> Review request for ranger, Alok Lal, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Ramesh Mani, and Selvamohan Neethiraj.
>
>
> Bugs: RANGER-912
> https://issues.apache.org/jira/browse/RANGER-912
>
>
> Repository: ranger
>
>
> Description
> -------
>
> **Problem Statement**
> Ranger policy model has been updated to support data-masking and row-filtering policy types for components like Hive. Policy UI should be updated to support these new types of policies.
>
> **Proposed Solution**
> Changes in generic UI implementation to allow masking and row-level filtering.
>
>
> Diffs
> -----
>
> security-admin/src/main/webapp/scripts/views/policies/RangerPolicyForm.js 253031d
>
> Diff: https://reviews.apache.org/r/45756/diff/
>
>
> Testing
> -------
>
> Verified CRUD of Policies of type Access, Masking and also Row-level filter.
>
>
> Thanks,
>
> Gautam Borad
>
>
Re: Review Request 45756: RANGER-912 : Ranger Admin UI to support
datamask & row-filter policies
Posted by Gautam Borad <gb...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45756/
-----------------------------------------------------------
(Updated April 13, 2016, 9:39 a.m.)
Review request for ranger, Alok Lal, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Ramesh Mani, and Selvamohan Neethiraj.
Changes
-------
This new patch takes care of showing policyItems when enableDenyAndExceptionsInPolicies=true for data-masking policy or row-level filter policy.
Tested : Policy CRUD by addding enableDenyAndExceptionsInPolicies as true or false and also by removing the same in the service def for all policy type(Access,Masking, row filter)
Bugs: RANGER-912
https://issues.apache.org/jira/browse/RANGER-912
Repository: ranger
Description
-------
**Problem Statement**
Ranger policy model has been updated to support data-masking and row-filtering policy types for components like Hive. Policy UI should be updated to support these new types of policies.
**Proposed Solution**
Changes in generic UI implementation to allow masking and row-level filtering.
Diffs (updated)
-----
security-admin/src/main/webapp/scripts/views/policies/RangerPolicyForm.js 253031d
Diff: https://reviews.apache.org/r/45756/diff/
Testing
-------
Verified CRUD of Policies of type Access, Masking and also Row-level filter.
Thanks,
Gautam Borad
Re: Review Request 45756: RANGER-912 : Ranger Admin UI to support
datamask & row-filter policies
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45756/#review127181
-----------------------------------------------------------
Ship it!
Verified that Ranger Admin with this patch supports policy UI for datamask and row-filter policies. The UI looks pretty good! Thanks.
- Madhan Neethiraj
On April 5, 2016, 5:42 p.m., Gautam Borad wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45756/
> -----------------------------------------------------------
>
> (Updated April 5, 2016, 5:42 p.m.)
>
>
> Review request for ranger, Alok Lal, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, Ramesh Mani, and Selvamohan Neethiraj.
>
>
> Bugs: RANGER-912
> https://issues.apache.org/jira/browse/RANGER-912
>
>
> Repository: ranger
>
>
> Description
> -------
>
> **Problem Statement**
> Ranger policy model has been updated to support data-masking and row-filtering policy types for components like Hive. Policy UI should be updated to support these new types of policies.
>
> **Proposed Solution**
> Changes in generic UI implementation to allow masking and row-level filtering.
>
>
> Diffs
> -----
>
> security-admin/src/main/webapp/scripts/controllers/Controller.js 54ebcd7
> security-admin/src/main/webapp/scripts/models/BackboneFormDataType.js a776f69
> security-admin/src/main/webapp/scripts/modules/XALinks.js 5fec205
> security-admin/src/main/webapp/scripts/modules/XAOverrides.js 6f0a48d
> security-admin/src/main/webapp/scripts/modules/globalize/message/en.js 604c6be
> security-admin/src/main/webapp/scripts/routers/Router.js d8aea1b
> security-admin/src/main/webapp/scripts/utils/XAEnums.js cb10f08
> security-admin/src/main/webapp/scripts/utils/XAUtils.js 7bf7bdb
> security-admin/src/main/webapp/scripts/views/policies/PermissionList.js fb4808e
> security-admin/src/main/webapp/scripts/views/policies/RangerPolicyCreate.js ceeac67
> security-admin/src/main/webapp/scripts/views/policies/RangerPolicyForm.js 8518765
> security-admin/src/main/webapp/scripts/views/policies/RangerPolicyTableLayout.js baad130
> security-admin/src/main/webapp/scripts/views/service/ServiceForm.js dcec203
> security-admin/src/main/webapp/templates/helpers/XAHelpers.js ff27f97
> security-admin/src/main/webapp/templates/policies/PermissionItem.html 99c20fa
> security-admin/src/main/webapp/templates/policies/RangerPolicyForm_tmpl.html 9e31b0d
> security-admin/src/main/webapp/templates/policies/RangerPolicyTableLayout_tmpl.html 6776d5d
>
> Diff: https://reviews.apache.org/r/45756/diff/
>
>
> Testing
> -------
>
> Verified CRUD of Policies of type Access, Masking and also Row-level filter.
>
>
> Thanks,
>
> Gautam Borad
>
>