You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@arrow.apache.org by ko...@apache.org on 2023/04/06 05:36:08 UTC

[arrow] branch main updated: GH-34768: [C++][Gandiva] Accept LLVM 16 (#34916)

This is an automated email from the ASF dual-hosted git repository.

kou pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/arrow.git


The following commit(s) were added to refs/heads/main by this push:
     new 6530b0193d GH-34768: [C++][Gandiva] Accept LLVM 16 (#34916)
6530b0193d is described below

commit 6530b0193d3ad710c563b4f56f407453f66ce09b
Author: Sutou Kouhei <ko...@clear-code.com>
AuthorDate: Thu Apr 6 14:36:01 2023 +0900

    GH-34768: [C++][Gandiva] Accept LLVM 16 (#34916)
    
    ### Rationale for this change
    
    LLVM 16 has been released.
    
    ### What changes are included in this PR?
    
    Accept LLVM 16.
    
    ### Are these changes tested?
    
    Yes.
    
    ### Are there any user-facing changes?
    
    Yes.
    * Closes: #34768
    
    Authored-by: Sutou Kouhei <ko...@clear-code.com>
    Signed-off-by: Sutou Kouhei <ko...@clear-code.com>
---
 .github/workflows/ruby.yml | 3 +--
 ci/scripts/cpp_test.sh     | 7 +++----
 cpp/CMakeLists.txt         | 1 +
 3 files changed, 5 insertions(+), 6 deletions(-)

diff --git a/.github/workflows/ruby.yml b/.github/workflows/ruby.yml
index 7f7c0f8fda..87c444d018 100644
--- a/.github/workflows/ruby.yml
+++ b/.github/workflows/ruby.yml
@@ -204,8 +204,7 @@ jobs:
       ARROW_BUILD_TYPE: release
       ARROW_FLIGHT: ON
       ARROW_FLIGHT_SQL: ON
-      # ARROW-17728: SEGV on MinGW
-      ARROW_GANDIVA: OFF
+      ARROW_GANDIVA: ON
       ARROW_GCS: ON
       ARROW_HDFS: OFF
       ARROW_HOME: /ucrt${{ matrix.mingw-n-bits }}
diff --git a/ci/scripts/cpp_test.sh b/ci/scripts/cpp_test.sh
index 2d829411b1..3acf56bae0 100755
--- a/ci/scripts/cpp_test.sh
+++ b/ci/scripts/cpp_test.sh
@@ -52,10 +52,7 @@ case "$(uname)" in
     n_jobs=${NUMBER_OF_PROCESSORS:-1}
     # TODO: Enable these crashed tests.
     # https://issues.apache.org/jira/browse/ARROW-9072
-    exclude_tests="gandiva-internals-test"
-    exclude_tests="${exclude_tests}|gandiva-projector-test"
-    exclude_tests="${exclude_tests}|gandiva-utf8-test"
-    exclude_tests="${exclude_tests}|gandiva-binary-test"
+    exclude_tests="gandiva-binary-test"
     exclude_tests="${exclude_tests}|gandiva-boolean-expr-test"
     exclude_tests="${exclude_tests}|gandiva-date-time-test"
     exclude_tests="${exclude_tests}|gandiva-decimal-single-test"
@@ -65,10 +62,12 @@ case "$(uname)" in
     exclude_tests="${exclude_tests}|gandiva-hash-test"
     exclude_tests="${exclude_tests}|gandiva-if-expr-test"
     exclude_tests="${exclude_tests}|gandiva-in-expr-test"
+    exclude_tests="${exclude_tests}|gandiva-internals-test"
     exclude_tests="${exclude_tests}|gandiva-literal-test"
     exclude_tests="${exclude_tests}|gandiva-null-validity-test"
     exclude_tests="${exclude_tests}|gandiva-precompiled-test"
     exclude_tests="${exclude_tests}|gandiva-projector-test"
+    exclude_tests="${exclude_tests}|gandiva-utf8-test"
     ctest_options+=(--exclude-regex "${exclude_tests}")
     ;;
   *)
diff --git a/cpp/CMakeLists.txt b/cpp/CMakeLists.txt
index 20a919d111..9a9f54478b 100644
--- a/cpp/CMakeLists.txt
+++ b/cpp/CMakeLists.txt
@@ -128,6 +128,7 @@ set(ARROW_DOC_DIR "share/doc/${PROJECT_NAME}")
 set(BUILD_SUPPORT_DIR "${CMAKE_SOURCE_DIR}/build-support")
 
 set(ARROW_LLVM_VERSIONS
+    "16.0"
     "15.0"
     "14.0"
     "13.0"