You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Tim Armstrong (Code Review)" <ge...@cloudera.org> on 2019/06/26 23:30:19 UTC
[Impala-ASF-CR] IMPALA-8713: fix stack overflow in unhex()
Tim Armstrong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13743
Change subject: IMPALA-8713: fix stack overflow in unhex()
......................................................................
IMPALA-8713: fix stack overflow in unhex()
Write the results into the output heap buffer
instead of into a temporary stack buffer.
No additional memory is used because
AnyValUtil::FromBuffer() allocated a temporary
buffer anyway.
Testing:
Added a targeted test to expr-test that caused
a crash before this fix.
Change-Id: Ie0c1760511a04c0823fc465cf6e529e9681b2488
---
M be/src/exprs/expr-test.cc
M be/src/exprs/math-functions-ir.cc
2 files changed, 6 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/43/13743/1
--
To view, visit http://gerrit.cloudera.org:8080/13743
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie0c1760511a04c0823fc465cf6e529e9681b2488
Gerrit-Change-Number: 13743
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
[Impala-ASF-CR] IMPALA-8713: fix stack overflow in unhex()
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13743 )
Change subject: IMPALA-8713: fix stack overflow in unhex()
......................................................................
Patch Set 2:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/4566/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/13743
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie0c1760511a04c0823fc465cf6e529e9681b2488
Gerrit-Change-Number: 13743
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 27 Jun 2019 21:21:26 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8713: fix stack overflow in unhex()
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13743 )
Change subject: IMPALA-8713: fix stack overflow in unhex()
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/13743
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie0c1760511a04c0823fc465cf6e529e9681b2488
Gerrit-Change-Number: 13743
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 27 Jun 2019 21:21:25 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8713: fix stack overflow in unhex()
Posted by "Andrew Sherman (Code Review)" <ge...@cloudera.org>.
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/13743 )
Change subject: IMPALA-8713: fix stack overflow in unhex()
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/13743
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie0c1760511a04c0823fc465cf6e529e9681b2488
Gerrit-Change-Number: 13743
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 27 Jun 2019 19:00:16 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8713: fix stack overflow in unhex()
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13743 )
Change subject: IMPALA-8713: fix stack overflow in unhex()
......................................................................
Patch Set 2: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/13743
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie0c1760511a04c0823fc465cf6e529e9681b2488
Gerrit-Change-Number: 13743
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 28 Jun 2019 03:02:00 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8713: fix stack overflow in unhex()
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/13743 )
Change subject: IMPALA-8713: fix stack overflow in unhex()
......................................................................
IMPALA-8713: fix stack overflow in unhex()
Write the results into the output heap buffer
instead of into a temporary stack buffer.
No additional memory is used because
AnyValUtil::FromBuffer() allocated a temporary
buffer anyway.
Testing:
Added a targeted test to expr-test that caused
a crash before this fix.
Change-Id: Ie0c1760511a04c0823fc465cf6e529e9681b2488
Reviewed-on: http://gerrit.cloudera.org:8080/13743
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M be/src/exprs/expr-test.cc
M be/src/exprs/math-functions-ir.cc
2 files changed, 6 insertions(+), 3 deletions(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/13743
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie0c1760511a04c0823fc465cf6e529e9681b2488
Gerrit-Change-Number: 13743
Gerrit-PatchSet: 3
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] IMPALA-8713: fix stack overflow in unhex()
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/13743 )
Change subject: IMPALA-8713: fix stack overflow in unhex()
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/3759/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/13743
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie0c1760511a04c0823fc465cf6e529e9681b2488
Gerrit-Change-Number: 13743
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 27 Jun 2019 00:27:03 +0000
Gerrit-HasComments: No