You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@harmony.apache.org by "Kevin Zhou (JIRA)" <ji...@apache.org> on 2009/03/04 03:30:56 UTC

[jira] Created: (HARMONY-6107) [classlib] [prefs] Refactor code in AbstractPreferences, FilePreferencesImpl, RegistryPreferencesImpl and some test cases.

[classlib] [prefs] Refactor code in AbstractPreferences, FilePreferencesImpl, RegistryPreferencesImpl and some test cases.
--------------------------------------------------------------------------------------------------------------------------

                 Key: HARMONY-6107
                 URL: https://issues.apache.org/jira/browse/HARMONY-6107
             Project: Harmony
          Issue Type: Test
          Components: Classlib
    Affects Versions: 5.0M8
            Reporter: Kevin Zhou
            Priority: Minor
             Fix For: 5.0M9


Refactor code in: 
(1) AbstractPreferences
(2) FilePreferencesImpl
(3) RegistryPreferencesImpl
(4) PreferencesFactoryTest
(5) PreferencesTest
Add some more test cases as well.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Commented: (HARMONY-6107) [classlib] [prefs] Refactor code in AbstractPreferences, FilePreferencesImpl, RegistryPreferencesImpl and some test cases.

Posted by "Regis Xu (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HARMONY-6107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12699605#action_12699605 ] 

Regis Xu commented on HARMONY-6107:
-----------------------------------

I'm aware that patch HARMONY-6107v2.diff removed one test method, testAbstractMethods in PreferencesTest.java, do you think all the cases in this method could be covered by others? Or is it possible to add more "assert" to make the test more useful?

> [classlib] [prefs] Refactor code in AbstractPreferences, FilePreferencesImpl, RegistryPreferencesImpl and some test cases.
> --------------------------------------------------------------------------------------------------------------------------
>
>                 Key: HARMONY-6107
>                 URL: https://issues.apache.org/jira/browse/HARMONY-6107
>             Project: Harmony
>          Issue Type: Test
>          Components: Classlib
>    Affects Versions: 5.0M8
>            Reporter: Kevin Zhou
>            Priority: Minor
>             Fix For: 5.0M9
>
>         Attachments: HARMONY-6107.diff, HARMONY-6107v2.diff
>
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> Refactor code in: 
> (1) AbstractPreferences
> (2) FilePreferencesImpl
> (3) RegistryPreferencesImpl
> (4) PreferencesFactoryTest
> (5) PreferencesTest
> Add some more test cases as well.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Updated: (HARMONY-6107) [classlib] [prefs] Refactor code in AbstractPreferences, FilePreferencesImpl, RegistryPreferencesImpl and some test cases.

Posted by "Kevin Zhou (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-6107?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Kevin Zhou updated HARMONY-6107:
--------------------------------

    Attachment: HARMONY-6107v2.diff

> [classlib] [prefs] Refactor code in AbstractPreferences, FilePreferencesImpl, RegistryPreferencesImpl and some test cases.
> --------------------------------------------------------------------------------------------------------------------------
>
>                 Key: HARMONY-6107
>                 URL: https://issues.apache.org/jira/browse/HARMONY-6107
>             Project: Harmony
>          Issue Type: Test
>          Components: Classlib
>    Affects Versions: 5.0M8
>            Reporter: Kevin Zhou
>            Priority: Minor
>             Fix For: 5.0M9
>
>         Attachments: HARMONY-6107.diff, HARMONY-6107v2.diff
>
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> Refactor code in: 
> (1) AbstractPreferences
> (2) FilePreferencesImpl
> (3) RegistryPreferencesImpl
> (4) PreferencesFactoryTest
> (5) PreferencesTest
> Add some more test cases as well.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Updated: (HARMONY-6107) [classlib] [prefs] Refactor code in AbstractPreferences, FilePreferencesImpl, RegistryPreferencesImpl and some test cases.

Posted by "Tim Ellison (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-6107?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Tim Ellison updated HARMONY-6107:
---------------------------------

    Fix Version/s:     (was: 5.0M9)
                   5.0M10

> [classlib] [prefs] Refactor code in AbstractPreferences, FilePreferencesImpl, RegistryPreferencesImpl and some test cases.
> --------------------------------------------------------------------------------------------------------------------------
>
>                 Key: HARMONY-6107
>                 URL: https://issues.apache.org/jira/browse/HARMONY-6107
>             Project: Harmony
>          Issue Type: Test
>          Components: Classlib
>    Affects Versions: 5.0M8
>            Reporter: Kevin Zhou
>            Priority: Minor
>             Fix For: 5.0M10
>
>         Attachments: HARMONY-6107.diff, HARMONY-6107v2.diff
>
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> Refactor code in: 
> (1) AbstractPreferences
> (2) FilePreferencesImpl
> (3) RegistryPreferencesImpl
> (4) PreferencesFactoryTest
> (5) PreferencesTest
> Add some more test cases as well.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Resolved: (HARMONY-6107) [classlib] [prefs] Refactor code in AbstractPreferences, FilePreferencesImpl, RegistryPreferencesImpl and some test cases.

Posted by "Regis Xu (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-6107?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Regis Xu resolved HARMONY-6107.
-------------------------------

    Resolution: Fixed

Thanks Kevin,

Patch HARMONY-6107v2.diff applied to repo at r765844 with minor changes,
please verify it was applied as you expected.

> [classlib] [prefs] Refactor code in AbstractPreferences, FilePreferencesImpl, RegistryPreferencesImpl and some test cases.
> --------------------------------------------------------------------------------------------------------------------------
>
>                 Key: HARMONY-6107
>                 URL: https://issues.apache.org/jira/browse/HARMONY-6107
>             Project: Harmony
>          Issue Type: Test
>          Components: Classlib
>    Affects Versions: 5.0M8
>            Reporter: Kevin Zhou
>            Priority: Minor
>             Fix For: 5.0M9
>
>         Attachments: HARMONY-6107.diff, HARMONY-6107v2.diff
>
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> Refactor code in: 
> (1) AbstractPreferences
> (2) FilePreferencesImpl
> (3) RegistryPreferencesImpl
> (4) PreferencesFactoryTest
> (5) PreferencesTest
> Add some more test cases as well.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Closed: (HARMONY-6107) [classlib] [prefs] Refactor code in AbstractPreferences, FilePreferencesImpl, RegistryPreferencesImpl and some test cases.

Posted by "Regis Xu (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-6107?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Regis Xu closed HARMONY-6107.
-----------------------------


No response from reporter, assume OK.

> [classlib] [prefs] Refactor code in AbstractPreferences, FilePreferencesImpl, RegistryPreferencesImpl and some test cases.
> --------------------------------------------------------------------------------------------------------------------------
>
>                 Key: HARMONY-6107
>                 URL: https://issues.apache.org/jira/browse/HARMONY-6107
>             Project: Harmony
>          Issue Type: Test
>          Components: Classlib
>    Affects Versions: 5.0M8
>            Reporter: Kevin Zhou
>            Priority: Minor
>             Fix For: 5.0M10
>
>         Attachments: HARMONY-6107.diff, HARMONY-6107v2.diff
>
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> Refactor code in: 
> (1) AbstractPreferences
> (2) FilePreferencesImpl
> (3) RegistryPreferencesImpl
> (4) PreferencesFactoryTest
> (5) PreferencesTest
> Add some more test cases as well.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Commented: (HARMONY-6107) [classlib] [prefs] Refactor code in AbstractPreferences, FilePreferencesImpl, RegistryPreferencesImpl and some test cases.

Posted by "Kevin Zhou (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HARMONY-6107?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12699608#action_12699608 ] 

Kevin Zhou commented on HARMONY-6107:
-------------------------------------

Hi Regis, 
First of all, thank for your question.
I think the testAbstractMethods doesn't test anything here.
I suggest remove it here. And I think all of those useful scenarios can be covered by other test methods.

> [classlib] [prefs] Refactor code in AbstractPreferences, FilePreferencesImpl, RegistryPreferencesImpl and some test cases.
> --------------------------------------------------------------------------------------------------------------------------
>
>                 Key: HARMONY-6107
>                 URL: https://issues.apache.org/jira/browse/HARMONY-6107
>             Project: Harmony
>          Issue Type: Test
>          Components: Classlib
>    Affects Versions: 5.0M8
>            Reporter: Kevin Zhou
>            Priority: Minor
>             Fix For: 5.0M9
>
>         Attachments: HARMONY-6107.diff, HARMONY-6107v2.diff
>
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> Refactor code in: 
> (1) AbstractPreferences
> (2) FilePreferencesImpl
> (3) RegistryPreferencesImpl
> (4) PreferencesFactoryTest
> (5) PreferencesTest
> Add some more test cases as well.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

[jira] Updated: (HARMONY-6107) [classlib] [prefs] Refactor code in AbstractPreferences, FilePreferencesImpl, RegistryPreferencesImpl and some test cases.

Posted by "Kevin Zhou (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HARMONY-6107?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Kevin Zhou updated HARMONY-6107:
--------------------------------

    Attachment: HARMONY-6107.diff

Would you please help to try it?

> [classlib] [prefs] Refactor code in AbstractPreferences, FilePreferencesImpl, RegistryPreferencesImpl and some test cases.
> --------------------------------------------------------------------------------------------------------------------------
>
>                 Key: HARMONY-6107
>                 URL: https://issues.apache.org/jira/browse/HARMONY-6107
>             Project: Harmony
>          Issue Type: Test
>          Components: Classlib
>    Affects Versions: 5.0M8
>            Reporter: Kevin Zhou
>            Priority: Minor
>             Fix For: 5.0M9
>
>         Attachments: HARMONY-6107.diff
>
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> Refactor code in: 
> (1) AbstractPreferences
> (2) FilePreferencesImpl
> (3) RegistryPreferencesImpl
> (4) PreferencesFactoryTest
> (5) PreferencesTest
> Add some more test cases as well.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.