You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@perl.apache.org by Joe Orton <jo...@redhat.com> on 2004/10/05 12:36:24 UTC
[PATCH] Apache__RequestUtil.h fix
New build break with older compilers, from a declaration after a
statement:
--- xs/Apache/RequestUtil/Apache__RequestUtil.h 4 Oct 2004 19:27:37 -0000 1.26
+++ xs/Apache/RequestUtil/Apache__RequestUtil.h 5 Oct 2004 10:32:34 -0000
@@ -306,10 +306,12 @@
const char *retval = ap_document_root(r);
if (new_root) {
- MP_CROAK_IF_THREADS_STARTED("setting $r->document_root");
core_server_config *conf =
ap_get_module_config(r->server->module_config,
&core_module);
+
+ MP_CROAK_IF_THREADS_STARTED("setting $r->document_root");
+
conf->ap_document_root = SvPV_nolen(new_root);
}
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org
Re: [PATCH] Apache__RequestUtil.h fix
Posted by "Philippe M. Chiasson" <go...@ectoplasm.org>.
Joe Orton wrote:
> New build break with older compilers, from a declaration after a
> statement:
Bah! Thanks for the spot, usually I am the one reporting these problems
on other people's code ;-) Fixed!
> --- xs/Apache/RequestUtil/Apache__RequestUtil.h 4 Oct 2004 19:27:37 -0000 1.26
> +++ xs/Apache/RequestUtil/Apache__RequestUtil.h 5 Oct 2004 10:32:34 -0000
> @@ -306,10 +306,12 @@
> const char *retval = ap_document_root(r);
>
> if (new_root) {
> - MP_CROAK_IF_THREADS_STARTED("setting $r->document_root");
> core_server_config *conf =
> ap_get_module_config(r->server->module_config,
> &core_module);
> +
> + MP_CROAK_IF_THREADS_STARTED("setting $r->document_root");
> +
> conf->ap_document_root = SvPV_nolen(new_root);
> }
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
> For additional commands, e-mail: dev-help@perl.apache.org
>
>
--
--------------------------------------------------------------------------------
Philippe M. Chiasson m/gozer\@(apache|cpan|ectoplasm)\.org/ GPG KeyID : 88C3A5A5
http://gozer.ectoplasm.org/ F9BF E0C2 480E 7680 1AE5 3631 CB32 A107 88C3A5A5
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org