[GitHub] [airflow] htgeis commented on pull request #12825: Enable to expand the key file path in ssh hooks

[GitBox <gi...@apache.org>]

htgeis commented on pull request #12825:
URL: https://github.com/apache/airflow/pull/12825#issuecomment-739450965


   > > These variables maybe change in the future and it's better not to do hard code in the connection.
   > 
   > This doesn't convince me: anything can change, including the non-envvar parts. File paths here should be _explicit_ and DAG author should have full responsibility for that.
   
   In our case which is a multi-tenant scenario, the dag authors could know the relative path of their key files but the root path we don't want to let them care about it. It did provide more flexibility for us and `expandvars` is just a simple logic which I think would not have impact for the original user cases. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org