You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@helix.apache.org by GitBox <gi...@apache.org> on 2020/03/24 18:04:03 UTC
[GitHub] [helix] mgao0 opened a new pull request #909: Created generic get
and update methods for Cluster and REST config
mgao0 opened a new pull request #909: Created generic get and update methods for Cluster and REST config
URL: https://github.com/apache/helix/pull/909
### Issues
- [ ] My PR addresses the following Helix issues and references them in the PR description:
Currently in ClusterAccessor, get/update ClusterConfig and RESTConfig methods share some common logics, and results in duplicated code. This PR is intended to reduce the duplicated code by taking out the logic and create a common method for both ClusterConfig and RESTConfig.
### Description
- [ ] Here are some details about my PR, including screenshots of any UI changes:
A createConfig and a updateConfig method are created to be called in specific method. For example, createClusterConfig calls createConfig and pass in a parameter indicating this is for cluster config.
### Tests
- [ ] The following is the result of the "mvn test" command on the appropriate module:
Results :
Tests run: 102, Failures: 0, Errors: 0, Skipped: 0
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 03:00 min
[INFO] Finished at: 2020-03-24T11:02:46-07:00
[INFO] ------------------------------------------------------------------------
### Commits
- [ ] My commits all reference appropriate Apache Helix GitHub issues in their subject lines. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Code Quality
- [ ] My diff has been formatted using helix-style.xml
(helix-style-intellij.xml if IntelliJ IDE is used)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] mgao0 commented on issue #909: Created generic get and
update methods for Cluster and REST config
Posted by GitBox <gi...@apache.org>.
mgao0 commented on issue #909: Created generic get and update methods for Cluster and REST config
URL: https://github.com/apache/helix/pull/909#issuecomment-611216502
Revisiting this after all the merge is done.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] mgao0 closed pull request #909: Created generic get and
update methods for Cluster and REST config
Posted by GitBox <gi...@apache.org>.
mgao0 closed pull request #909: Created generic get and update methods for Cluster and REST config
URL: https://github.com/apache/helix/pull/909
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] dasahcc commented on a change in pull request #909: Created
generic get and update methods for Cluster and REST config
Posted by GitBox <gi...@apache.org>.
dasahcc commented on a change in pull request #909: Created generic get and update methods for Cluster and REST config
URL: https://github.com/apache/helix/pull/909#discussion_r400505452
##########
File path: helix-rest/src/main/java/org/apache/helix/rest/server/resources/helix/ClusterAccessor.java
##########
@@ -671,4 +559,85 @@ private boolean doesClusterExist(String cluster) {
}
return history;
}
+
+ private Response updateConfig(String clusterId, String commandStr, String content,
Review comment:
That is a good refactoring. Just a nit suggestion, maybe we can move this to a Util class and apply to all other configs operations for different REST accessors such as ResourceConfig, InstanceConfig and so on.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org