You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by "xiangfu0 (via GitHub)" <gi...@apache.org> on 2023/07/07 21:46:47 UTC

[GitHub] [pinot] xiangfu0 opened a new issue, #11065: [multistage] [bug] unable to resolve table names for COMMA join

xiangfu0 opened a new issue, #11065:
URL: https://github.com/apache/pinot/issues/11065

   The query is executable, but unable to resolve the table names.
   You can reproduce this from SSBQueryIntegrationTest.
   ```
   14:40:52.934 ERROR [Connection] [main] Cannot parse table name from query: select sum(CAST(LO_EXTENDEDPRICE AS DOUBLE) * LO_DISCOUNT) as revenue
   from lineorder, dates where LO_ORDERDATE = D_DATEKEY and D_YEARMONTHNUM = 199401
   and LO_DISCOUNT between 4 and 6 and LO_QUANTITY between 26 and 35;
   . Fallback to broker selector default.
   java.lang.IllegalStateException: Unsupported join type: COMMA
   	at org.apache.pinot.sql.parsers.CalciteSqlParser.compileToJoin(CalciteSqlParser.java:498) ~[classes/:?]
   	at org.apache.pinot.sql.parsers.CalciteSqlParser.compileToDataSource(CalciteSqlParser.java:474) ~[classes/:?]
   	at org.apache.pinot.sql.parsers.CalciteSqlParser.compileSqlNodeToPinotQuery(CalciteSqlParser.java:421) ~[classes/:?]
   	at org.apache.pinot.client.Connection.resolveTableName(Connection.java:195) [classes/:?]
   	at org.apache.pinot.client.Connection.execute(Connection.java:118) [classes/:?]
   	at org.apache.pinot.client.Connection.execute(Connection.java:93) [classes/:?]
   	at org.apache.pinot.integration.tests.SSBQueryIntegrationTest.testQueriesValidateAgainstH2(SSBQueryIntegrationTest.java:109) [test-classes/:?]
   	at org.apache.pinot.integration.tests.SSBQueryIntegrationTest.testSSBQueries(SSBQueryIntegrationTest.java:103) [test-classes/:?]
   	at jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:?]
   	at jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) ~[?:?]
   	at jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[?:?]
   	at java.lang.reflect.Method.invoke(Method.java:566) ~[?:?]
   	at org.testng.internal.MethodInvocationHelper.invokeMethod(MethodInvocationHelper.java:108) [testng-6.11.jar:?]
   	at org.testng.internal.Invoker.invokeMethod(Invoker.java:661) [testng-6.11.jar:?]
   	at org.testng.internal.Invoker.invokeTestMethod(Invoker.java:869) [testng-6.11.jar:?]
   	at org.testng.internal.Invoker.invokeTestMethods(Invoker.java:1193) [testng-6.11.jar:?]
   	at org.testng.internal.TestMethodWorker.invokeTestMethods(TestMethodWorker.java:126) [testng-6.11.jar:?]
   	at org.testng.internal.TestMethodWorker.run(TestMethodWorker.java:109) [testng-6.11.jar:?]
   	at org.testng.TestRunner.privateRun(TestRunner.java:744) [testng-6.11.jar:?]
   	at org.testng.TestRunner.run(TestRunner.java:602) [testng-6.11.jar:?]
   	at org.testng.SuiteRunner.runTest(SuiteRunner.java:380) [testng-6.11.jar:?]
   	at org.testng.SuiteRunner.runSequentially(SuiteRunner.java:375) [testng-6.11.jar:?]
   	at org.testng.SuiteRunner.privateRun(SuiteRunner.java:340) [testng-6.11.jar:?]
   	at org.testng.SuiteRunner.run(SuiteRunner.java:289) [testng-6.11.jar:?]
   	at org.testng.SuiteRunnerWorker.runSuite(SuiteRunnerWorker.java:52) [testng-6.11.jar:?]
   	at org.testng.SuiteRunnerWorker.run(SuiteRunnerWorker.java:86) [testng-6.11.jar:?]
   	at org.testng.TestNG.runSuitesSequentially(TestNG.java:1301) [testng-6.11.jar:?]
   	at org.testng.TestNG.runSuitesLocally(TestNG.java:1226) [testng-6.11.jar:?]
   	at org.testng.TestNG.runSuites(TestNG.java:1144) [testng-6.11.jar:?]
   	at org.testng.TestNG.run(TestNG.java:1115) [testng-6.11.jar:?]
   	at com.intellij.rt.testng.IDEARemoteTestNG.run(IDEARemoteTestNG.java:66) [testng-rt.jar:?]
   	at com.intellij.rt.testng.RemoteTestNGStarter.main(RemoteTestNGStarter.java:105) [testng-rt.jar:?]
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org


[GitHub] [pinot] xiangfu0 commented on issue #11065: [multistage] [bug] unable to resolve table names for COMMA join

Posted by "xiangfu0 (via GitHub)" <gi...@apache.org>.
xiangfu0 commented on issue #11065:
URL: https://github.com/apache/pinot/issues/11065#issuecomment-1626210758

   cc: @walterddr @tibrewalpratik17 @abhioncbr


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org


[GitHub] [pinot] xiangfu0 commented on issue #11065: [multistage] [bug] unable to resolve table names for COMMA join

Posted by "xiangfu0 (via GitHub)" <gi...@apache.org>.
xiangfu0 commented on issue #11065:
URL: https://github.com/apache/pinot/issues/11065#issuecomment-1627464890

   https://github.com/apache/pinot/pull/11069
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org


[GitHub] [pinot] xiangfu0 commented on issue #11065: [multistage] [bug] unable to resolve table names for COMMA join

Posted by "xiangfu0 (via GitHub)" <gi...@apache.org>.
xiangfu0 commented on issue #11065:
URL: https://github.com/apache/pinot/issues/11065#issuecomment-1627465047

   > I am working on the fix. Thanks
   Ah sorry missed your message, can you take a look the above pr.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org


[GitHub] [pinot] abhioncbr commented on issue #11065: [multistage] [bug] unable to resolve table names for COMMA join

Posted by "abhioncbr (via GitHub)" <gi...@apache.org>.
abhioncbr commented on issue #11065:
URL: https://github.com/apache/pinot/issues/11065#issuecomment-1626400917

   I am working on the fix. Thanks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org


[GitHub] [pinot] walterddr commented on issue #11065: [multistage] [bug] unable to resolve table names for COMMA join

Posted by "walterddr (via GitHub)" <gi...@apache.org>.
walterddr commented on issue #11065:
URL: https://github.com/apache/pinot/issues/11065#issuecomment-1627529506

   was wondering if we should always use calcite tool to extract tables. b/c the controller query resource is meant for adhoc query and can bear a bit of slowness. but this fix also works


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org


[GitHub] [pinot] walterddr closed issue #11065: [multistage] [bug] unable to resolve table names for COMMA join

Posted by "walterddr (via GitHub)" <gi...@apache.org>.
walterddr closed issue #11065: [multistage] [bug] unable to resolve table names for COMMA join 
URL: https://github.com/apache/pinot/issues/11065


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org