You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Florian Barca <fb...@hortonworks.com> on 2015/01/07 20:25:26 UTC

Review Request 29665: Refactor the OS-dependent Ambari Server Windows components - Part 1.2

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29665/
-----------------------------------------------------------

Review request for Ambari, Artem Baranchuk, Eugene Chekanskiy, Jonathan Hurley, Jayush Luniya, Mahadev Konar, and Nate Cole.


Bugs: AMBARI-8317
    https://issues.apache.org/jira/browse/AMBARI-8317


Repository: ambari


Description
-------

Optimized imports. Moved utility functions away from ambari-service.py. Fixed failing unit test in TestCheckHost.py.

Next in line, the setup will be addressed in 2 steps.


Diffs
-----

  ambari-common/src/main/python/ambari_commons/firewall.py b73cc0cc15cb441b35c0db7ed449ee8f2440134f 
  ambari-common/src/main/python/ambari_commons/inet_utils.py 2a54cb6867aec65d6400451ab12e30c146193cfa 
  ambari-common/src/main/python/ambari_commons/logging_utils.py 9d45fdb73d8ab93c84930b059750e8e02fb5cf7e 
  ambari-common/src/main/python/ambari_commons/os_linux.py 38f3fb9999d19056cca471ad7de64a4b62cb9723 
  ambari-common/src/main/python/ambari_commons/os_utils.py 942a920abf183950e54ebe83fcce92c178f61b70 
  ambari-common/src/main/python/ambari_commons/os_windows.py 7918a2f52fdfb70f4ab5de1a2073da8bec132346 
  ambari-common/src/main/python/resource_management/core/providers/windows/system.py e7a98fc432003b7b818671b8c7fdcfc498f3ad84 
  ambari-server/src/main/python/ambari-server-windows.py 6c4f894de0f6f4abb90b26ebb36a1825d19f9b0f 
  ambari-server/src/main/python/ambari-server.py 89caa2ea4caa726f206bdfbde03ae95a6af0f082 
  ambari-server/src/main/python/ambari_server/dbConfiguration.py daa84abbfe507aafacb4f5e4f81be3864a2ea0e6 
  ambari-server/src/main/python/ambari_server/dbConfiguration_linux.py ce47faec7023050adc451d6df5c9f6cac64ec9be 
  ambari-server/src/main/python/ambari_server/serverConfiguration.py aab116711219f633e3a1a6328d80e9ec68308d15 
  ambari-server/src/main/python/ambari_server/serverConfiguration_linux.py a21437a8372c6fdeef01bc9867dee601a029fc02 
  ambari-server/src/main/python/ambari_server/serverConfiguration_windows.py a0fa508353110afd7a921aa4156f3e2f897d48f8 
  ambari-server/src/main/python/ambari_server/serverSetup.py 37e46f5a480a6186a42a49ce64637da76b133b48 
  ambari-server/src/main/python/ambari_server/serverSetup_linux.py b5436e0c1263e52b1ac9b33a24f02e969c72cd70 
  ambari-server/src/main/python/ambari_server/setupSecurity.py 57a323103d23f3d05450a94d9875694001544337 
  ambari-server/src/main/python/ambari_server/userInput.py 7a35831d0f24889b5dd29da2445c877d0d1844ca 
  ambari-server/src/main/resources/custom_actions/scripts/check_host.py 10c0073267bee014fb9a88bef4de10b655dceb99 
  ambari-server/src/test/python/TestAmbariServer.py 0eae33b2c4a50695cca3fb33fd72065d7f57f4ee 
  ambari-server/src/test/python/custom_actions/TestCheckHost.py cb934c9a953f9a9f41d76f16b346e8bcab2470d1 

Diff: https://reviews.apache.org/r/29665/diff/


Testing
-------

mvn clean test


Thanks,

Florian Barca


Re: Review Request 29665: Refactor the OS-dependent Ambari Server Windows components - Part 1.2

Posted by Jayush Luniya <jl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29665/#review67172
-----------------------------------------------------------


Patch needs to be refreshed.

hw11039:ambari jluniya$ git apply ~/Downloads/AMBARI-8317.5.patch
error: patch failed: ambari-server/src/test/python/TestAmbariServer.py:4666
error: ambari-server/src/test/python/TestAmbariServer.py: patch does not apply

- Jayush Luniya


On Jan. 8, 2015, 1:59 a.m., Florian Barca wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29665/
> -----------------------------------------------------------
> 
> (Updated Jan. 8, 2015, 1:59 a.m.)
> 
> 
> Review request for Ambari, Artem Baranchuk, Eugene Chekanskiy, Jonathan Hurley, Jayush Luniya, Mahadev Konar, and Nate Cole.
> 
> 
> Bugs: AMBARI-8317
>     https://issues.apache.org/jira/browse/AMBARI-8317
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Optimized imports. Moved utility functions away from ambari-service.py. Fixed failing unit test in TestCheckHost.py.
> 
> Next in line, the setup will be addressed in 2 steps.
> 
> 
> Diffs
> -----
> 
>   ambari-common/src/main/python/ambari_commons/firewall.py b73cc0cc15cb441b35c0db7ed449ee8f2440134f 
>   ambari-common/src/main/python/ambari_commons/inet_utils.py 2a54cb6867aec65d6400451ab12e30c146193cfa 
>   ambari-common/src/main/python/ambari_commons/logging_utils.py 9d45fdb73d8ab93c84930b059750e8e02fb5cf7e 
>   ambari-common/src/main/python/ambari_commons/os_linux.py 38f3fb9999d19056cca471ad7de64a4b62cb9723 
>   ambari-common/src/main/python/ambari_commons/os_utils.py 942a920abf183950e54ebe83fcce92c178f61b70 
>   ambari-common/src/main/python/ambari_commons/os_windows.py 7918a2f52fdfb70f4ab5de1a2073da8bec132346 
>   ambari-common/src/main/python/resource_management/core/providers/windows/system.py e7a98fc432003b7b818671b8c7fdcfc498f3ad84 
>   ambari-common/src/main/python/resource_management/libraries/functions/get_unique_id_and_date.py afc82bb4905c806a16a6b67831fdf2fc02ed0875 
>   ambari-server/conf/windows/ambari.properties 3982bb9d6ccde94e7548b121bb4cfff5fabd3977 
>   ambari-server/src/main/python/ambari-server-windows.py 6c4f894de0f6f4abb90b26ebb36a1825d19f9b0f 
>   ambari-server/src/main/python/ambari-server.py 89caa2ea4caa726f206bdfbde03ae95a6af0f082 
>   ambari-server/src/main/python/ambari_server/dbConfiguration_linux.py ce47faec7023050adc451d6df5c9f6cac64ec9be 
>   ambari-server/src/main/python/ambari_server/dbConfiguration_windows.py 647a940ae598e783194e7d0a00fe91f0e080ff48 
>   ambari-server/src/main/python/ambari_server/serverConfiguration.py aab116711219f633e3a1a6328d80e9ec68308d15 
>   ambari-server/src/main/python/ambari_server/serverConfiguration_linux.py a21437a8372c6fdeef01bc9867dee601a029fc02 
>   ambari-server/src/main/python/ambari_server/serverConfiguration_windows.py a0fa508353110afd7a921aa4156f3e2f897d48f8 
>   ambari-server/src/main/python/ambari_server/serverSetup.py 37e46f5a480a6186a42a49ce64637da76b133b48 
>   ambari-server/src/main/python/ambari_server/serverSetup_linux.py b5436e0c1263e52b1ac9b33a24f02e969c72cd70 
>   ambari-server/src/main/python/ambari_server/serverSetup_windows.py a906ef50020e4eb0b9608bf8c1f43681029699ff 
>   ambari-server/src/main/python/ambari_server/setupSecurity.py 57a323103d23f3d05450a94d9875694001544337 
>   ambari-server/src/main/python/ambari_server/userInput.py 7a35831d0f24889b5dd29da2445c877d0d1844ca 
>   ambari-server/src/main/resources/custom_actions/scripts/check_host.py 10c0073267bee014fb9a88bef4de10b655dceb99 
>   ambari-server/src/test/python/TestAmbariServer.py 0eae33b2c4a50695cca3fb33fd72065d7f57f4ee 
>   ambari-server/src/test/python/custom_actions/TestCheckHost.py cb934c9a953f9a9f41d76f16b346e8bcab2470d1 
> 
> Diff: https://reviews.apache.org/r/29665/diff/
> 
> 
> Testing
> -------
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Florian Barca
> 
>


Re: Review Request 29665: Refactor the OS-dependent Ambari Server Windows components - Part 1.2

Posted by Jayush Luniya <jl...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29665/#review67180
-----------------------------------------------------------


On Linux:
ambari-server setup -s does not silently install the default JDK and requires manual input.

[root@c6401 ambari-agent]# ambari-server setup -s
Using python  /usr/bin/python2.6
Setup ambari-server
Checking SELinux...
SELinux status is 'disabled'
Customize user account for ambari-server daemon [y/n] (n)?
Adjusting ambari-server permissions and ownership...
Checking firewall...
Checking JDK...
[1] - Oracle JDK 1.7 + Java Cryptography Extension (JCE) Policy Files 7
[2] - Oracle JDK 1.6 + Java Cryptography Extension (JCE) Policy Files 6
[3] - Custom JDK
==============================================================================
Enter choice (1):^C
Aborting ... Keyboard Interrupt.
[root@c6401 ambari-agent]# ambari-server setup -s
Using python  /usr/bin/python2.6
Setup ambari-server
Checking SELinux...
SELinux status is 'disabled'
Ambari-server daemon is configured to run under user 'root'. Change this setting [y/n] (n)?
Adjusting ambari-server permissions and ownership...
Checking firewall...
Checking JDK...
[1] - Oracle JDK 1.7 + Java Cryptography Extension (JCE) Policy Files 7
[2] - Oracle JDK 1.6 + Java Cryptography Extension (JCE) Policy Files 6
[3] - Custom JDK
==============================================================================
Enter choice (1):

- Jayush Luniya


On Jan. 8, 2015, 8:14 a.m., Florian Barca wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29665/
> -----------------------------------------------------------
> 
> (Updated Jan. 8, 2015, 8:14 a.m.)
> 
> 
> Review request for Ambari, Artem Baranchuk, Eugene Chekanskiy, Jonathan Hurley, Jayush Luniya, Mahadev Konar, and Nate Cole.
> 
> 
> Bugs: AMBARI-8317
>     https://issues.apache.org/jira/browse/AMBARI-8317
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Optimized imports. Moved utility functions away from ambari-service.py. Fixed failing unit test in TestCheckHost.py.
> 
> Next in line, the setup will be addressed in 2 steps.
> 
> 
> Diffs
> -----
> 
>   ambari-common/src/main/python/ambari_commons/firewall.py b73cc0cc15cb441b35c0db7ed449ee8f2440134f 
>   ambari-common/src/main/python/ambari_commons/inet_utils.py 2a54cb6867aec65d6400451ab12e30c146193cfa 
>   ambari-common/src/main/python/ambari_commons/logging_utils.py 9d45fdb73d8ab93c84930b059750e8e02fb5cf7e 
>   ambari-common/src/main/python/ambari_commons/os_linux.py 38f3fb9999d19056cca471ad7de64a4b62cb9723 
>   ambari-common/src/main/python/ambari_commons/os_utils.py 942a920abf183950e54ebe83fcce92c178f61b70 
>   ambari-common/src/main/python/ambari_commons/os_windows.py 7918a2f52fdfb70f4ab5de1a2073da8bec132346 
>   ambari-common/src/main/python/resource_management/core/providers/windows/system.py e7a98fc432003b7b818671b8c7fdcfc498f3ad84 
>   ambari-common/src/main/python/resource_management/libraries/functions/get_unique_id_and_date.py afc82bb4905c806a16a6b67831fdf2fc02ed0875 
>   ambari-server/conf/windows/ambari.properties 3982bb9d6ccde94e7548b121bb4cfff5fabd3977 
>   ambari-server/src/main/python/ambari-server-windows.py 6c4f894de0f6f4abb90b26ebb36a1825d19f9b0f 
>   ambari-server/src/main/python/ambari-server.py af27f5f3be7bf15597fb4545fcd7e393096ca4a7 
>   ambari-server/src/main/python/ambari_server/dbConfiguration_linux.py ce47faec7023050adc451d6df5c9f6cac64ec9be 
>   ambari-server/src/main/python/ambari_server/dbConfiguration_windows.py 647a940ae598e783194e7d0a00fe91f0e080ff48 
>   ambari-server/src/main/python/ambari_server/serverConfiguration.py aab116711219f633e3a1a6328d80e9ec68308d15 
>   ambari-server/src/main/python/ambari_server/serverConfiguration_linux.py a21437a8372c6fdeef01bc9867dee601a029fc02 
>   ambari-server/src/main/python/ambari_server/serverConfiguration_windows.py a0fa508353110afd7a921aa4156f3e2f897d48f8 
>   ambari-server/src/main/python/ambari_server/serverSetup.py 37e46f5a480a6186a42a49ce64637da76b133b48 
>   ambari-server/src/main/python/ambari_server/serverSetup_linux.py b5436e0c1263e52b1ac9b33a24f02e969c72cd70 
>   ambari-server/src/main/python/ambari_server/serverSetup_windows.py a906ef50020e4eb0b9608bf8c1f43681029699ff 
>   ambari-server/src/main/python/ambari_server/setupSecurity.py 57a323103d23f3d05450a94d9875694001544337 
>   ambari-server/src/main/python/ambari_server/userInput.py 7a35831d0f24889b5dd29da2445c877d0d1844ca 
>   ambari-server/src/main/resources/custom_actions/scripts/check_host.py 10c0073267bee014fb9a88bef4de10b655dceb99 
>   ambari-server/src/test/python/TestAmbariServer.py 9290558c6e7f155203c3c9e1ef8acc729779521f 
>   ambari-server/src/test/python/custom_actions/TestCheckHost.py cb934c9a953f9a9f41d76f16b346e8bcab2470d1 
> 
> Diff: https://reviews.apache.org/r/29665/diff/
> 
> 
> Testing
> -------
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Florian Barca
> 
>


Re: Review Request 29665: Refactor the OS-dependent Ambari Server Windows components - Part 1.2

Posted by Florian Barca <fb...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29665/
-----------------------------------------------------------

(Updated Jan. 8, 2015, 8:14 a.m.)


Review request for Ambari, Artem Baranchuk, Eugene Chekanskiy, Jonathan Hurley, Jayush Luniya, Mahadev Konar, and Nate Cole.


Changes
-------

Removing changes pertaining to another patch.


Bugs: AMBARI-8317
    https://issues.apache.org/jira/browse/AMBARI-8317


Repository: ambari


Description
-------

Optimized imports. Moved utility functions away from ambari-service.py. Fixed failing unit test in TestCheckHost.py.

Next in line, the setup will be addressed in 2 steps.


Diffs (updated)
-----

  ambari-common/src/main/python/ambari_commons/firewall.py b73cc0cc15cb441b35c0db7ed449ee8f2440134f 
  ambari-common/src/main/python/ambari_commons/inet_utils.py 2a54cb6867aec65d6400451ab12e30c146193cfa 
  ambari-common/src/main/python/ambari_commons/logging_utils.py 9d45fdb73d8ab93c84930b059750e8e02fb5cf7e 
  ambari-common/src/main/python/ambari_commons/os_linux.py 38f3fb9999d19056cca471ad7de64a4b62cb9723 
  ambari-common/src/main/python/ambari_commons/os_utils.py 942a920abf183950e54ebe83fcce92c178f61b70 
  ambari-common/src/main/python/ambari_commons/os_windows.py 7918a2f52fdfb70f4ab5de1a2073da8bec132346 
  ambari-common/src/main/python/resource_management/core/providers/windows/system.py e7a98fc432003b7b818671b8c7fdcfc498f3ad84 
  ambari-common/src/main/python/resource_management/libraries/functions/get_unique_id_and_date.py afc82bb4905c806a16a6b67831fdf2fc02ed0875 
  ambari-server/conf/windows/ambari.properties 3982bb9d6ccde94e7548b121bb4cfff5fabd3977 
  ambari-server/src/main/python/ambari-server-windows.py 6c4f894de0f6f4abb90b26ebb36a1825d19f9b0f 
  ambari-server/src/main/python/ambari-server.py af27f5f3be7bf15597fb4545fcd7e393096ca4a7 
  ambari-server/src/main/python/ambari_server/dbConfiguration_linux.py ce47faec7023050adc451d6df5c9f6cac64ec9be 
  ambari-server/src/main/python/ambari_server/dbConfiguration_windows.py 647a940ae598e783194e7d0a00fe91f0e080ff48 
  ambari-server/src/main/python/ambari_server/serverConfiguration.py aab116711219f633e3a1a6328d80e9ec68308d15 
  ambari-server/src/main/python/ambari_server/serverConfiguration_linux.py a21437a8372c6fdeef01bc9867dee601a029fc02 
  ambari-server/src/main/python/ambari_server/serverConfiguration_windows.py a0fa508353110afd7a921aa4156f3e2f897d48f8 
  ambari-server/src/main/python/ambari_server/serverSetup.py 37e46f5a480a6186a42a49ce64637da76b133b48 
  ambari-server/src/main/python/ambari_server/serverSetup_linux.py b5436e0c1263e52b1ac9b33a24f02e969c72cd70 
  ambari-server/src/main/python/ambari_server/serverSetup_windows.py a906ef50020e4eb0b9608bf8c1f43681029699ff 
  ambari-server/src/main/python/ambari_server/setupSecurity.py 57a323103d23f3d05450a94d9875694001544337 
  ambari-server/src/main/python/ambari_server/userInput.py 7a35831d0f24889b5dd29da2445c877d0d1844ca 
  ambari-server/src/main/resources/custom_actions/scripts/check_host.py 10c0073267bee014fb9a88bef4de10b655dceb99 
  ambari-server/src/test/python/TestAmbariServer.py 9290558c6e7f155203c3c9e1ef8acc729779521f 
  ambari-server/src/test/python/custom_actions/TestCheckHost.py cb934c9a953f9a9f41d76f16b346e8bcab2470d1 

Diff: https://reviews.apache.org/r/29665/diff/


Testing
-------

mvn clean test


Thanks,

Florian Barca


Re: Review Request 29665: Refactor the OS-dependent Ambari Server Windows components - Part 1.2

Posted by Florian Barca <fb...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29665/
-----------------------------------------------------------

(Updated Jan. 8, 2015, 8:10 a.m.)


Review request for Ambari, Artem Baranchuk, Eugene Chekanskiy, Jonathan Hurley, Jayush Luniya, Mahadev Konar, and Nate Cole.


Changes
-------

Resyncing patch because of the noise in ambari-server.py.


Bugs: AMBARI-8317
    https://issues.apache.org/jira/browse/AMBARI-8317


Repository: ambari


Description
-------

Optimized imports. Moved utility functions away from ambari-service.py. Fixed failing unit test in TestCheckHost.py.

Next in line, the setup will be addressed in 2 steps.


Diffs (updated)
-----

  ambari-common/src/main/python/ambari_commons/firewall.py b73cc0cc15cb441b35c0db7ed449ee8f2440134f 
  ambari-common/src/main/python/ambari_commons/inet_utils.py 2a54cb6867aec65d6400451ab12e30c146193cfa 
  ambari-common/src/main/python/ambari_commons/logging_utils.py 9d45fdb73d8ab93c84930b059750e8e02fb5cf7e 
  ambari-common/src/main/python/ambari_commons/os_linux.py 38f3fb9999d19056cca471ad7de64a4b62cb9723 
  ambari-common/src/main/python/ambari_commons/os_utils.py 942a920abf183950e54ebe83fcce92c178f61b70 
  ambari-common/src/main/python/ambari_commons/os_windows.py 7918a2f52fdfb70f4ab5de1a2073da8bec132346 
  ambari-common/src/main/python/resource_management/core/providers/windows/system.py e7a98fc432003b7b818671b8c7fdcfc498f3ad84 
  ambari-common/src/main/python/resource_management/libraries/functions/get_unique_id_and_date.py afc82bb4905c806a16a6b67831fdf2fc02ed0875 
  ambari-server/conf/windows/ambari.properties 3982bb9d6ccde94e7548b121bb4cfff5fabd3977 
  ambari-server/src/main/python/ambari-server-windows.py 6c4f894de0f6f4abb90b26ebb36a1825d19f9b0f 
  ambari-server/src/main/python/ambari-server.py af27f5f3be7bf15597fb4545fcd7e393096ca4a7 
  ambari-server/src/main/python/ambari_server/dbConfiguration_linux.py ce47faec7023050adc451d6df5c9f6cac64ec9be 
  ambari-server/src/main/python/ambari_server/dbConfiguration_windows.py 647a940ae598e783194e7d0a00fe91f0e080ff48 
  ambari-server/src/main/python/ambari_server/serverConfiguration.py aab116711219f633e3a1a6328d80e9ec68308d15 
  ambari-server/src/main/python/ambari_server/serverConfiguration_linux.py a21437a8372c6fdeef01bc9867dee601a029fc02 
  ambari-server/src/main/python/ambari_server/serverConfiguration_windows.py a0fa508353110afd7a921aa4156f3e2f897d48f8 
  ambari-server/src/main/python/ambari_server/serverSetup.py 37e46f5a480a6186a42a49ce64637da76b133b48 
  ambari-server/src/main/python/ambari_server/serverSetup_linux.py b5436e0c1263e52b1ac9b33a24f02e969c72cd70 
  ambari-server/src/main/python/ambari_server/serverSetup_windows.py a906ef50020e4eb0b9608bf8c1f43681029699ff 
  ambari-server/src/main/python/ambari_server/setupSecurity.py 57a323103d23f3d05450a94d9875694001544337 
  ambari-server/src/main/python/ambari_server/userInput.py 7a35831d0f24889b5dd29da2445c877d0d1844ca 
  ambari-server/src/main/resources/custom_actions/scripts/check_host.py 10c0073267bee014fb9a88bef4de10b655dceb99 
  ambari-server/src/test/python/TestAmbariServer.py 9290558c6e7f155203c3c9e1ef8acc729779521f 
  ambari-server/src/test/python/custom_actions/TestCheckHost.py cb934c9a953f9a9f41d76f16b346e8bcab2470d1 

Diff: https://reviews.apache.org/r/29665/diff/


Testing
-------

mvn clean test


Thanks,

Florian Barca


Re: Review Request 29665: Refactor the OS-dependent Ambari Server Windows components - Part 1.2

Posted by Florian Barca <fb...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29665/
-----------------------------------------------------------

(Updated Jan. 8, 2015, 1:59 a.m.)


Review request for Ambari, Artem Baranchuk, Eugene Chekanskiy, Jonathan Hurley, Jayush Luniya, Mahadev Konar, and Nate Cole.


Bugs: AMBARI-8317
    https://issues.apache.org/jira/browse/AMBARI-8317


Repository: ambari


Description
-------

Optimized imports. Moved utility functions away from ambari-service.py. Fixed failing unit test in TestCheckHost.py.

Next in line, the setup will be addressed in 2 steps.


Diffs (updated)
-----

  ambari-common/src/main/python/ambari_commons/firewall.py b73cc0cc15cb441b35c0db7ed449ee8f2440134f 
  ambari-common/src/main/python/ambari_commons/inet_utils.py 2a54cb6867aec65d6400451ab12e30c146193cfa 
  ambari-common/src/main/python/ambari_commons/logging_utils.py 9d45fdb73d8ab93c84930b059750e8e02fb5cf7e 
  ambari-common/src/main/python/ambari_commons/os_linux.py 38f3fb9999d19056cca471ad7de64a4b62cb9723 
  ambari-common/src/main/python/ambari_commons/os_utils.py 942a920abf183950e54ebe83fcce92c178f61b70 
  ambari-common/src/main/python/ambari_commons/os_windows.py 7918a2f52fdfb70f4ab5de1a2073da8bec132346 
  ambari-common/src/main/python/resource_management/core/providers/windows/system.py e7a98fc432003b7b818671b8c7fdcfc498f3ad84 
  ambari-common/src/main/python/resource_management/libraries/functions/get_unique_id_and_date.py afc82bb4905c806a16a6b67831fdf2fc02ed0875 
  ambari-server/conf/windows/ambari.properties 3982bb9d6ccde94e7548b121bb4cfff5fabd3977 
  ambari-server/src/main/python/ambari-server-windows.py 6c4f894de0f6f4abb90b26ebb36a1825d19f9b0f 
  ambari-server/src/main/python/ambari-server.py 89caa2ea4caa726f206bdfbde03ae95a6af0f082 
  ambari-server/src/main/python/ambari_server/dbConfiguration_linux.py ce47faec7023050adc451d6df5c9f6cac64ec9be 
  ambari-server/src/main/python/ambari_server/dbConfiguration_windows.py 647a940ae598e783194e7d0a00fe91f0e080ff48 
  ambari-server/src/main/python/ambari_server/serverConfiguration.py aab116711219f633e3a1a6328d80e9ec68308d15 
  ambari-server/src/main/python/ambari_server/serverConfiguration_linux.py a21437a8372c6fdeef01bc9867dee601a029fc02 
  ambari-server/src/main/python/ambari_server/serverConfiguration_windows.py a0fa508353110afd7a921aa4156f3e2f897d48f8 
  ambari-server/src/main/python/ambari_server/serverSetup.py 37e46f5a480a6186a42a49ce64637da76b133b48 
  ambari-server/src/main/python/ambari_server/serverSetup_linux.py b5436e0c1263e52b1ac9b33a24f02e969c72cd70 
  ambari-server/src/main/python/ambari_server/serverSetup_windows.py a906ef50020e4eb0b9608bf8c1f43681029699ff 
  ambari-server/src/main/python/ambari_server/setupSecurity.py 57a323103d23f3d05450a94d9875694001544337 
  ambari-server/src/main/python/ambari_server/userInput.py 7a35831d0f24889b5dd29da2445c877d0d1844ca 
  ambari-server/src/main/resources/custom_actions/scripts/check_host.py 10c0073267bee014fb9a88bef4de10b655dceb99 
  ambari-server/src/test/python/TestAmbariServer.py 0eae33b2c4a50695cca3fb33fd72065d7f57f4ee 
  ambari-server/src/test/python/custom_actions/TestCheckHost.py cb934c9a953f9a9f41d76f16b346e8bcab2470d1 

Diff: https://reviews.apache.org/r/29665/diff/


Testing
-------

mvn clean test


Thanks,

Florian Barca