You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by haohui <gi...@git.apache.org> on 2017/02/20 21:16:10 UTC
[GitHub] flink pull request #3370: [FLINK-5710] Add ProcTime() function to indicate S...
GitHub user haohui opened a pull request:
https://github.com/apache/flink/pull/3370
[FLINK-5710] Add ProcTime() function to indicate StreamSQL.
This is the commit we used internally -- There is no unit tests associated with this PR. It simply serves as a reference point for #3302.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/haohui/flink FLINK-5710
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/3370.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3370
----
commit 7aaa5008c7b49ce48e01d40dc4a04a6211eaf79b
Author: Haohui Mai <wh...@apache.org>
Date: 2017-02-20T21:13:58Z
[FLINK-5710] Add ProcTime() function to indicate StreamSQL.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #3370: [FLINK-5710] Add ProcTime() function to indicate S...
Posted by haohui <gi...@git.apache.org>.
GitHub user haohui reopened a pull request:
https://github.com/apache/flink/pull/3370
[FLINK-5710] Add ProcTime() function to indicate StreamSQL.
This is the commit we used internally -- There is no unit tests associated with this PR. It simply serves as a reference point for #3302.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/haohui/flink FLINK-5710
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/3370.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3370
----
commit e68a7ad22cad926dac2f211fa3bd56ef481c4036
Author: Haohui Mai <wh...@apache.org>
Date: 2017-02-23T21:51:45Z
[FLINK-5710] Add ProcTime() function to indicate StreamSQL.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #3370: [FLINK-5710] Add ProcTime() function to indicate S...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/3370
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3370: [FLINK-5710] Add ProcTime() function to indicate StreamSQ...
Posted by huawei-flink <gi...@git.apache.org>.
Github user huawei-flink commented on the issue:
https://github.com/apache/flink/pull/3370
@haohui thanks for the contribution. I merged your code, I will push it later today.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #3370: [FLINK-5710] Add ProcTime() function to indicate S...
Posted by fhueske <gi...@git.apache.org>.
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/3370#discussion_r102925889
--- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/api/scala/stream/sql/WindowAggregateTest.scala ---
@@ -94,6 +94,27 @@ class WindowAggregateTest extends TableTestBase {
streamUtil.verifySql(sql, expected)
}
+ @Test
+ def testProcessingTime() = {
+ val sql = "SELECT COUNT(*) FROM MyTable GROUP BY FLOOR(proc() TO HOUR)"
--- End diff --
`proc()` -> `proctime()` ;-)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #3370: [FLINK-5710] Add ProcTime() function to indicate S...
Posted by haohui <gi...@git.apache.org>.
Github user haohui closed the pull request at:
https://github.com/apache/flink/pull/3370
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3370: [FLINK-5710] Add ProcTime() function to indicate StreamSQ...
Posted by fhueske <gi...@git.apache.org>.
Github user fhueske commented on the issue:
https://github.com/apache/flink/pull/3370
Thanks @haohui! The only thing missing would in fact be a test. IMO, extending `WindowAggregateTest` by copying the methods and adapting them to `proctime` would be sufficient.
Let's see if #3302 is continued or not. If not, I'd like to add this PR.
Thanks, Fabian
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #3370: [FLINK-5710] Add ProcTime() function to indicate StreamSQ...
Posted by fhueske <gi...@git.apache.org>.
Github user fhueske commented on the issue:
https://github.com/apache/flink/pull/3370
Thanks for the update @haohui!
PR looks good.
Will merge it later.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---