You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/05/19 05:57:37 UTC

[GitHub] [kafka] zhaohaidao commented on a change in pull request #10700: KAFKA-12789: Remove Stale comments for meta response handling logic

zhaohaidao commented on a change in pull request #10700:
URL: https://github.com/apache/kafka/pull/10700#discussion_r634933714



##########
File path: clients/src/main/java/org/apache/kafka/clients/NetworkClient.java
##########
@@ -1089,8 +1089,8 @@ public void handleSuccessfulResponse(RequestHeader requestHeader, long now, Meta
             if (!errors.isEmpty())
                 log.warn("Error while fetching metadata with correlation id {} : {}", requestHeader.correlationId(), errors);
 
-            // Don't update the cluster if there are no valid nodes...the topic we want may still be in the process of being
-            // created which means we will get errors and no nodes until it exists
+            // Don't update the cluster if there are no valid nodes which may happened during the startup phase of

Review comment:
       make sense




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org