[GitHub] ijokarumawak commented on a change in pull request #3248: NIFI-3611: Added ability to set Transaction Isolation Level on Database connections for QueryDatabaseTable processor

[GitBox <gi...@apache.org>]

ijokarumawak commented on a change in pull request #3248: NIFI-3611: Added ability to set Transaction Isolation Level on Database connections for QueryDatabaseTable processor
URL: https://github.com/apache/nifi/pull/3248#discussion_r246239963
 
 

 ##########
 File path: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/AbstractQueryDatabaseTable.java
 ##########
 @@ -112,6 +118,15 @@
             .expressionLanguageSupported(ExpressionLanguageScope.VARIABLE_REGISTRY)
             .build();
 
+    public static final PropertyDescriptor TRANS_ISOLATION_LEVEL = new PropertyDescriptor.Builder()
+            .name("Transaction Isolation Level")
+            .displayName("Transaction Isolation Level")
+            .description("This setting will set the transaction isolation level for the database connection for drivers that support this setting")
+            .defaultValue(TRANSACTION_READ_UNCOMMITTED)
+            .required(true)
 
 Review comment:
   Introducing new property with default behavior changes all existing flows. 
   
   To keep the original behavior and to avoid any negative impact especially for implementations not supporting isolation level, I'd prefer this property to be an optional (not required).
   Then, if not specified, skip calling `con.setTransactionIsolation(TransIsolationLevelInt);`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services