You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "alamb (via GitHub)" <gi...@apache.org> on 2024/01/09 21:22:22 UTC

[PR] Remove unused array_expression.rs and `SUPPORTED_ARRAY_TYPES` [arrow-datafusion]

alamb opened a new pull request, #8807:
URL: https://github.com/apache/arrow-datafusion/pull/8807

   ## Which issue does this PR close?
   
   N/A
   
   ## Rationale for this change
   
   While reviewing https://github.com/apache/arrow-datafusion/pull/8744 I found this file was totally unused and somewhat confusing as it implies there are a limited set of types supported as List values, which is no longer the case
   
   ## What changes are included in this PR?
   
   remove unused code
   
   ## Are these changes tested?
   By existing tests
   
   <!--
   We typically require tests for all PRs in order to:
   1. Prevent the code from being accidentally broken by subsequent changes
   2. Serve as another way to document the expected behavior of the code
   
   If tests are not included in your PR, please explain why (for example, are they covered by existing tests)?
   -->
   
   ## Are there any user-facing changes?
   This module and constants were pub, so strictly speaking this is an API change, but I don't think they were adding any value and can be easily replaced in client code if so desired


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Remove unused array_expression.rs and `SUPPORTED_ARRAY_TYPES` [arrow-datafusion]

Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb merged PR #8807:
URL: https://github.com/apache/arrow-datafusion/pull/8807


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org