You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lens.apache.org by Sushil Mohanty <su...@gmail.com> on 2014/12/22 12:46:26 UTC
Review Request 29305: LENS-141 : Exclude join condition as filter in
inner fact query
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29305/
-----------------------------------------------------------
Review request for lens, Amareshwari Sriramadasu and Jaideep dhok.
Bugs: LENS-141
https://issues.apache.org/jira/browse/LENS-141
Repository: lens
Description
-------
Currently join conditions are getting added as filters in fact subquery. Fixed by excluding them from fact subquery and fact filter push down.
Diffs
-----
lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/ColumnarSQLRewriter.java b05d87f
lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestColumnarSQLRewriter.java 6ca0d2d
Diff: https://reviews.apache.org/r/29305/diff/
Testing
-------
Tested the fix and added unit test. All tests are passing.
Thanks,
Sushil Mohanty
Re: Review Request 29305: LENS-141 : Exclude join condition as filter
in inner fact query
Posted by Sushil Mohanty <su...@gmail.com>.
> On Dec. 23, 2014, 5:57 a.m., Amareshwari Sriramadasu wrote:
> > lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/ColumnarSQLRewriter.java, line 425
> > <https://reviews.apache.org/r/29305/diff/1/?file=798450#file798450line425>
> >
> > Can you add a comment on whats happening here? Why are checking for somany dots?
Updated diff with comments.
- Sushil
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29305/#review65869
-----------------------------------------------------------
On Dec. 23, 2014, 6:14 a.m., Sushil Mohanty wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29305/
> -----------------------------------------------------------
>
> (Updated Dec. 23, 2014, 6:14 a.m.)
>
>
> Review request for lens, Amareshwari Sriramadasu and Jaideep dhok.
>
>
> Bugs: LENS-141
> https://issues.apache.org/jira/browse/LENS-141
>
>
> Repository: lens
>
>
> Description
> -------
>
> Currently join conditions are getting added as filters in fact subquery. Fixed by excluding them from fact subquery and fact filter push down.
>
>
> Diffs
> -----
>
> lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/ColumnarSQLRewriter.java b05d87f
> lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestColumnarSQLRewriter.java 6ca0d2d
>
> Diff: https://reviews.apache.org/r/29305/diff/
>
>
> Testing
> -------
>
> Tested the fix and added unit test. All tests are passing.
>
>
> Thanks,
>
> Sushil Mohanty
>
>
Re: Review Request 29305: LENS-141 : Exclude join condition as filter
in inner fact query
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29305/#review65869
-----------------------------------------------------------
lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/ColumnarSQLRewriter.java
<https://reviews.apache.org/r/29305/#comment109117>
Can you add a comment on whats happening here? Why are checking for somany dots?
- Amareshwari Sriramadasu
On Dec. 22, 2014, 11:46 a.m., Sushil Mohanty wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29305/
> -----------------------------------------------------------
>
> (Updated Dec. 22, 2014, 11:46 a.m.)
>
>
> Review request for lens, Amareshwari Sriramadasu and Jaideep dhok.
>
>
> Bugs: LENS-141
> https://issues.apache.org/jira/browse/LENS-141
>
>
> Repository: lens
>
>
> Description
> -------
>
> Currently join conditions are getting added as filters in fact subquery. Fixed by excluding them from fact subquery and fact filter push down.
>
>
> Diffs
> -----
>
> lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/ColumnarSQLRewriter.java b05d87f
> lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestColumnarSQLRewriter.java 6ca0d2d
>
> Diff: https://reviews.apache.org/r/29305/diff/
>
>
> Testing
> -------
>
> Tested the fix and added unit test. All tests are passing.
>
>
> Thanks,
>
> Sushil Mohanty
>
>
Re: Review Request 29305: LENS-141 : Exclude join condition as filter
in inner fact query
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29305/#review65878
-----------------------------------------------------------
Ship it!
Ship It!
- Amareshwari Sriramadasu
On Dec. 23, 2014, 6:14 a.m., Sushil Mohanty wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29305/
> -----------------------------------------------------------
>
> (Updated Dec. 23, 2014, 6:14 a.m.)
>
>
> Review request for lens, Amareshwari Sriramadasu and Jaideep dhok.
>
>
> Bugs: LENS-141
> https://issues.apache.org/jira/browse/LENS-141
>
>
> Repository: lens
>
>
> Description
> -------
>
> Currently join conditions are getting added as filters in fact subquery. Fixed by excluding them from fact subquery and fact filter push down.
>
>
> Diffs
> -----
>
> lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/ColumnarSQLRewriter.java b05d87f
> lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestColumnarSQLRewriter.java 6ca0d2d
>
> Diff: https://reviews.apache.org/r/29305/diff/
>
>
> Testing
> -------
>
> Tested the fix and added unit test. All tests are passing.
>
>
> Thanks,
>
> Sushil Mohanty
>
>
Re: Review Request 29305: LENS-141 : Exclude join condition as filter
in inner fact query
Posted by Sushil Mohanty <su...@gmail.com>.
> On Dec. 23, 2014, 7 a.m., Amareshwari Sriramadasu wrote:
> > lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestColumnarSQLRewriter.java, line 756
> > <https://reviews.apache.org/r/29305/diff/2/?file=799282#file799282line756>
> >
> > We are not pushing dim2 id lookups into subquery. Is that ok?
Yes its okay.
- Sushil
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29305/#review65873
-----------------------------------------------------------
On Dec. 23, 2014, 6:14 a.m., Sushil Mohanty wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29305/
> -----------------------------------------------------------
>
> (Updated Dec. 23, 2014, 6:14 a.m.)
>
>
> Review request for lens, Amareshwari Sriramadasu and Jaideep dhok.
>
>
> Bugs: LENS-141
> https://issues.apache.org/jira/browse/LENS-141
>
>
> Repository: lens
>
>
> Description
> -------
>
> Currently join conditions are getting added as filters in fact subquery. Fixed by excluding them from fact subquery and fact filter push down.
>
>
> Diffs
> -----
>
> lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/ColumnarSQLRewriter.java b05d87f
> lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestColumnarSQLRewriter.java 6ca0d2d
>
> Diff: https://reviews.apache.org/r/29305/diff/
>
>
> Testing
> -------
>
> Tested the fix and added unit test. All tests are passing.
>
>
> Thanks,
>
> Sushil Mohanty
>
>
Re: Review Request 29305: LENS-141 : Exclude join condition as filter
in inner fact query
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29305/#review65873
-----------------------------------------------------------
lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestColumnarSQLRewriter.java
<https://reviews.apache.org/r/29305/#comment109126>
We are not pushing dim2 id lookups into subquery. Is that ok?
- Amareshwari Sriramadasu
On Dec. 23, 2014, 6:14 a.m., Sushil Mohanty wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29305/
> -----------------------------------------------------------
>
> (Updated Dec. 23, 2014, 6:14 a.m.)
>
>
> Review request for lens, Amareshwari Sriramadasu and Jaideep dhok.
>
>
> Bugs: LENS-141
> https://issues.apache.org/jira/browse/LENS-141
>
>
> Repository: lens
>
>
> Description
> -------
>
> Currently join conditions are getting added as filters in fact subquery. Fixed by excluding them from fact subquery and fact filter push down.
>
>
> Diffs
> -----
>
> lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/ColumnarSQLRewriter.java b05d87f
> lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestColumnarSQLRewriter.java 6ca0d2d
>
> Diff: https://reviews.apache.org/r/29305/diff/
>
>
> Testing
> -------
>
> Tested the fix and added unit test. All tests are passing.
>
>
> Thanks,
>
> Sushil Mohanty
>
>
Re: Review Request 29305: LENS-141 : Exclude join condition as filter
in inner fact query
Posted by Sushil Mohanty <su...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29305/
-----------------------------------------------------------
(Updated Dec. 23, 2014, 6:14 a.m.)
Review request for lens, Amareshwari Sriramadasu and Jaideep dhok.
Changes
-------
Added comments.
Bugs: LENS-141
https://issues.apache.org/jira/browse/LENS-141
Repository: lens
Description
-------
Currently join conditions are getting added as filters in fact subquery. Fixed by excluding them from fact subquery and fact filter push down.
Diffs (updated)
-----
lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/ColumnarSQLRewriter.java b05d87f
lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestColumnarSQLRewriter.java 6ca0d2d
Diff: https://reviews.apache.org/r/29305/diff/
Testing
-------
Tested the fix and added unit test. All tests are passing.
Thanks,
Sushil Mohanty