[jira] [Commented] (YARN-6492) Generate queue metrics for each partition

["Naganarasimha G R (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/YARN-6492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16331738#comment-16331738 ] 

Naganarasimha G R commented on YARN-6492:
-----------------------------------------

Hi [~manirajv06@gmail.com], As mostly the discussions were happening offline i thought we should share our view points here for the broader community to view how we want to have it.

Thanks for your latest patch, and here are my comments :

Major comments :

Though the way we want to get the metrics output is correct i am not happy to have another class which is just a copy of QueueMetrics and nominal changes to capture the Partition information. I was thinking PartitionQueueMetrics is just a holder for QueueMetrics and Queue metrics having the changes to incorporate the Partition information too.
I think the assumption that queue metrics is created only during the creation of constructor is wrong as partition can be added dynamically. hence if the given queuemetrics objects are not present for a given partition we need to create it.
Minor Comments :

Lets have the PartitionMetrics => PartitionQueueMetrics 
Do we really require "enablePartitionMetrics" in the QueueMatrix ? IMO its sufficient to have "string partition" class member and by having default value as "DEFAULT". May be we can further discuss on it.
Once the approach gets finalized will review more...

> Generate queue metrics for each partition
> -----------------------------------------
>
>                 Key: YARN-6492
>                 URL: https://issues.apache.org/jira/browse/YARN-6492
>             Project: Hadoop YARN
>          Issue Type: Improvement
>          Components: capacity scheduler
>            Reporter: Jonathan Hung
>            Assignee: Manikandan R
>            Priority: Major
>         Attachments: YARN-6492.001.patch, YARN-6492.002.patch, partition_metrics.txt
>
>
> We are interested in having queue metrics for all partitions. Right now each queue has one QueueMetrics object which captures metrics either in default partition or across all partitions. (After YARN-6467 it will be in default partition)
> But having the partition metrics would be very useful.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: yarn-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: yarn-issues-help@hadoop.apache.org