You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2020/10/02 00:21:17 UTC

[GitHub] [hudi] bschell commented on a change in pull request #2129: [HUDI-1302] Add support for timestamp field in HiveSync

bschell commented on a change in pull request #2129:
URL: https://github.com/apache/hudi/pull/2129#discussion_r498571592



##########
File path: hudi-sync/hudi-dla-sync/src/main/java/org/apache/hudi/dla/DLASyncConfig.java
##########
@@ -68,6 +68,9 @@
   @Parameter(names = {"--help", "-h"}, help = true)
   public Boolean help = false;
 
+  @Parameter(names = {"--support-timestamp"}, description = "If true, converts int64(timestamp_micros) to timestamp type")
+  public Boolean supportTimestamp = false;

Review comment:
       I think we need to add this option into DataSourceOptions, DataSourceUtils, and HoodieSparkSqlWriter
   
   something like?
   "hoodie.datasource.hive_sync.support_timestamp"
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org