You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/09/19 07:26:35 UTC
[GitHub] [airflow] potiuk opened a new issue, #26474: Do not mount DAG folder to scheduler in "standalone dag processor" mode in Chart
potiuk opened a new issue, #26474:
URL: https://github.com/apache/airflow/issues/26474
### Description
I believe with "standalone dag processor" completed in 2.4, Scheduler should not need a DAG folder to be mounted?
Should we disable the moubt it in the helm chart in "standalone dag processor" mode similarly as we do for webserver in all cases?
### Use case/motivation
Additional layer of security of the Scheduler - which would not have to have access to DAG code .
### Related issues
Dicussed in https://github.com/apache/airflow/issues/26008#issuecomment-1248947543
### Are you willing to submit a PR?
- [X] Yes I am willing to submit a PR!
### Code of Conduct
- [X] I agree to follow this project's [Code of Conduct](https://github.com/apache/airflow/blob/main/CODE_OF_CONDUCT.md)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on issue #26474: Do not mount DAG folder to scheduler in "standalone dag processor" mode in Chart
Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #26474:
URL: https://github.com/apache/airflow/issues/26474#issuecomment-1251059532
Nope. you did not. It's I who overlooked it. :facepalm:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mhenc commented on issue #26474: Do not mount DAG folder to scheduler in "standalone dag processor" mode in Chart
Posted by GitBox <gi...@apache.org>.
mhenc commented on issue #26474:
URL: https://github.com/apache/airflow/issues/26474#issuecomment-1250706059
No, I hope not - that was the whole idea of DagProcessor separation - to make Scheduler "trusted component" that runs without any iteracation with user code.
If there is still any dependency required, then we should fix it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk closed issue #26474: Do not mount DAG folder to scheduler in "standalone dag processor" mode in Chart
Posted by GitBox <gi...@apache.org>.
potiuk closed issue #26474: Do not mount DAG folder to scheduler in "standalone dag processor" mode in Chart
URL: https://github.com/apache/airflow/issues/26474
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on issue #26474: Do not mount DAG folder to scheduler in "standalone dag processor" mode in Chart
Posted by GitBox <gi...@apache.org>.
potiuk commented on issue #26474:
URL: https://github.com/apache/airflow/issues/26474#issuecomment-1250664467
cc: @jedcunningham @ashb @mhenc @ephraimbuddy -> do you think of any reason why Scheduler in standalone dag processor mode would need DAG code? I can't think of any, but maybe I forgot about somethig so I raised the issue (and happy to implement it before we release the new chart) - but I wanted to get your feedback on it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] jedcunningham commented on issue #26474: Do not mount DAG folder to scheduler in "standalone dag processor" mode in Chart
Posted by GitBox <gi...@apache.org>.
jedcunningham commented on issue #26474:
URL: https://github.com/apache/airflow/issues/26474#issuecomment-1251044672
This was already done in #23711, or am I overlooking something?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org