You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/01/13 20:01:37 UTC

[GitHub] [airflow] dstandish edited a comment on issue #6850: [AIRFLOW-6296] add ODBC hook & deprecate pymssql

dstandish edited a comment on issue #6850: [AIRFLOW-6296] add ODBC hook & deprecate pymssql
URL: https://github.com/apache/airflow/pull/6850#issuecomment-573843253
 
 
   thanks @vamega 
   
   perhaps you could indicate your approval with an official review?
   
   @baolsen @zhongjiajie any concerns remaining?
   
   @zhongjiajie i know you initially had reservations, preferring to just replace pymssql immediately. do you feel better about this PR now that it is a generic ODBC hook which can also be used for MSSQL?  I like where we're at now because it is clearly a distinct hook that has wider use than MSSQL alone.  and introducing it alongside during a deprecation period gives users time to migrate should they choose to.  and it avoids a breaking change.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services