[GitHub] [kyuubi] ulysses-you commented on a diff in pull request #4155: Reduce the application info call for batch

[GitBox <gi...@apache.org>]

ulysses-you commented on code in PR #4155:
URL: https://github.com/apache/kyuubi/pull/4155#discussion_r1068839823


##########
kyuubi-server/src/main/scala/org/apache/kyuubi/server/api/v1/BatchesResource.scala:
##########
@@ -68,7 +68,7 @@ private[v1] class BatchesResource extends ApiRequestContext with Logging {
   private def buildBatch(session: KyuubiBatchSessionImpl): Batch = {
     val batchOp = session.batchJobSubmissionOp
     val batchOpStatus = batchOp.getStatus
-    val batchAppStatus = batchOp.currentApplicationInfo
+    val batchAppStatus = batchOp.getApplicationInfo

Review Comment:
   I'm not sure it can alway return a correct info, shall we make this method as `getOrFetchCurrentApplicationInfo` ? Then we in that method, we can call `currentApplicationInfo` if applicationInfo is empty.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org