You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "alamb (via GitHub)" <gi...@apache.org> on 2023/03/09 15:34:44 UTC

[GitHub] [arrow-rs] alamb commented on a diff in pull request #3828: Move prettyprint to arrow-cast

alamb commented on code in PR #3828:
URL: https://github.com/apache/arrow-rs/pull/3828#discussion_r1131204676


##########
arrow/Cargo.toml:
##########
@@ -60,7 +60,6 @@ arrow-select = { version = "34.0.0", path = "../arrow-select" }
 arrow-string = { version = "34.0.0", path = "../arrow-string" }
 
 rand = { version = "0.8", default-features = false, features = ["std", "std_rng"], optional = true }
-comfy-table = { version = "6.0", optional = true, default-features = false }

Review Comment:
   🎉 



##########
arrow/src/util/mod.rs:
##########
@@ -25,7 +25,7 @@ pub mod bench_util;
 #[cfg(feature = "test_utils")]
 pub mod data_gen;
 #[cfg(feature = "prettyprint")]
-pub mod pretty;
+pub use arrow_cast::pretty;

Review Comment:
   👍  for being backwards compatible



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org