You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "alex35736 (via GitHub)" <gi...@apache.org> on 2024/03/24 14:37:10 UTC
[PR] [SPARK-47503][SQL] Make makeDotNode escape graph node name always (ba… [spark]
alex35736 opened a new pull request, #45684:
URL: https://github.com/apache/spark/pull/45684
What changes were proposed in this pull request?
(backport of [SPARK-47503] 15ea9de88b8d8a87daa6abbc8e80c439e2d38e03)
To prevent corruption of dot file a node name should be escaped even if there is no metrics to display
Why are the changes needed?
This pr fixes a bug in spark history server which fails to display query for cached JDBC relation named in quotes.
Does this PR introduce any user-facing change?
No.
How was this patch tested?
Unit test.
Was this patch authored or co-authored using generative AI tooling?
No.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-47503][SQL][3.5] Make makeDotNode escape graph node name always [spark]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #45684:
URL: https://github.com/apache/spark/pull/45684#issuecomment-2016965478
Merged to `branch-3.5`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-47503][SQL][3.5] Make makeDotNode escape graph node name always [spark]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #45684:
URL: https://github.com/apache/spark/pull/45684#issuecomment-2016965873
Thank you, @alex35736 . This is merged correctly with your email. Could you make one more PR to `branch-3.4`, too?
```
Authored-by: alexey <se...@gmail.com>
Signed-off-by: Dongjoon Hyun <dh...@apple.com>
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-47503][SQL][3.5] Make makeDotNode escape graph node name always [spark]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun closed pull request #45684: [SPARK-47503][SQL][3.5] Make makeDotNode escape graph node name always
URL: https://github.com/apache/spark/pull/45684
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org