[GitHub] [cassandra] djanand commented on a change in pull request #1422: CASSANDRA-16916 modify alter statements with IF EXISTS and IF NOT EXISTS

[GitBox <gi...@apache.org>]

djanand commented on a change in pull request #1422:
URL: https://github.com/apache/cassandra/pull/1422#discussion_r828800595



##########
File path: src/java/org/apache/cassandra/cql3/statements/schema/AlterTypeStatement.java
##########
@@ -205,6 +223,9 @@ UserType apply(KeyspaceMetadata keyspace, UserType userType)
         }
 
         private final UTName name;
+        private final boolean ifExists;

Review comment:
       hmmm, I had that earlier, but it seems that the consensus from an earlier PR ( that I made on top of 4.0 branch unfortunately) was to convert them to ifExists. The understanding was that the meaning of the variable can be infered from context. Here are the previous review comments.
   
   https://github.com/apache/cassandra/pull/1319#discussion_r754352408
   https://github.com/apache/cassandra/pull/1319#discussion_r755154353
   https://github.com/apache/cassandra/pull/1319#discussion_r755155148
   https://github.com/apache/cassandra/pull/1319#discussion_r754354472
   https://github.com/apache/cassandra/pull/1319#discussion_r754355124
   https://github.com/apache/cassandra/pull/1319#discussion_r754353396
   https://github.com/apache/cassandra/pull/1319#discussion_r754352775




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org