[GitHub] sijie commented on a change in pull request #1179: Avoid printing exception stack trace on lookup connection failures

[GitBox <gi...@apache.org>]

sijie commented on a change in pull request #1179: Avoid printing exception stack trace on lookup connection failures
URL: https://github.com/apache/incubator-pulsar/pull/1179#discussion_r166080246
 
 

 ##########
 File path: pulsar-client/src/main/java/org/apache/pulsar/client/impl/BinaryProtoLookupService.java
 ##########
 @@ -131,7 +132,7 @@ public BinaryProtoLookupService(PulsarClientImpl client, String serviceUrl, bool
             }).exceptionally((sendException) -> {
                 // lookup failed
                 log.warn("[{}] failed to send lookup request : {}", destination.toString(), sendException.getMessage(),
 
 Review comment:
   better to omitting exception in the log message, rather than using `null`. because `null` is a bit confusing for users.
   
   ```
   if (sendException instanceof ClosedChannelException) {
       log.warn("[{}] failed to send lookup request.", destination.toString(), sendException.getMessage());
   }

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services