You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@celeborn.apache.org by "turboFei (via GitHub)" <gi...@apache.org> on 2024/09/21 00:03:08 UTC

[PR] using string [celeborn]

turboFei opened a new pull request, #2753:
URL: https://github.com/apache/celeborn/pull/2753

   <!--
   Thanks for sending a pull request!  Here are some tips for you:
     - Make sure the PR title start w/ a JIRA ticket, e.g. '[CELEBORN-XXXX] Your PR title ...'.
     - Be sure to keep the PR description updated to reflect all changes.
     - Please write your PR title to summarize what this PR proposes.
     - If possible, provide a concise example to reproduce the issue for a faster review.
   -->
   
   ### What changes were proposed in this pull request?
   
   
   
   ### Why are the changes needed?
   
   
   
   ### Does this PR introduce _any_ user-facing change?
   
   
   
   ### How was this patch tested?
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [CELEBORN-1607] Fix openapi-client send worker event issue [celeborn]

Posted by "turboFei (via GitHub)" <gi...@apache.org>.
turboFei commented on code in PR #2753:
URL: https://github.com/apache/celeborn/pull/2753#discussion_r1769373344


##########
cli/src/test/scala/org/apache/celeborn/cli/TestCelebornCliCommands.scala:
##########
@@ -218,7 +218,7 @@ class TestCelebornCliCommands extends CelebornFunSuite with MiniClusterFeature {
   test("master --send-worker-event") {
     val args = prepareMasterArgs() ++ Array(
       "--send-worker-event",
-      "RECOMMISSION",
+      "Recommission",

Review Comment:
   We can follow up in other PR.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [CELEBORN-1607] Fix openapi-client send worker event issue [celeborn]

Posted by "turboFei (via GitHub)" <gi...@apache.org>.
turboFei commented on PR #2753:
URL: https://github.com/apache/celeborn/pull/2753#issuecomment-2364955384

   close this one and prefer #2754


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [CELEBORN-1607] Fix openapi-client send worker event issue [celeborn]

Posted by "turboFei (via GitHub)" <gi...@apache.org>.
turboFei commented on PR #2753:
URL: https://github.com/apache/celeborn/pull/2753#issuecomment-2364783324

   cc @pan3793 @SteNicholas @akpatnam25 @mridulm 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [CELEBORN-1607] Fix openapi-client send worker event issue [celeborn]

Posted by "turboFei (via GitHub)" <gi...@apache.org>.
turboFei commented on PR #2753:
URL: https://github.com/apache/celeborn/pull/2753#issuecomment-2364788500

   > For EventTypeEnum, because its value is case sensitive, so we meet this issue.
   
   
   As mentioned in the PR description, if it is not case sensitive, it should be fine:
   
   Solution 2:
   
   
   https://github.com/apache/celeborn/pull/2754
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [CELEBORN-1607] Fix openapi-client send worker event issue [celeborn]

Posted by "turboFei (via GitHub)" <gi...@apache.org>.
turboFei commented on code in PR #2753:
URL: https://github.com/apache/celeborn/pull/2753#discussion_r1769373292


##########
cli/src/test/scala/org/apache/celeborn/cli/TestCelebornCliCommands.scala:
##########
@@ -218,7 +218,7 @@ class TestCelebornCliCommands extends CelebornFunSuite with MiniClusterFeature {
   test("master --send-worker-event") {
     val args = prepareMasterArgs() ++ Array(
       "--send-worker-event",
-      "RECOMMISSION",
+      "Recommission",

Review Comment:
   It is better to support case insensitive event type.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [CELEBORN-1607] Fix openapi-client send worker event issue [celeborn]

Posted by "turboFei (via GitHub)" <gi...@apache.org>.
turboFei closed pull request #2753: [CELEBORN-1607] Fix openapi-client send worker event issue
URL: https://github.com/apache/celeborn/pull/2753


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@celeborn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org