You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maven.apache.org by ol...@apache.org on 2013/10/22 05:04:42 UTC

[4/9] git commit: Removed unnecessary private method

Removed unnecessary private method


Project: http://git-wip-us.apache.org/repos/asf/maven-wagon/repo
Commit: http://git-wip-us.apache.org/repos/asf/maven-wagon/commit/dc8f00ec
Tree: http://git-wip-us.apache.org/repos/asf/maven-wagon/tree/dc8f00ec
Diff: http://git-wip-us.apache.org/repos/asf/maven-wagon/diff/dc8f00ec

Branch: refs/heads/master
Commit: dc8f00ec94c2f717b3230589564943f0b69c7a0c
Parents: 9a1b729
Author: Oleg Kalnichevski <ol...@apache.org>
Authored: Tue Sep 24 14:34:57 2013 +0200
Committer: Oleg Kalnichevski <ol...@apache.org>
Committed: Tue Sep 24 14:34:57 2013 +0200

----------------------------------------------------------------------
 .../providers/http/HttpMethodConfiguration.java | 99 --------------------
 1 file changed, 99 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/maven-wagon/blob/dc8f00ec/wagon-providers/wagon-http/src/main/java/org/apache/maven/wagon/providers/http/HttpMethodConfiguration.java
----------------------------------------------------------------------
diff --git a/wagon-providers/wagon-http/src/main/java/org/apache/maven/wagon/providers/http/HttpMethodConfiguration.java b/wagon-providers/wagon-http/src/main/java/org/apache/maven/wagon/providers/http/HttpMethodConfiguration.java
index 3be9837..1d10c49 100755
--- a/wagon-providers/wagon-http/src/main/java/org/apache/maven/wagon/providers/http/HttpMethodConfiguration.java
+++ b/wagon-providers/wagon-http/src/main/java/org/apache/maven/wagon/providers/http/HttpMethodConfiguration.java
@@ -268,105 +268,6 @@ public class HttpMethodConfiguration
         return this;
     }
 
-    private void fillParams( HttpParams p )
-    {
-        if ( !hasParams() )
-        {
-            return;
-        }
-
-        if ( connectionTimeout > 0 )
-        {
-            p.setParameter( CoreConnectionPNames.CONNECTION_TIMEOUT, connectionTimeout );
-        }
-
-        if ( readTimeout > 0 )
-        {
-            p.setParameter( CoreConnectionPNames.SO_TIMEOUT, readTimeout );
-        }
-
-        if ( params != null )
-        {
-            Pattern coercePattern = Pattern.compile( COERCE_PATTERN );
-
-            for ( Iterator<?> it = params.entrySet().iterator(); it.hasNext(); )
-            {
-                Map.Entry<String, String> entry = (Map.Entry) it.next();
-
-                String key = entry.getKey();
-                String value = entry.getValue();
-
-                Matcher matcher = coercePattern.matcher( value );
-                if ( matcher.matches() )
-                {
-                    char type = matcher.group( 1 ).charAt( 0 );
-                    value = matcher.group( 2 );
-
-                    switch ( type )
-                    {
-                        case 'i':
-                        {
-                            p.setIntParameter( key, Integer.parseInt( value ) );
-                            break;
-                        }
-                        case 'd':
-                        {
-                            p.setDoubleParameter( key, Double.parseDouble( value ) );
-                            break;
-                        }
-                        case 'l':
-                        {
-                            p.setLongParameter( key, Long.parseLong( value ) );
-                            break;
-                        }
-                        case 'b':
-                        {
-                            p.setBooleanParameter( key, Boolean.valueOf( value ).booleanValue() );
-                            break;
-                        }
-                        case 'c':
-                        {
-                            String[] entries = value.split( "," );
-                            List<String> collection = new ArrayList<String>();
-                            for ( int i = 0; i < entries.length; i++ )
-                            {
-                                collection.add( entries[i].trim() );
-                            }
-
-                            p.setParameter( key, collection );
-                            break;
-                        }
-                        case 'm':
-                        {
-                            String[] entries = value.split( "," );
-
-                            Map<String, String> map = new LinkedHashMap<String, String>();
-                            for ( int i = 0; i < entries.length; i++ )
-                            {
-                                int idx = entries[i].indexOf( "=>" );
-                                if ( idx < 1 )
-                                {
-                                    break;
-                                }
-
-                                String mapKey = entries[i].substring( 0, idx );
-                                String mapVal = entries[i].substring( idx + 1, entries[i].length() );
-                                map.put( mapKey.trim(), mapVal.trim() );
-                            }
-
-                            p.setParameter( key, map );
-                            break;
-                        }
-                    }
-                }
-                else
-                {
-                    p.setParameter( key, value );
-                }
-            }
-        }
-    }
-
     public Header[] asRequestHeaders()
     {
         if ( headers == null )