You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by "Eugene Koontz (Created) (JIRA)" <ji...@apache.org> on 2012/03/24 00:05:29 UTC
[jira] [Created] (ZOOKEEPER-1432) Add javadoc and debug logging for
checkACL() method in PrepRequestProcessor
Add javadoc and debug logging for checkACL() method in PrepRequestProcessor
---------------------------------------------------------------------------
Key: ZOOKEEPER-1432
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1432
Project: ZooKeeper
Issue Type: Improvement
Components: server
Reporter: Eugene Koontz
Assignee: Eugene Koontz
I have a need for more logging in the checkACL() method and thought I'd add a javadoc section for the function too, while I am there.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1432) Add javadoc and debug logging
for checkACL() method in PrepRequestProcessor
Posted by "Hadoop QA (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1432?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13237412#comment-13237412 ]
Hadoop QA commented on ZOOKEEPER-1432:
--------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12519767/ZOOKEEPER-1432.patch
against trunk revision 1302736.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1010//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1010//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1010//console
This message is automatically generated.
> Add javadoc and debug logging for checkACL() method in PrepRequestProcessor
> ---------------------------------------------------------------------------
>
> Key: ZOOKEEPER-1432
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1432
> Project: ZooKeeper
> Issue Type: Improvement
> Components: server
> Affects Versions: 3.5.0
> Reporter: Eugene Koontz
> Assignee: Eugene Koontz
> Labels: security
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-1432.patch, ZOOKEEPER-1432.patch, ZOOKEEPER-1432.patch
>
>
> I have a need for more logging in the checkACL() method and thought I'd add a javadoc section for the function too, while I am there.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1432) Add javadoc and debug logging
for checkACL() method in PrepRequestProcessor
Posted by "Michi Mutsuzaki (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1432?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13253910#comment-13253910 ]
Michi Mutsuzaki commented on ZOOKEEPER-1432:
--------------------------------------------
+1. I'll check this in. Thank you for the patch, Eugene!
--Michi
> Add javadoc and debug logging for checkACL() method in PrepRequestProcessor
> ---------------------------------------------------------------------------
>
> Key: ZOOKEEPER-1432
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1432
> Project: ZooKeeper
> Issue Type: Improvement
> Components: server
> Affects Versions: 3.5.0
> Reporter: Eugene Koontz
> Assignee: Eugene Koontz
> Labels: security
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-1432.patch, ZOOKEEPER-1432.patch, ZOOKEEPER-1432.patch, ZOOKEEPER-1432.patch
>
>
> I have a need for more logging in the checkACL() method and thought I'd add a javadoc section for the function too, while I am there.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1432) Add javadoc and debug logging
for checkACL() method in PrepRequestProcessor
Posted by "Eugene Koontz (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1432?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13252159#comment-13252159 ]
Eugene Koontz commented on ZOOKEEPER-1432:
------------------------------------------
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
No new tests needed since changes are only javadoc and additional logging at the DEBUG level, per JIRA description.
> Add javadoc and debug logging for checkACL() method in PrepRequestProcessor
> ---------------------------------------------------------------------------
>
> Key: ZOOKEEPER-1432
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1432
> Project: ZooKeeper
> Issue Type: Improvement
> Components: server
> Affects Versions: 3.5.0
> Reporter: Eugene Koontz
> Assignee: Eugene Koontz
> Labels: security
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-1432.patch, ZOOKEEPER-1432.patch, ZOOKEEPER-1432.patch
>
>
> I have a need for more logging in the checkACL() method and thought I'd add a javadoc section for the function too, while I am there.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1432) Add javadoc and debug logging
for checkACL() method in PrepRequestProcessor
Posted by "Hadoop QA (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1432?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13237297#comment-13237297 ]
Hadoop QA commented on ZOOKEEPER-1432:
--------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12519743/ZOOKEEPER-1432.patch
against trunk revision 1302736.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
-1 findbugs. The patch appears to introduce 1 new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1007//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1007//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1007//console
This message is automatically generated.
> Add javadoc and debug logging for checkACL() method in PrepRequestProcessor
> ---------------------------------------------------------------------------
>
> Key: ZOOKEEPER-1432
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1432
> Project: ZooKeeper
> Issue Type: Improvement
> Components: server
> Affects Versions: 3.5.0
> Reporter: Eugene Koontz
> Assignee: Eugene Koontz
> Labels: security
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-1432.patch
>
>
> I have a need for more logging in the checkACL() method and thought I'd add a javadoc section for the function too, while I am there.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (ZOOKEEPER-1432) Add javadoc and debug logging for
checkACL() method in PrepRequestProcessor
Posted by "Eugene Koontz (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1432?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eugene Koontz updated ZOOKEEPER-1432:
-------------------------------------
Attachment: ZOOKEEPER-1432.patch
Use parameterized messages - thanks to Michi for mentioning them! I will try to get in the habit of using them more often.
> Add javadoc and debug logging for checkACL() method in PrepRequestProcessor
> ---------------------------------------------------------------------------
>
> Key: ZOOKEEPER-1432
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1432
> Project: ZooKeeper
> Issue Type: Improvement
> Components: server
> Affects Versions: 3.5.0
> Reporter: Eugene Koontz
> Assignee: Eugene Koontz
> Labels: security
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-1432.patch, ZOOKEEPER-1432.patch, ZOOKEEPER-1432.patch, ZOOKEEPER-1432.patch
>
>
> I have a need for more logging in the checkACL() method and thought I'd add a javadoc section for the function too, while I am there.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (ZOOKEEPER-1432) Add javadoc and debug logging for
checkACL() method in PrepRequestProcessor
Posted by "Eugene Koontz (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1432?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eugene Koontz updated ZOOKEEPER-1432:
-------------------------------------
Attachment: ZOOKEEPER-1432.patch
Reword javadoc to be a bit more concise
> Add javadoc and debug logging for checkACL() method in PrepRequestProcessor
> ---------------------------------------------------------------------------
>
> Key: ZOOKEEPER-1432
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1432
> Project: ZooKeeper
> Issue Type: Improvement
> Components: server
> Affects Versions: 3.5.0
> Reporter: Eugene Koontz
> Assignee: Eugene Koontz
> Labels: security
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-1432.patch, ZOOKEEPER-1432.patch, ZOOKEEPER-1432.patch
>
>
> I have a need for more logging in the checkACL() method and thought I'd add a javadoc section for the function too, while I am there.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1432) Add javadoc and debug logging
for checkACL() method in PrepRequestProcessor
Posted by "Hadoop QA (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1432?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13253891#comment-13253891 ]
Hadoop QA commented on ZOOKEEPER-1432:
--------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12522638/ZOOKEEPER-1432.patch
against trunk revision 1307644.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1033//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1033//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1033//console
This message is automatically generated.
> Add javadoc and debug logging for checkACL() method in PrepRequestProcessor
> ---------------------------------------------------------------------------
>
> Key: ZOOKEEPER-1432
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1432
> Project: ZooKeeper
> Issue Type: Improvement
> Components: server
> Affects Versions: 3.5.0
> Reporter: Eugene Koontz
> Assignee: Eugene Koontz
> Labels: security
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-1432.patch, ZOOKEEPER-1432.patch, ZOOKEEPER-1432.patch, ZOOKEEPER-1432.patch
>
>
> I have a need for more logging in the checkACL() method and thought I'd add a javadoc section for the function too, while I am there.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (ZOOKEEPER-1432) Add javadoc and debug logging for
checkACL() method in PrepRequestProcessor
Posted by "Eugene Koontz (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1432?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eugene Koontz updated ZOOKEEPER-1432:
-------------------------------------
Attachment: ZOOKEEPER-1432.patch
Wrap LOG.debug() statements in a LOG.isDebugEnabled() conditional.
> Add javadoc and debug logging for checkACL() method in PrepRequestProcessor
> ---------------------------------------------------------------------------
>
> Key: ZOOKEEPER-1432
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1432
> Project: ZooKeeper
> Issue Type: Improvement
> Components: server
> Affects Versions: 3.5.0
> Reporter: Eugene Koontz
> Assignee: Eugene Koontz
> Labels: security
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-1432.patch, ZOOKEEPER-1432.patch
>
>
> I have a need for more logging in the checkACL() method and thought I'd add a javadoc section for the function too, while I am there.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (ZOOKEEPER-1432) Add javadoc and debug logging for
checkACL() method in PrepRequestProcessor
Posted by "Eugene Koontz (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1432?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Eugene Koontz updated ZOOKEEPER-1432:
-------------------------------------
Attachment: ZOOKEEPER-1432.patch
> Add javadoc and debug logging for checkACL() method in PrepRequestProcessor
> ---------------------------------------------------------------------------
>
> Key: ZOOKEEPER-1432
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1432
> Project: ZooKeeper
> Issue Type: Improvement
> Components: server
> Affects Versions: 3.5.0
> Reporter: Eugene Koontz
> Assignee: Eugene Koontz
> Labels: security
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-1432.patch
>
>
> I have a need for more logging in the checkACL() method and thought I'd add a javadoc section for the function too, while I am there.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1432) Add javadoc and debug logging
for checkACL() method in PrepRequestProcessor
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1432?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13254075#comment-13254075 ]
Hudson commented on ZOOKEEPER-1432:
-----------------------------------
Integrated in ZooKeeper-trunk #1526 (See [https://builds.apache.org/job/ZooKeeper-trunk/1526/])
ZOOKEEPER-1432. Add javadoc and debug logging for checkACL() method in PrepRequestProcessor (Eugene Koontz via michim) (Revision 1326029)
Result = SUCCESS
michim : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1326029
Files :
* /zookeeper/trunk/CHANGES.txt
* /zookeeper/trunk/src/java/main/org/apache/zookeeper/server/PrepRequestProcessor.java
> Add javadoc and debug logging for checkACL() method in PrepRequestProcessor
> ---------------------------------------------------------------------------
>
> Key: ZOOKEEPER-1432
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1432
> Project: ZooKeeper
> Issue Type: Improvement
> Components: server
> Affects Versions: 3.5.0
> Reporter: Eugene Koontz
> Assignee: Eugene Koontz
> Labels: security
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-1432.patch, ZOOKEEPER-1432.patch, ZOOKEEPER-1432.patch, ZOOKEEPER-1432.patch
>
>
> I have a need for more logging in the checkACL() method and thought I'd add a javadoc section for the function too, while I am there.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1432) Add javadoc and debug logging
for checkACL() method in PrepRequestProcessor
Posted by "Hadoop QA (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1432?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13237327#comment-13237327 ]
Hadoop QA commented on ZOOKEEPER-1432:
--------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12519755/ZOOKEEPER-1432.patch
against trunk revision 1302736.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1008//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1008//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1008//console
This message is automatically generated.
> Add javadoc and debug logging for checkACL() method in PrepRequestProcessor
> ---------------------------------------------------------------------------
>
> Key: ZOOKEEPER-1432
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1432
> Project: ZooKeeper
> Issue Type: Improvement
> Components: server
> Affects Versions: 3.5.0
> Reporter: Eugene Koontz
> Assignee: Eugene Koontz
> Labels: security
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-1432.patch, ZOOKEEPER-1432.patch
>
>
> I have a need for more logging in the checkACL() method and thought I'd add a javadoc section for the function too, while I am there.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (ZOOKEEPER-1432) Add javadoc and debug logging
for checkACL() method in PrepRequestProcessor
Posted by "Michi Mutsuzaki (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1432?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13253719#comment-13253719 ]
Michi Mutsuzaki commented on ZOOKEEPER-1432:
--------------------------------------------
Hi Eugene,
I prefer using parameterized logging instead of using LOG.isDebugEnabled(). Other than that, the patch looks great!
http://www.slf4j.org/faq.html#logging_performance
Thanks!
--Michi
> Add javadoc and debug logging for checkACL() method in PrepRequestProcessor
> ---------------------------------------------------------------------------
>
> Key: ZOOKEEPER-1432
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1432
> Project: ZooKeeper
> Issue Type: Improvement
> Components: server
> Affects Versions: 3.5.0
> Reporter: Eugene Koontz
> Assignee: Eugene Koontz
> Labels: security
> Fix For: 3.5.0
>
> Attachments: ZOOKEEPER-1432.patch, ZOOKEEPER-1432.patch, ZOOKEEPER-1432.patch
>
>
> I have a need for more logging in the checkACL() method and thought I'd add a javadoc section for the function too, while I am there.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira