[GitHub] [jmeter] vlsi commented on a diff in pull request #5873: Add errorprone verifications

["vlsi (via GitHub)" <gi...@apache.org>]

vlsi commented on code in PR #5873:
URL: https://github.com/apache/jmeter/pull/5873#discussion_r1181639363


##########
src/components/src/main/java/org/apache/jmeter/assertions/CompareAssertion.java:
##########
@@ -126,8 +126,8 @@ private void compareContent(CompareAssertionResult result) {
         }
     }
 
-    private void markContentFailure(CompareAssertionResult result, String prevContent, SampleResult prevResult,
-            SampleResult currentResult, String currentContent) {
+    private static void markContentFailure(CompareAssertionResult result, String prevContent, SampleResult prevResult,

Review Comment:
   The key feature is that `static` keyword makes it clear that the method does not access `instance` fields, so all the variables are local



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@jmeter.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org