[jira] [Commented] (HADOOP-8614) IOUtils#skipFully hangs forever on EOF

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HADOOP-8614?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13420896#comment-13420896 ] 

Hadoop QA commented on HADOOP-8614:
-----------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12537591/HADOOP-8614.001.patch
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 1 new or modified test files.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 eclipse:eclipse.  The patch built with eclipse:eclipse.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    -1 core tests.  The patch failed these unit tests in hadoop-common-project/hadoop-common:

                  org.apache.hadoop.ha.TestZKFailoverController

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-HADOOP-Build/1210//testReport/
Console output: https://builds.apache.org/job/PreCommit-HADOOP-Build/1210//console

This message is automatically generated.
                
> IOUtils#skipFully hangs forever on EOF
> --------------------------------------
>
>                 Key: HADOOP-8614
>                 URL: https://issues.apache.org/jira/browse/HADOOP-8614
>             Project: Hadoop Common
>          Issue Type: Bug
>    Affects Versions: 2.0.1-alpha
>            Reporter: Colin Patrick McCabe
>            Assignee: Colin Patrick McCabe
>         Attachments: HADOOP-8614.001.patch
>
>
> IOUtils#skipFully contains this code:
> {code}
>   public static void skipFully(InputStream in, long len) throws IOException {
>     while (len > 0) {
>       long ret = in.skip(len);
>       if (ret < 0) {
>         throw new IOException( "Premature EOF from inputStream");
>       }
>       len -= ret;
>     }
>   }
> {code}
> The Java documentation is silent about what exactly skip is supposed to do in the event of EOF.  However, I looked at both InputStream#skip and ByteArrayInputStream#skip, and they both simply return 0 on EOF (no exception).  So it seems safe to assume that this is the standard Java way of doing things in an InputStream.
> Currently IOUtils#skipFully will loop forever if you ask it to skip past EOF!

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira