You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by jsoltren <gi...@git.apache.org> on 2017/03/23 22:16:47 UTC
[GitHub] spark pull request #17402: [SPARK-7200] Add cleanup for memory leak tests to...
GitHub user jsoltren opened a pull request:
https://github.com/apache/spark/pull/17402
[SPARK-7200] Add cleanup for memory leak tests to after() in TaskMemo\u2026
\u2026ryManagerSuite
Cleans up all memory used by tests explicitly in after(). This new
function has the JUnit @After tag and thus is guaranteed to run, even
if an @Test method throws an exception.
Testing:
Ran tests locally.
Hacked an existing test and made sure that a failure was reported in
the original test, and not in after().
Verified test logging in
test-reports/org.apache.spark.memory.TaskMemoryManagerSuite.xml.
## What changes were proposed in this pull request?
Updates TaskMemoryManagerSuite based on Josh Rosen's comments in SPARK-7200. It would be good to get some feedback as to whether or not this is the right direction.
## How was this patch tested?
See "Testing" above.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jsoltren/spark jose-tungsten
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/17402.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #17402
----
commit c44fc87971c2b313df69ac2815bae1824e7ddb1b
Author: Jos� Hiram Soltren <js...@gmail.com>
Date: 2017-03-10T19:57:26Z
[SPARK-7200] Add cleanup for memory leak tests to after() in TaskMemoryManagerSuite
Cleans up all memory used by tests explicitly in after(). This new
function has the JUnit @After tag and thus is guaranteed to run, even
if an @Test method throws an exception.
Testing:
Ran tests locally.
Hacked an existing test and made sure that a failure was reported in
the original test, and not in after().
Verified test logging in
test-reports/org.apache.spark.memory.TaskMemoryManagerSuite.xml.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #17402: [SPARK-7200] Check that memory is not leaked in T...
Posted by vanzin <gi...@git.apache.org>.
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/17402#discussion_r116886257
--- Diff: core/src/test/java/org/apache/spark/memory/TaskMemoryManagerSuite.java ---
@@ -25,27 +26,37 @@
public class TaskMemoryManagerSuite {
+ static TaskMemoryManager manager;
+
+ @After
+ public void after() {
+ Assert.assertEquals(0, manager.getMemoryConsumptionForThisTask());
--- End diff --
This sounds like this assert triggering, not the actual test failing?
I'm talking about is leaking memory *and* inserting a `fail("blah")` in a test and seeing what's reported.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #17402: [SPARK-7200] Check that memory is not leaked in TaskMemo...
Posted by vanzin <gi...@git.apache.org>.
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/17402
@jsoltren do you plan to follow up on Josh's comments? Seems like the scope of the bug was a little larger than you thought.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #17402: [SPARK-7200] Check that memory is not leaked in TaskMemo...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17402
**[Test build #76992 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76992/testReport)** for PR 17402 at commit [`e6ca027`](https://github.com/apache/spark/commit/e6ca027cc3d76fcd3eea1673cf8af6a4117cf12a).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #17402: [SPARK-7200] Check that memory is not leaked in T...
Posted by jsoltren <gi...@git.apache.org>.
Github user jsoltren commented on a diff in the pull request:
https://github.com/apache/spark/pull/17402#discussion_r116883362
--- Diff: core/src/test/java/org/apache/spark/memory/TaskMemoryManagerSuite.java ---
@@ -25,27 +26,37 @@
public class TaskMemoryManagerSuite {
+ static TaskMemoryManager manager;
+
+ @After
+ public void after() {
+ Assert.assertEquals(0, manager.getMemoryConsumptionForThisTask());
--- End diff --
@squito had the same concern. I purposefully leaked some memory at the end of leakedPageMemoryIsDetected and got this very helpful trace:
[info] Test org.apache.spark.memory.TaskMemoryManagerSuite.leakedPageMemoryIsDetected started
[error] Test org.apache.spark.memory.TaskMemoryManagerSuite.leakedPageMemoryIsDetected failed: java.lang.AssertionError: expected:<0> but was:<4096>, took 0.007 sec
[error] at org.apache.spark.memory.TaskMemoryManagerSuite.after(TaskMemoryManagerSuite.java:34)
[error] ...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #17402: [SPARK-7200] Check that memory is not leaked in TaskMemo...
Posted by jsoltren <gi...@git.apache.org>.
Github user jsoltren commented on the issue:
https://github.com/apache/spark/pull/17402
Yes, I'll post an updated change once I wrap up a couple of other things...
> Seems like the scope of the bug was a little larger than you thought.
@vanzin The scope of the bug (specifically the text "after each suite") was vague so this was a purposefully small proof-of-concept change. I tried to be clear about this in JIRA comments and in the PR description.
That being said: yes, the direction I'll go is reviewing more existing tests and seeing where it would make sense to put a check for leaked memory. Ideally I'd put this in an after() or afterAll() block but I need to do some more digging to figure out exactly where.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #17402: [SPARK-7200] Add cleanup for memory leak tests to after(...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17402
**[Test build #75129 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75129/testReport)** for PR 17402 at commit [`c44fc87`](https://github.com/apache/spark/commit/c44fc87971c2b313df69ac2815bae1824e7ddb1b).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #17402: [SPARK-7200] Add cleanup for memory leak tests to...
Posted by vanzin <gi...@git.apache.org>.
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/17402#discussion_r108492013
--- Diff: core/src/test/java/org/apache/spark/memory/TaskMemoryManagerSuite.java ---
@@ -25,27 +26,37 @@
public class TaskMemoryManagerSuite {
+ static TaskMemoryManager manager;
+
+ @After
+ public void after() {
+ Assert.assertEquals(0, manager.getMemoryConsumptionForThisTask());
+ Assert.assertEquals(0, manager.cleanUpAllAllocatedMemory());
+ manager = null;
+ }
+
@Test
public void leakedPageMemoryIsDetected() {
- final TaskMemoryManager manager = new TaskMemoryManager(
+ manager = new TaskMemoryManager(
new StaticMemoryManager(
new SparkConf().set("spark.memory.offHeap.enabled", "false"),
Long.MAX_VALUE,
Long.MAX_VALUE,
1),
0);
final MemoryConsumer c = new TestMemoryConsumer(manager);
- manager.allocatePage(4096, c); // leak memory
+ final MemoryBlock block = manager.allocatePage(4096, c); // leak memory
Assert.assertEquals(4096, manager.getMemoryConsumptionForThisTask());
Assert.assertEquals(4096, manager.cleanUpAllAllocatedMemory());
+ manager.freePage(block, c);
--- End diff --
Is this really needed? Why isn't the call above freeing this memory?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #17402: [SPARK-7200] Check that memory is not leaked in TaskMemo...
Posted by vanzin <gi...@git.apache.org>.
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/17402
Pretty sure we can close this out.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #17402: [SPARK-7200] Check that memory is not leaked in TaskMemo...
Posted by JoshRosen <gi...@git.apache.org>.
Github user JoshRosen commented on the issue:
https://github.com/apache/spark/pull/17402
I think that the scope / intent of the original SPARK-7200 JIRA was to include this type of logic as a generic assertion in multiple suites so that we gain additional implicit assertions in suites which would otherwise maybe not have them, whereas this patch looks mostly like cleanup/refactoring of a single suite's existing assertions.
I don't have any objections to this patch but I don't see it as a big win either. I don't think that this PR's specific changes will actually help to prevent any bugs because we don't appear to be adding assertions which weren't already present in the existing code.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #17402: [SPARK-7200] Check that memory is not leaked in T...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/17402
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #17402: [SPARK-7200] Add cleanup for memory leak tests to after(...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17402
**[Test build #75129 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/75129/testReport)** for PR 17402 at commit [`c44fc87`](https://github.com/apache/spark/commit/c44fc87971c2b313df69ac2815bae1824e7ddb1b).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #17402: [SPARK-7200] Add cleanup for memory leak tests to after(...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17402
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #17402: [SPARK-7200] Check that memory is not leaked in TaskMemo...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17402
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #17402: [SPARK-7200] Add cleanup for memory leak tests to...
Posted by vanzin <gi...@git.apache.org>.
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/17402#discussion_r108491343
--- Diff: core/src/test/java/org/apache/spark/memory/TaskMemoryManagerSuite.java ---
@@ -25,27 +26,37 @@
public class TaskMemoryManagerSuite {
+ static TaskMemoryManager manager;
+
+ @After
+ public void after() {
+ Assert.assertEquals(0, manager.getMemoryConsumptionForThisTask());
--- End diff --
Add `Assert.assertNotNull(manager)`.
Also, probably minor, but if a test fails, these checks will probably fail in weird ways and might mask the original error... I'd try to insert a failure in a test and seeing what happens.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #17402: [SPARK-7200] Add cleanup for memory leak tests to...
Posted by vanzin <gi...@git.apache.org>.
Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/17402#discussion_r108491146
--- Diff: core/src/test/java/org/apache/spark/memory/TaskMemoryManagerSuite.java ---
@@ -25,27 +26,37 @@
public class TaskMemoryManagerSuite {
+ static TaskMemoryManager manager;
--- End diff --
Does not need to be static. Also should be `private`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #17402: [SPARK-7200] Check that memory is not leaked in T...
Posted by jsoltren <gi...@git.apache.org>.
Github user jsoltren commented on a diff in the pull request:
https://github.com/apache/spark/pull/17402#discussion_r116881319
--- Diff: core/src/test/java/org/apache/spark/memory/TaskMemoryManagerSuite.java ---
@@ -25,27 +26,37 @@
public class TaskMemoryManagerSuite {
+ static TaskMemoryManager manager;
+
+ @After
+ public void after() {
+ Assert.assertEquals(0, manager.getMemoryConsumptionForThisTask());
+ Assert.assertEquals(0, manager.cleanUpAllAllocatedMemory());
+ manager = null;
+ }
+
@Test
public void leakedPageMemoryIsDetected() {
- final TaskMemoryManager manager = new TaskMemoryManager(
+ manager = new TaskMemoryManager(
new StaticMemoryManager(
new SparkConf().set("spark.memory.offHeap.enabled", "false"),
Long.MAX_VALUE,
Long.MAX_VALUE,
1),
0);
final MemoryConsumer c = new TestMemoryConsumer(manager);
- manager.allocatePage(4096, c); // leak memory
+ final MemoryBlock block = manager.allocatePage(4096, c); // leak memory
Assert.assertEquals(4096, manager.getMemoryConsumptionForThisTask());
Assert.assertEquals(4096, manager.cleanUpAllAllocatedMemory());
+ manager.freePage(block, c);
--- End diff --
It should. We can check for that instead with:
Assert.assertEquals(0, manager.cleanUpAllAllocatedMemory());
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #17402: [SPARK-7200] Check that memory is not leaked in TaskMemo...
Posted by jiangxb1987 <gi...@git.apache.org>.
Github user jiangxb1987 commented on the issue:
https://github.com/apache/spark/pull/17402
ping @jsoltren
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #17402: [SPARK-7200] Check that memory is not leaked in TaskMemo...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17402
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/76992/
Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #17402: [SPARK-7200] Check that memory is not leaked in TaskMemo...
Posted by jsoltren <gi...@git.apache.org>.
Github user jsoltren commented on the issue:
https://github.com/apache/spark/pull/17402
At this point I'd like to get this checked in whether or not @JoshRosen chimes in here. @HyukjinKwon @vanzin I've updated this based on the previous review feedback received. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #17402: [SPARK-7200] Check that memory is not leaked in TaskMemo...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/17402
**[Test build #76992 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/76992/testReport)** for PR 17402 at commit [`e6ca027`](https://github.com/apache/spark/commit/e6ca027cc3d76fcd3eea1673cf8af6a4117cf12a).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #17402: [SPARK-7200] Add cleanup for memory leak tests to after(...
Posted by HyukjinKwon <gi...@git.apache.org>.
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/17402
I see. Thank you for your input.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #17402: [SPARK-7200] Add cleanup for memory leak tests to after(...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17402
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #17402: [SPARK-7200] Add cleanup for memory leak tests to after(...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/17402
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/75129/
Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #17402: [SPARK-7200] Add cleanup for memory leak tests to after(...
Posted by vanzin <gi...@git.apache.org>.
Github user vanzin commented on the issue:
https://github.com/apache/spark/pull/17402
ok to test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #17402: [SPARK-7200] Add cleanup for memory leak tests to after(...
Posted by HyukjinKwon <gi...@git.apache.org>.
Github user HyukjinKwon commented on the issue:
https://github.com/apache/spark/pull/17402
Hi @jsoltren, is this still active?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #17402: [SPARK-7200] Add cleanup for memory leak tests to after(...
Posted by jsoltren <gi...@git.apache.org>.
Github user jsoltren commented on the issue:
https://github.com/apache/spark/pull/17402
I'm still waiting on feedback from @joshrosen on my earlier question. I can update this patch in response to @vanzin's review feedback if it would help to get this checked in.
IMO this is a pretty trivial fix that we should get checked in regardless.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org