You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by "MikeThomsen (via GitHub)" <gi...@apache.org> on 2023/04/30 12:41:29 UTC
[GitHub] [nifi] MikeThomsen opened a new pull request, #7212: NIFI-11222 Added deprecationlogger to MongoDB processors that extend …
MikeThomsen opened a new pull request, #7212:
URL: https://github.com/apache/nifi/pull/7212
…AbstractMongoProcessor.
<!-- Licensed to the Apache Software Foundation (ASF) under one or more -->
<!-- contributor license agreements. See the NOTICE file distributed with -->
<!-- this work for additional information regarding copyright ownership. -->
<!-- The ASF licenses this file to You under the Apache License, Version 2.0 -->
<!-- (the "License"); you may not use this file except in compliance with -->
<!-- the License. You may obtain a copy of the License at -->
<!-- http://www.apache.org/licenses/LICENSE-2.0 -->
<!-- Unless required by applicable law or agreed to in writing, software -->
<!-- distributed under the License is distributed on an "AS IS" BASIS, -->
<!-- WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. -->
<!-- See the License for the specific language governing permissions and -->
<!-- limitations under the License. -->
# Summary
[NIFI-00000](https://issues.apache.org/jira/browse/NIFI-00000)
# Tracking
Please complete the following tracking steps prior to pull request creation.
### Issue Tracking
- [ ] [Apache NiFi Jira](https://issues.apache.org/jira/browse/NIFI) issue created
### Pull Request Tracking
- [ ] Pull Request title starts with Apache NiFi Jira issue number, such as `NIFI-00000`
- [ ] Pull Request commit message starts with Apache NiFi Jira issue number, as such `NIFI-00000`
### Pull Request Formatting
- [ ] Pull Request based on current revision of the `main` branch
- [ ] Pull Request refers to a feature branch with one commit containing changes
# Verification
Please indicate the verification steps performed prior to pull request creation.
### Build
- [ ] Build completed using `mvn clean install -P contrib-check`
- [ ] JDK 11
- [ ] JDK 17
### Licensing
- [ ] New dependencies are compatible with the [Apache License 2.0](https://apache.org/licenses/LICENSE-2.0) according to the [License Policy](https://www.apache.org/legal/resolved.html)
- [ ] New dependencies are documented in applicable `LICENSE` and `NOTICE` files
### Documentation
- [ ] Documentation formatting appears as expected in rendered files
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] MikeThomsen commented on pull request #7212: NIFI-11222 Added deprecationlogger to MongoDB processors that extend …
Posted by "MikeThomsen (via GitHub)" <gi...@apache.org>.
MikeThomsen commented on PR #7212:
URL: https://github.com/apache/nifi/pull/7212#issuecomment-1530129370
@exceptionfactory @mattyb149 changes made.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] exceptionfactory commented on a diff in pull request #7212: NIFI-11222 Added deprecationlogger to MongoDB processors that extend …
Posted by "exceptionfactory (via GitHub)" <gi...@apache.org>.
exceptionfactory commented on code in PR #7212:
URL: https://github.com/apache/nifi/pull/7212#discussion_r1181625950
##########
nifi-nar-bundles/nifi-mongodb-bundle/nifi-mongodb-processors/src/main/java/org/apache/nifi/processors/mongodb/AbstractMongoProcessor.java:
##########
@@ -373,6 +374,11 @@ protected Collection<ValidationResult> customValidate(ValidationContext context)
boolean clientIsSet = context.getProperty(CLIENT_SERVICE).isSet();
boolean uriIsSet = context.getProperty(URI).isSet();
+ if (uriIsSet) {
+ DeprecationLoggerFactory.getLogger(AbstractMongoProcessor.class).warn("The MongoDB URI and other client " +
+ "configuration properties on this proessor are deprecated and will be removed in NiFi 2.0");
Review Comment:
The message should indicate that the MongoClientService should be used. The `will be removed in NiFi 2.0` portion of the message should be removed since it is implicit in all deprecation warnings.
```suggestion
"connection properties should be replaced with an implementation of the MongoClientService");
```
##########
nifi-nar-bundles/nifi-mongodb-bundle/nifi-mongodb-processors/src/main/java/org/apache/nifi/processors/mongodb/AbstractMongoProcessor.java:
##########
@@ -373,6 +374,11 @@ protected Collection<ValidationResult> customValidate(ValidationContext context)
boolean clientIsSet = context.getProperty(CLIENT_SERVICE).isSet();
boolean uriIsSet = context.getProperty(URI).isSet();
+ if (uriIsSet) {
+ DeprecationLoggerFactory.getLogger(AbstractMongoProcessor.class).warn("The MongoDB URI and other client " +
Review Comment:
The `getLogger()` call should use `getClass()` to reference the actual Processor class instead of the abstract class.
```suggestion
DeprecationLoggerFactory.getLogger(getClass()).warn("The MongoDB URI and other client " +
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] MikeThomsen commented on a diff in pull request #7212: NIFI-11222 Added deprecationlogger to MongoDB processors that extend …
Posted by "MikeThomsen (via GitHub)" <gi...@apache.org>.
MikeThomsen commented on code in PR #7212:
URL: https://github.com/apache/nifi/pull/7212#discussion_r1181839430
##########
nifi-nar-bundles/nifi-mongodb-bundle/nifi-mongodb-processors/src/main/java/org/apache/nifi/processors/mongodb/PutMongo.java:
##########
@@ -159,6 +159,7 @@ public List<PropertyDescriptor> getSupportedPropertyDescriptors() {
@Override
protected Collection<ValidationResult> customValidate(final ValidationContext validationContext) {
List<ValidationResult> problems = new ArrayList<>();
+ problems.addAll(super.customValidate(validationContext));
Review Comment:
Yes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] mattyb149 commented on a diff in pull request #7212: NIFI-11222 Added deprecationlogger to MongoDB processors that extend …
Posted by "mattyb149 (via GitHub)" <gi...@apache.org>.
mattyb149 commented on code in PR #7212:
URL: https://github.com/apache/nifi/pull/7212#discussion_r1181328076
##########
nifi-nar-bundles/nifi-mongodb-bundle/nifi-mongodb-processors/src/main/java/org/apache/nifi/processors/mongodb/PutMongo.java:
##########
@@ -159,6 +159,7 @@ public List<PropertyDescriptor> getSupportedPropertyDescriptors() {
@Override
protected Collection<ValidationResult> customValidate(final ValidationContext validationContext) {
List<ValidationResult> problems = new ArrayList<>();
+ problems.addAll(super.customValidate(validationContext));
Review Comment:
Was this an oversight earlier, to not call the super version?
##########
nifi-nar-bundles/nifi-mongodb-bundle/nifi-mongodb-processors/src/main/java/org/apache/nifi/processors/mongodb/AbstractMongoProcessor.java:
##########
@@ -373,6 +374,11 @@ protected Collection<ValidationResult> customValidate(ValidationContext context)
boolean clientIsSet = context.getProperty(CLIENT_SERVICE).isSet();
boolean uriIsSet = context.getProperty(URI).isSet();
+ if (uriIsSet) {
+ DeprecationLoggerFactory.getLogger(AbstractMongoProcessor.class).warn("The MongoDB URI and other client " +
+ "configuration properties on this proessor are deprecated and will be removed in NiFi 2.0");
Review Comment:
Minor typo on `processor`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] MikeThomsen commented on a diff in pull request #7212: NIFI-11222 Added deprecationlogger to MongoDB processors that extend …
Posted by "MikeThomsen (via GitHub)" <gi...@apache.org>.
MikeThomsen commented on code in PR #7212:
URL: https://github.com/apache/nifi/pull/7212#discussion_r1181840352
##########
nifi-nar-bundles/nifi-mongodb-bundle/nifi-mongodb-processors/src/main/java/org/apache/nifi/processors/mongodb/AbstractMongoProcessor.java:
##########
@@ -373,6 +374,11 @@ protected Collection<ValidationResult> customValidate(ValidationContext context)
boolean clientIsSet = context.getProperty(CLIENT_SERVICE).isSet();
boolean uriIsSet = context.getProperty(URI).isSet();
+ if (uriIsSet) {
+ DeprecationLoggerFactory.getLogger(AbstractMongoProcessor.class).warn("The MongoDB URI and other client " +
+ "configuration properties on this proessor are deprecated and will be removed in NiFi 2.0");
Review Comment:
Resolved by @exceptionfactory's suggestions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi] exceptionfactory closed pull request #7212: NIFI-11222 Added deprecationlogger to MongoDB processors that extend …
Posted by "exceptionfactory (via GitHub)" <gi...@apache.org>.
exceptionfactory closed pull request #7212: NIFI-11222 Added deprecationlogger to MongoDB processors that extend …
URL: https://github.com/apache/nifi/pull/7212
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org