[GitHub] [hive] belugabehr commented on a change in pull request #1742: HIVE-24484: Upgrade Hadoop to 3.3.1

[GitBox <gi...@apache.org>]

belugabehr commented on a change in pull request #1742:
URL: https://github.com/apache/hive/pull/1742#discussion_r665373095



##########
File path: llap-server/src/java/org/apache/hadoop/hive/llap/io/api/impl/LlapInputFormat.java
##########
@@ -137,6 +137,8 @@
       // This starts the reader in the background.
       rr.start();
       return result;
+    } catch (IOException ioe) {

Review comment:
       Hey @pgaref,
   
   Ya, this is required.  Based on the `InvalidInputException` (which is a subclass of `IOException`) changes in HDFS, this code is require to pass the `InvalidInputException` up to the caller directly, otherwise, in the `Exception` block, it gets wrapped in yet another `IOException` and that caller is no longer able to detect the `InvalidInputException`.
   
   I hope that makes sense.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org