[GitHub] fabianmenges commented on a change in pull request #3504: Feature: Display the verbose name for metrics within Timeseries charts and legend.

[gi...@git.apache.org]

fabianmenges commented on a change in pull request #3504: Feature: Display the verbose name for metrics within Timeseries charts and legend.
URL: https://github.com/apache/incubator-superset/pull/3504#discussion_r142226464
 
 

 ##########
 File path: superset/viz.py
 ##########
 @@ -840,16 +840,11 @@ def to_series(self, df, classed='', title_suffix=''):
             ys = series[name]
             if df[name].dtype.kind not in "biufc":
                 continue
-            if isinstance(name, string_types):
-                series_title = name
-            else:
-                name = ["{}".format(s) for s in name]
-                if len(self.form_data.get('metrics')) > 1:
 
 Review comment:
   Please don't report this to me if you don't want me to fix it. Just wasted 30min on context switching and pushing a branch only to find your fix...
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services