You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by "Jackie-Jiang (via GitHub)" <gi...@apache.org> on 2024/10/29 18:35:06 UTC

Re: [PR] Add bucketing time zone paramter to dateTimeConvert() function [pinot]

Jackie-Jiang commented on code in PR #14298:
URL: https://github.com/apache/pinot/pull/14298#discussion_r1821358252


##########
pinot-common/src/main/java/org/apache/pinot/common/function/scalar/DateTimeConvert.java:
##########
@@ -42,36 +51,43 @@ public Object dateTimeConvert(String timeValueStr, String inputFormatStr, String
       _inputFormatSpec = new DateTimeFormatSpec(inputFormatStr);
       _outputFormatSpec = new DateTimeFormatSpec(outputFormatStr);
       _granularitySpec = new DateTimeGranularitySpec(outputGranularityStr);
+      _dateTime = new MutableDateTime(0L, DateTimeZone.UTC);
+      _buffer = new StringBuilder();

Review Comment:
   Sorry I meant comments instead of javadoc. The purpose is to educate future developers



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org