You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tapestry.apache.org by "Thiago H. de Paula Figueiredo (JIRA)" <ji...@apache.org> on 2014/07/01 23:57:24 UTC

[jira] [Comment Edited] (TAP5-1815) Translators and/or Validators should override the element's type attribute where appropriate to use HTML5 types

    [ https://issues.apache.org/jira/browse/TAP5-1815?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14049360#comment-14049360 ] 

Thiago H. de Paula Figueiredo edited comment on TAP5-1815 at 7/1/14 9:56 PM:
-----------------------------------------------------------------------------

Implemented:
* A SymbolConstants.ENABLE_HTML5_SUPPORT (tapestry.enable-html5-support) configuration symbol with "false" as default value.
* An Html5Support service with an isHtml5SupportEnabled() method, which is used in validators and translators to know whether to assume HTML5 should be supported or not.
* "required" attribute with the Required validator
* "pattern" attribute with the Regexp validator
* forcing of "email" input type with the Email validator
* "min" attribute and forcing of "number" input type with the Min validator
* "max" attribute and forcing of "number" input type with the Max validator
* When bound to a number type,  TextField (through NumericTranslator) changes the type attribute to "number"

So far, I haven't removed JavaScript client-side validation when HTML5 is used with the validators above, just in case a browser without support for them is used.

Is there anything I'm missing?


was (Author: thiagohp):
Implemented:
* A SymbolConstants.ENABLE_HTML5_SUPPORT (tapestry.enable-html5-support) configuration symbol with "false" as default value.
* An Html5Support service with an isHtml5SupportEnabled() method, which is used in validators and translators to know whether to assume HTML5 should be supported or not.
* "required" attribute with the Required validator
* "pattern" attribute with the Regexp validator
* "email" input type with the Email validator
* "min" attribute and "number" input type with the Min validator
* "max" attribute and "number" input type with the Max validator
* When bound to a number type,  TextField (through NumericTranslator) generates type="number"

So far, I haven't removed JavaScript client-side validation when HTML5 is used with the validators above, just in case a browser without support for them is used.

Is there anything I'm missing?

> Translators and/or Validators should override the <input> element's type attribute where appropriate to use HTML5 types
> -----------------------------------------------------------------------------------------------------------------------
>
>                 Key: TAP5-1815
>                 URL: https://issues.apache.org/jira/browse/TAP5-1815
>             Project: Tapestry 5
>          Issue Type: New Feature
>          Components: tapestry-core
>    Affects Versions: 5.4
>            Reporter: Howard M. Lewis Ship
>            Assignee: Thiago H. de Paula Figueiredo
>
> Possibly this should be based on a configuration symbol as well.
> When validating that something is an email address, a validating regular expression is nice, by type="email" is often nice.



--
This message was sent by Atlassian JIRA
(v6.2#6252)