[jira] [Commented] (METRON-1873) Update Bootstrap version in Management UI

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/METRON-1873?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16689220#comment-16689220 ] 

ASF GitHub Bot commented on METRON-1873:
----------------------------------------

GitHub user sardell opened a pull request:

    https://github.com/apache/metron/pull/1267

    METRON-1873: Update Bootstrap version in Management UI

    ## Contributor Comments
    Link to original ticket here: https://jira.apache.org/jira/browse/METRON-1873
    
    We are currently using an alpha version of Bootstrap v4. I updated the project to use the latest stable release (v4.1.3) for a couple of reasons. There were breaking changes between the alpha and stable release that make it impossible for us to use angular ports of Bootstrap like ng-bootstrap. In addition, there are quite a few features and fixes we would want in our project. The list is long, but if you're curious, [take a look at the changelog|https://github.com/twbs/bootstrap/releases].
    
    Besides updating the bootstrap library, the work mainly consisted of updating deprecated class names and accounting for utility class value changes (for example, the class `.my-1` would give an element 1 rem of margin on the y-axis using the alpha release, whereas it only gives .25rem using the stable releases).
    
    There was a dependency removed ([tether.js](http://tether.io/)) and one added ([popper.js](https://popper.js.org/)). This is because Bootstrap switched the library it uses for tooltips and dropdown menus with the update. [Popper.js is licensed under the MIT license](https://github.com/FezVrasta/popper.js/blob/master/LICENSE.md).
    
    ## Pull Request Checklist
    
    Thank you for submitting a contribution to Apache Metron.  
    Please refer to our [Development Guidelines](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=61332235) for the complete guide to follow for contributions.  
    Please refer also to our [Build Verification Guidelines](https://cwiki.apache.org/confluence/display/METRON/Verifying+Builds?show-miniview) for complete smoke testing guides.  
    
    
    In order to streamline the review of the contribution we ask you follow these guidelines and ask you to double check the following:
    
    ### For all changes:
    - [ ] Is there a JIRA ticket associated with this PR? If not one needs to be created at [Metron Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel).
    - [ ] Does your PR title start with METRON-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
    - [ ] Has your PR been rebased against the latest commit within the target branch (typically master)?
    
    
    ### For code changes:
    - [ ] Have you included steps to reproduce the behavior or problem that is being changed or addressed?
    - [ ] Have you included steps or a guide to how the change may be verified and tested manually?
    - [ ] Have you ensured that the full suite of tests and checks have been executed in the root metron folder via:
      ```
      mvn -q clean integration-test install && dev-utilities/build-utils/verify_licenses.sh 
      ```
    
    - [ ] Have you written or updated unit tests and or integration tests to verify your changes?
    - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
    - [ ] Have you verified the basic functionality of the build by building and running locally with Vagrant full-dev environment or the equivalent?
    
    ### For documentation related changes:
    - [ ] Have you ensured that format looks appropriate for the output in which it is rendered by building and verifying the site-book? If not then run the following commands and the verify changes via `site-book/target/site/index.html`:
    
      ```
      cd site-book
      mvn site
      ```
    
    #### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
    It is also recommended that [travis-ci](https://travis-ci.org) is set up for your personal repository such that your branches are built there before submitting a pull request.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/sardell/metron METRON-1873

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/metron/pull/1267.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1267
    
----
commit b1468d7dfdedc2c82fabf001ecd70280e9f0b060
Author: Shane Ardell <sa...@...>
Date:   2018-10-25T11:20:00Z

    replace .pull-* class with .float-*

commit 5bd22887cee47d6d4f8cad4a74167637332eb43e
Author: Shane Ardell <sa...@...>
Date:   2018-10-25T11:23:32Z

    replace my-1 with my-3 for 1rem margin

commit b1ec8d4b1cd4270509b3ebb624d636dde3dcaafc
Author: Shane Ardell <sa...@...>
Date:   2018-10-25T12:06:29Z

    remove card classes from layout columns

commit 05437b818fbb8adade4caf2bd7757a09a40032f3
Author: Shane Ardell <sa...@...>
Date:   2018-10-25T13:50:19Z

    replace deprecated col-xs-* classes

commit 597191652941e44a7dd1ce668032bd127f984189
Author: Shane Ardell <sa...@...>
Date:   2018-10-29T10:59:28Z

    update to bootstrap 4 navbar

commit fb8c531951e0340158fe6aa485180008eb6c2e65
Author: Shane Ardell <sa...@...>
Date:   2018-10-29T13:34:35Z

    fix margin and paddings to use 3 setting for 1 rem

commit 7fb5c85beaf3f535b9816d7c8a53aa397c9c3810
Author: Shane Ardell <sa...@...>
Date:   2018-10-29T13:35:37Z

    fix field schema padding and display properties

commit 7d6c22ad9dc1bb62fbb3144f5c9ba3ed1365aca3
Author: Shane Ardell <sa...@...>
Date:   2018-10-30T13:36:44Z

    fix table layouts and spacing

commit baf59cf98a27dccf1552d55857e397c10ee92027
Author: Shane Ardell <sa...@...>
Date:   2018-10-30T13:51:57Z

    add button spacing whenever two or more buttons appear in a row

commit e4acbdc9ed0db888ef961dc81f3ae6d38a7b9796
Author: Shane Ardell <sa...@...>
Date:   2018-10-30T13:52:51Z

    update to bootstrap 4.1.3

commit 074d49e9fd7c55bcc9e48f3dde719ebdc00e5a8b
Author: tiborm <ti...@...>
Date:   2018-11-07T12:27:53Z

    adding popper.js, more info here: https://getbootstrap.com/docs/4.0/getting-started/webpack/

commit 41f88cbdec2cc095aa17a45e0051a9adc975ae25
Author: tiborm <ti...@...>
Date:   2018-11-07T12:58:59Z

    wiring in popper.js and eliminating tether

----


> Update Bootstrap version in Management UI
> -----------------------------------------
>
>                 Key: METRON-1873
>                 URL: https://issues.apache.org/jira/browse/METRON-1873
>             Project: Metron
>          Issue Type: Bug
>            Reporter: Shane Ardell
>            Priority: Major
>
> We are currently using an alpha version of Bootstrap v4. We should update to the latest stable release (v4.1.3) for a couple of reasons. There were breaking changes between the alpha and stable release that make it impossible for us to use angular ports of Bootstrap like ng-bootstrap. In addition, there are quite a few features and fixes we would want in our project. The list is long, but if you're curious, [take a look at the changelog|https://github.com/twbs/bootstrap/releases].



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)