[jira] [Comment Edited] (ORC-119) Create an abstraction named PhysicalWriter that abstracts where the Writer puts the bytes

["Sergey Shelukhin (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/ORC-119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15733924#comment-15733924 ] 

Sergey Shelukhin edited comment on ORC-119 at 12/9/16 1:14 AM:
---------------------------------------------------------------

Response to the last comment in the jira - can you elaborate on fixing the implementation - it depends on protobuf object, which should always be compatible, right?

The goal was to separate ORC encoding from physical representation... so, non-ORC stuff like protobuf is not passed as bytes.

What would you suggest instead? We could make all methods just take bytes, but that would be even more brittle cause no compatibility could ever be enforced. So I'm not sure what you mean by brittle in this context.



was (Author: sershe):
Response to the last comment in the jira - can you elaborate on fixing the implementation - it depends on protobuf object, which should always be compatible, right?
What would you suggest instead? We could make all methods just take bytes, but that would be even more brittle cause no compatibility could ever be enforced.

> Create an abstraction named PhysicalWriter that abstracts where the Writer puts the bytes
> -----------------------------------------------------------------------------------------
>
>                 Key: ORC-119
>                 URL: https://issues.apache.org/jira/browse/ORC-119
>             Project: Orc
>          Issue Type: Bug
>          Components: Java
>            Reporter: Owen O'Malley
>
> This is a forward port of HIVE-14453, which introduce PhysicalWriter.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)