You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by Karuppayya <gi...@git.apache.org> on 2015/12/21 15:49:30 UTC
[GitHub] incubator-zeppelin pull request: Prevent server calls when there i...
GitHub user Karuppayya opened a pull request:
https://github.com/apache/incubator-zeppelin/pull/559
Prevent server calls when there is no data in paragraphs
*Whenever there is no text text in para, server call are made to run para.
With this PR, the paras will be run only where there is text in them.(also in case of "run all paras" option).
*The messages from ngtoast were getting hidden behind navbar. Fixing it in this PR
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Karuppayya/incubator-zeppelin empty-para
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-zeppelin/pull/559.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #559
----
commit 53c50f64936ab70759550d6f852835828780d814
Author: karuppayya <ka...@gmail.com>
Date: 2015-12-21T14:44:05Z
*Prevent serever calls when there is no data in paragraphs
*Fix css for ngtoast div. It was getting hid behind navbar
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: Prevent server calls when there i...
Posted by Karuppayya <gi...@git.apache.org>.
Github user Karuppayya commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/559#issuecomment-169302930
Closing this PR based on above discussion.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: Prevent server calls when there i...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/559#issuecomment-167921950
To me, it make sense to let run empty paragraph while this allow each different interpreter implement their own behavior for empty input.
If we decide to disallow run empty paragraph, i'm okay, too. but this case, we'll need to take care in server side API, too (rest api). For consistent behavior both GUI, API.
My preference is leave this behavior unchanged (let run empty paragraph), if there are no big problems or downsides.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: Prevent server calls when there i...
Posted by Karuppayya <gi...@git.apache.org>.
Github user Karuppayya commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/559#issuecomment-166567968
@Leemoonsoo i was not aware of the use cases. if its natural behaviour, then we can allow running of empty paras.
May be we have to put the CSS change in, else the messages gets hidden behind navbar.
Just noticed that shift+enter does not work with empty paras(may be something to be fixed) irrespective of my change
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: Prevent server calls when there i...
Posted by corneadoug <gi...@git.apache.org>.
Github user corneadoug commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/559#issuecomment-167920273
@Leemoonsoo What is the decision about this PR in the end?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: Prevent server calls when there i...
Posted by Karuppayya <gi...@git.apache.org>.
Github user Karuppayya closed the pull request at:
https://github.com/apache/incubator-zeppelin/pull/559
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: Prevent server calls when there i...
Posted by prabhjyotsingh <gi...@git.apache.org>.
Github user prabhjyotsingh commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/559#issuecomment-166534240
Could you change the description to follow our PR Template?
(you can find it [here] (https://github.com/apache/incubator-zeppelin/blob/master/CONTRIBUTING.md#creating-a-pull-request) )
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: Prevent server calls when there i...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/559#issuecomment-166505477
Tested and found 'Cannot run an empty paragraph ' message does not raise with 'Shift+Enter' shortcut.
By the way, I thought running empty paragraph is natural behavior, while some interpreter might want to have an action on empty input. But if you think it make sense to skip empty paragraph, could you share little bit more about the reason?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---