You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2021/03/30 22:04:24 UTC

[GitHub] [nifi] turcsanyip commented on pull request #4773: NIFI-8161 NiFi EL: migration from SimpleDateFormat to DateTimeFormatter

turcsanyip commented on pull request #4773:
URL: https://github.com/apache/nifi/pull/4773#issuecomment-810608397


   @arkadius Thanks for the review changes.
   The code looks good to me now and I also tested it with some flows (formatting and parsing dates back and forth with different formats).
   
   I'm a bit concerned about the migration guide you mentioned on the Jira ticket.
   If this change is backward compatible (and as far as I understand it should be that with the lenient formatter), then no migration guide needed.
   If migration steps really needed, then it is questionable to add this change in a minor release.
   
   Could you please give us some examples of formats that can be problematic?
   I could not find any with my tests, though I did not use really advanced formats.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org