You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Abhay Kulkarni <ak...@hortonworks.com> on 2023/02/04 18:42:49 UTC
Review Request 74296: RANGER-4070: Provide mechanism to manage potentially multiple enrichment of an access request
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74296/
-----------------------------------------------------------
Review request for ranger, madhan and Madhan Neethiraj.
Bugs: RANGER-4070
https://issues.apache.org/jira/browse/RANGER-4070
Repository: ranger
Description
-------
Ranger enriches the access request before it is evaluated for access. The request enrichment is done when Ranger APIs provided in for access evaluation are invoked.
There may be some control flows where there is a potential of same access request getting enriched multiple times. Request enrichment may be an expensive operation, hence a mechanism to control access enrichment is such scenarios is desirable.
Diffs
-----
agents-common/src/main/java/org/apache/ranger/plugin/service/RangerDefaultRequestProcessor.java 636d09038
agents-common/src/main/java/org/apache/ranger/plugin/util/RangerAccessRequestUtil.java 05d9a6007
Diff: https://reviews.apache.org/r/74296/diff/1/
Testing
-------
Compiled clean and ran all unit tests successfully
Thanks,
Abhay Kulkarni
Re: Review Request 74296: RANGER-4070: Provide mechanism to manage potentially multiple enrichment of an access request
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74296/#review225153
-----------------------------------------------------------
Fix it, then Ship it!
agents-common/src/main/java/org/apache/ranger/plugin/util/RangerAccessRequestUtil.java
Lines 214 (patched)
<https://reviews.apache.org/r/74296/#comment313923>
Since getIsRequestPreprocessed() wouldn't return null, consider changing the return type to "boolean".
- Madhan Neethiraj
On Feb. 4, 2023, 6:42 p.m., Abhay Kulkarni wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74296/
> -----------------------------------------------------------
>
> (Updated Feb. 4, 2023, 6:42 p.m.)
>
>
> Review request for ranger, madhan and Madhan Neethiraj.
>
>
> Bugs: RANGER-4070
> https://issues.apache.org/jira/browse/RANGER-4070
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Ranger enriches the access request before it is evaluated for access. The request enrichment is done when Ranger APIs provided in for access evaluation are invoked.
>
> There may be some control flows where there is a potential of same access request getting enriched multiple times. Request enrichment may be an expensive operation, hence a mechanism to control access enrichment is such scenarios is desirable.
>
>
> Diffs
> -----
>
> agents-common/src/main/java/org/apache/ranger/plugin/service/RangerDefaultRequestProcessor.java 636d09038
> agents-common/src/main/java/org/apache/ranger/plugin/util/RangerAccessRequestUtil.java 05d9a6007
>
>
> Diff: https://reviews.apache.org/r/74296/diff/1/
>
>
> Testing
> -------
>
> Compiled clean and ran all unit tests successfully
>
>
> Thanks,
>
> Abhay Kulkarni
>
>
Re: Review Request 74296: RANGER-4070: Provide mechanism to manage potentially multiple enrichment of an access request
Posted by Abhay Kulkarni <ak...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74296/
-----------------------------------------------------------
(Updated Feb. 5, 2023, 5:52 a.m.)
Review request for ranger, madhan and Madhan Neethiraj.
Changes
-------
Addressed review comment
Bugs: RANGER-4070
https://issues.apache.org/jira/browse/RANGER-4070
Repository: ranger
Description
-------
Ranger enriches the access request before it is evaluated for access. The request enrichment is done when Ranger APIs provided in for access evaluation are invoked.
There may be some control flows where there is a potential of same access request getting enriched multiple times. Request enrichment may be an expensive operation, hence a mechanism to control access enrichment is such scenarios is desirable.
Diffs (updated)
-----
agents-common/src/main/java/org/apache/ranger/plugin/service/RangerDefaultRequestProcessor.java 636d09038
agents-common/src/main/java/org/apache/ranger/plugin/util/RangerAccessRequestUtil.java 05d9a6007
Diff: https://reviews.apache.org/r/74296/diff/2/
Changes: https://reviews.apache.org/r/74296/diff/1-2/
Testing
-------
Compiled clean and ran all unit tests successfully
Thanks,
Abhay Kulkarni