You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@orc.apache.org by GitBox <gi...@apache.org> on 2023/01/09 02:26:35 UTC

[GitHub] [orc] wgtmac commented on a diff in pull request #1358: ORC-1348: [C++] TimezoneImpl constructor should pass vector ref

wgtmac commented on code in PR #1358:
URL: https://github.com/apache/orc/pull/1358#discussion_r1064248763


##########
c++/src/Timezone.cc:
##########
@@ -565,7 +565,7 @@ namespace orc {
 
   class TimezoneImpl : public Timezone {
    public:
-    TimezoneImpl(const std::string& name, const std::vector<unsigned char> bytes);
+    TimezoneImpl(const std::string& name, const std::vector<unsigned char>& bytes);

Review Comment:
   nit: the function parameter names are inconsistent between declaration and definition. It would be nice to make them consistent.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@orc.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org